A way to save player data?

[DJ1TJOO]

I have a research table and you need to research a couple of recipes before you can craft them. I want to use the PlayerEvent.ItemCraftedEvent to check if a player has learned it. How would I do something like this?

[DJ1TJOO]

  On 1/31/2020 at 1:37 PM, diesieben07 said:

You can use capabilities to attach data to existing entities.

Expand  

Thanks, I didn't know you could use capabilities on enities!

[DJ1TJOO]

  On 1/31/2020 at 1:37 PM, diesieben07 said:

You can use capabilities to attach data to existing entities.

Expand  

How do I attach my capability to the player?
https://github.com/DJ1TJOO/fantasy20

[Cyborgmas]

It's an event, something like OnAttachCapability<Entity> 

[DJ1TJOO]

  On 1/31/2020 at 2:56 PM, Cyborgmas said:

It's an event, something like OnAttachCapability<Entity> 

Expand  

Yeeh but it asks for a capability provider and a resource location both I do not have

[DJ1TJOO]

  On 1/31/2020 at 3:04 PM, diesieben07 said:

You don't attach a capability, you attach an ICapabilityProvider, which then exposes your capability. It's an interface, you need to implement it.

The ResourceLocation is to uniquely identify your attached provider.

Expand  

Do I need to implement it in a new class or in my class wich extends my capability interface?

[DJ1TJOO]

  On 1/31/2020 at 3:16 PM, diesieben07 said:

It's an interface. Nobody cares how or where you implement it. That is the point of an interface.

Expand  

Do I need to register it somewhere?

[DJ1TJOO]

  On 1/31/2020 at 3:29 PM, diesieben07 said:

No, you attach it using the event.

Expand  

playerIn.getCapability(CapabilityResearchProvider.RESEARCH_CAPABILITY, null).ifPresent(r -> {System.err.println("c");}); never works. 


https://github.com/DJ1TJOO/fantasy20/blob/master/src/main/java/nl/fantasynetworkmc/fantasy20/items/Blueprint.java#L41

 

[DJ1TJOO]

  On 1/31/2020 at 3:48 PM, DJ1TJOO said:

playerIn.getCapability(CapabilityResearchProvider.RESEARCH_CAPABILITY, null).ifPresent(r -> {System.err.println("c");}); never works. 


https://github.com/DJ1TJOO/fantasy20/blob/master/src/main/java/nl/fantasynetworkmc/fantasy20/items/Blueprint.java#L41

 

Expand  

I think I've found the problem but do not know how to solve it. The AttachCapabilitiesEvent<Entity> is not firing:
https://github.com/DJ1TJOO/fantasy20/blob/master/src/main/java/nl/fantasynetworkmc/fantasy20/setup/RegistryEvents.java#L121

[Draco18s]

https://github.com/DJ1TJOO/fantasy20/blob/master/src/main/java/nl/fantasynetworkmc/fantasy20/setup/RegistryEvents.java#L44

That's the wrong bus.

Don't combine your event handlers like this. AttachCap is not a registry event, its a game event.

[DJ1TJOO]

  On 1/31/2020 at 6:41 PM, Draco18s said:

https://github.com/DJ1TJOO/fantasy20/blob/master/src/main/java/nl/fantasynetworkmc/fantasy20/setup/RegistryEvents.java#L44

That's the wrong bus.

Don't combine your event handlers like this. AttachCap is not a registry event, its a game event.

Expand  

What bus does it need to be I made a new class GameEvents and registered it in the Fantasy20 class with MinecraftForge.EVENT_BUS.register(GameEvents.class);
Its has the 
@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
https://github.com/DJ1TJOO/fantasy20/tree/master/src/main/java/nl/fantasynetworkmc/fantasy20
O and also my GuiOpenEvent is not firing on the main screen

Edited January 31, 2020 by DJ1TJOO

[Draco18s]

  On 1/31/2020 at 6:46 PM, DJ1TJOO said:

What bus does it need to be

Expand  

There's only two and that one's the wrong one.

[DJ1TJOO]

  On 1/31/2020 at 6:56 PM, Draco18s said:

There's only two and that one's the wrong one.

Expand  

OO you meen Mod.EventBusSubscriber.Bus.FORGE. I thaught it was something totaly different
Edit: Or not? Because it doesn't work

Edited January 31, 2020 by DJ1TJOO

[Draco18s]

show your updated code

[DJ1TJOO]

  On 2/1/2020 at 12:07 AM, Draco18s said:

show your updated code

Expand  

Its on the github: https://github.com/DJ1TJOO/fantasy20/tree/master/src/main/java/nl/fantasynetworkmc/fantasy20

but I think Someone else found the solution I need to make the functions static but I have no time to try it out

It works Thanks!

Edited February 1, 2020 by DJ1TJOO

[Cadiboo]

You event subscribe methods here, here and here are not static but you register you class here with the annotation and here with the register class method.

You might want to read the documentation on events again.

You also register your RegistryEvents to the FORGE event bus here but also register it to the MOD event bus with the annotation here.

You should only register your class once AND the RegistryEvents class only handles events that fire on the MOD event bus so registering it to the FORGE event bus is pointless.

 

Other stuff I’ve noticed:

- You don’t need a proxy but still use one

- Registry#registerAll exists and can be used to register many objects at the same time more cleanly

- Your mod would be better suited using DeferredRegister

[DJ1TJOO]

  On 2/1/2020 at 12:05 PM, Cadiboo said:

Your mod would be better suited using DeferredRegister

Expand  

What do you mean?
I did the registerAll

Edited February 1, 2020 by DJ1TJOO

[Cadiboo]

  On 2/1/2020 at 12:17 PM, DJ1TJOO said:

What do you mean?

Expand  

You don’t do any complex or iterative registration so using DeferredRegister would simplify and clean up your code a ton

[DJ1TJOO]

  On 2/1/2020 at 12:19 PM, Cadiboo said:

You don’t do any complex or iterative registration so using DeferredRegister would simplify and clean up your code a ton

Expand  

Does it make my mod faster or does it any thing else better? Because I never know what I need to add and maby later I need a 

  On 2/1/2020 at 12:19 PM, Cadiboo said:

complex or iterative registration

Expand  

 

[Cadiboo]

  On 2/1/2020 at 12:24 PM, DJ1TJOO said:

Does it make my mod faster or does it any thing else better?

Expand  

It makes your code simpler.

You can still do iterative registration with DeferredRegister and unless you’re doing something very complicated (which you probably shouldn’t be) you can do complex registration too.

[DJ1TJOO]

  On 2/1/2020 at 12:27 PM, Cadiboo said:

It makes your code simpler.

You can still do iterative registration with DeferredRegister and unless you’re doing something very complicated (which you probably shouldn’t be) you can do complex registration too.

Expand  

Then I'm gonna change it. Is there a good way todo it or just as the example is fine?