[1.14.4] How to change block bounds? (Update, Problem with BlockStates)

[Cerandior]

I have a pipe-like block so I was thinking of making it look connected by dynamically changing the block bounds.

However I can't find any method to change the block bounds in the version I am at.

Can it be done?

 

Edited March 12, 2020 by Cerandior

[Draco18s]

Check the vanilla blocks that do this, like the Fence.

[Cerandior]

11 hours ago, Draco18s said:

Check the vanilla blocks that do this, like the Fence.

The Fence seems to use VoxelShapes to determine the different connection states of the block. I am assuming there are some stuff in the block json file too. Can it be done in a much simpler way using the block bounds alone?

Edited March 12, 2020 by Cerandior

[Draco18s]

3 hours ago, Cerandior said:

I am assuming there are some stuff in the block json file too.

Why don't you go look? Those files are in your workspace too (check client-extra.jar)

3 hours ago, Cerandior said:

The Fence seems to use VoxelShapes to determine the different connection states of the block.

I suggest double checking what that code actually does.

[Cerandior]

2 hours ago, Draco18s said:

Why don't you go look? Those files are in your workspace too (check client-extra.jar)

I suggest double checking what that code actually does.

Thank you for the help. I looked a little more carefully and as far as I understand, blockstates are used to determine whether the fence is connected or not and based on that you apply a model to the block.

So I looked at the docs a bit for more information related to blockstates and all I need to do is create IProperty fields in my block class and then add them to the state container with fillStateContainer.
I create BooleanProperties properties for all directions using BlockStateProperties fields and I used getStateForPlacement to determine at which direction should the block connect to.
Also at the blockstate json file I return different models based on the state of connection of the block (Almost exactly the same as fence here, with the two extra values of up and down).

However in-game I see no difference. I get no errors however it seems like I have done something wrong somewhere either in the blockstate file, or in the way I am handling the property fields.

Block Class Here
Block State File Here

I am not used to blockstates. This is the first time I do anything with them, so please excuse any blatantly stupid mistake that I may have made.

[Cerandior]

As soon as I posted this, I had one quick look at the blockstate file again and the problem may actually be the path that I provided for the models. Sorry for wasting your time. Will change the path now and post the update here.

[Cerandior]

Okay, I updated the paths for the models but I still see no difference in game. It is basically the same as it was before I did all these things with the properties and the blockstate.

[Cerandior]

I also can't find out for what the Voxel Shapes are used for. My initial assumption was that they were used to create the different models, however it seems like those are created in the json file. And the blockstate file is what controls which models to add to the block based on its state.

I am guessing the VoxelShapes control the blockbounds / hitbox? Could my problem be related to that?

[Draco18s]

2 hours ago, Cerandior said:

I am guessing the VoxelShapes control the blockbounds / hitbox?

Correct!

[Cerandior]

19 minutes ago, Draco18s said:

Correct!

Okay, so I changed the VoxelShape of the block, however it still doesn't work, now with the bonus feature of the blockbound being gone entirely. I can walk through the blocks.

Also getShape was deprecated for me, but I used it anyway since I couldn't find any alternative.

Updated Block Class: https://github.com/arjolpanci/VanillaExtended/blob/master/src/main/java/teabx/vanillaextended/blocks/TransportPipe.java

[Draco18s]

9 minutes ago, Cerandior said:

Also getShape was deprecated for me, but I used it anyway since I couldn't find any alternative.

As has been mentioned in one thread or another on this forum about once a week for the last year and a half:

Mojang uses @Deprecated incorrectly.

 

By the way:

https://github.com/arjolpanci/VanillaExtended/blob/master/src/main/java/teabx/vanillaextended/main/VanillaExtended.java#L84

Don't do BlockList.transportPipe =, use @ObjectHolder annotations.

https://mcforge.readthedocs.io/en/1.15.x/concepts/registries/#injecting-registry-values-into-fields

 

As for why you can still walk through the block I am not sure.

[Cerandior]

34 minutes ago, Draco18s said:

As has been mentioned in one thread or another on this forum about once a week for the last year and a half:

Mojang uses @Deprecated incorrectly.

 

By the way:

https://github.com/arjolpanci/VanillaExtended/blob/master/src/main/java/teabx/vanillaextended/main/VanillaExtended.java#L84

Don't do BlockList.transportPipe =, use @ObjectHolder annotations.

https://mcforge.readthedocs.io/en/1.15.x/concepts/registries/#injecting-registry-values-into-fields

 

As for why you can still walk through the block I am not sure.

Ignoring the main problem for now, will look at it again. It seems like the block that is already placed doesn't receive updates on its blockstate when I try to connect other pipes to it. So if I place a pipe on the ground, and then another next to it, the one that was just placed adds the connection to it, but I need to break and replace the initial one to make it connect too.

Can I use onNeighborChange to update the state of the block? Or is there something else, because I can't find out how to change the block state there.

Edited March 13, 2020 by Cerandior

[Cerandior]

Okay, I fixed the update thing by using updatePostPlacement and checked there. Probably there are better ways of doing this because at the moment I am checking for every block around it just like in the initial placement but anyway, I am leaving it as it is for the moment.

The only problem that remains now is the block bounds. Not sure why that isn't working.

Updated block class: https://github.com/arjolpanci/VanillaExtended/blob/master/src/main/java/teabx/vanillaextended/blocks/TransportPipe.java

Edited March 13, 2020 by Cerandior

[Draco18s]

35 minutes ago, Cerandior said:

Can I use onNeighborChange to update the state of the block?

Yes. That's why it exists. If a neighbor changes, allow the block to update its own state.

[Cerandior]

Very strange, the rendering is fine however the block bounds are completely gone. Anyone ever had this issue before?
 

 

[Alpvax]

The voxelshapes method takes values between 0 and 1, the model takes 0-16. You need to divide all your voxelshapes by 16.

[Cerandior]

12 minutes ago, Alpvax said:

The voxelshapes method takes values between 0 and 1, the model takes 0-16. You need to divide all your voxelshapes by 16.

I did, but nothing changed.

[Cerandior]

I am an idiot. All my variables were int so the division was not accurate. I was essentially passing 0 to all arguments. Sorry for that.

One final thing. How can I change the particles that show when I break the pipe block, because it just shows a purple mess. I am guessing it's because the pipe block itself doesn't have a json file (one with its name), instead the blockstate determines which models to render in-game. Can I solve the issue by just adding a default block json for the pipe with a specified texture? Would it override the blockstate model?

[Alpvax]

In your model JSON, set the "particle" texture to "#texture" (or whatever you want it to be).

 

I went with the vanilla approach of having base models (in /part/) and then my textured models, which the blockstate references. I'm not sure if there is a better way, as I don't think you can pass in texture overrides from the blockstate file.

 

My models are here: https://github.com/Alpvax/AdvancedAutocrafting/tree/1.15/src/generated/resources/assets/advancedautocrafting/models/block

Edited March 14, 2020 by Alpvax