Jump to content

Two Items Show up the Exact Same in Game?


zdrivesmp

Recommended Posts

So, I just fixed a problem related to texture path and override errors. I added a second item using the same fixed methods as before, but now they show up with the same name, texture, and in the same tab. I'm 99.99% sure that they aren't somehow linked in the code. Any help?

 

Base Mod Code

 

 

package PrimalCraft;

 

import net.minecraft.block.Block;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.common.Mod;

import cpw.mods.fml.common.Mod.Init;

import cpw.mods.fml.common.Mod.Instance;

import cpw.mods.fml.common.Mod.PostInit;

import cpw.mods.fml.common.Mod.PreInit;

import cpw.mods.fml.common.SidedProxy;

import cpw.mods.fml.common.event.FMLInitializationEvent;

import cpw.mods.fml.common.event.FMLPostInitializationEvent;

import cpw.mods.fml.common.event.FMLPreInitializationEvent;

import cpw.mods.fml.common.network.NetworkMod;

import cpw.mods.fml.common.registry.LanguageRegistry;

 

@Mod(modid="PrimalCraft", name="PrimalCraft", version="0.0.1")

@NetworkMod(clientSideRequired=true, serverSideRequired=false)

public class PrimalCraftBase {

 

        // The instance of your mod that Forge uses.

        @Instance("Generic")

        public static PrimalCraftBase instance;

        private final static Item ItemKnappingStone = new ItemKnappingStone(7500);

        private final static Item ItemPickaxeheadStone = new ItemKnappingStone(7501);

       

        // Says where the client and server 'proxy' code is loaded.

        @SidedProxy(clientSide="PrimalCraftClient.ClientProxy", serverSide="PrimalCraft.CommonProxy")

        public static CommonProxy proxy;

       

        @PreInit

        public void preInit(FMLPreInitializationEvent event) {

                // Stub Method

        }

       

        @Init

        public void load(FMLInitializationEvent event) {

                LanguageRegistry.addName(ItemKnappingStone, "Knapping Stone");

                LanguageRegistry.addName(ItemPickaxeheadStone, "Stone Pickaxe Head");

                proxy.registerRenderers();

        }

       

       

       

        @PostInit

        public void postInit(FMLPostInitializationEvent event) {

                // Stub Method

        }

       

}

 

 

 

Item Code 1

 

 

package PrimalCraft;

 

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import net.minecraft.client.renderer.texture.IconRegister;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.item.Item;

import net.minecraft.util.Icon;

 

public class ItemKnappingStone extends Item

{

 

public ItemKnappingStone(int id)

{

 

super(id);

 

setMaxStackSize(1);

setCreativeTab(CreativeTabs.tabTools);

setUnlocalizedName("knappingStone");

 

}

 

@SideOnly(Side.CLIENT)

@Override

public void registerIcons(IconRegister iconRegister)

{

    itemIcon = iconRegister.registerIcon("PrimalCraft:knappingstone");

}

 

}

 

 

 

 

Item Code 2

 

 

package PrimalCraft;

 

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import net.minecraft.client.renderer.texture.IconRegister;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.item.Item;

import net.minecraft.util.Icon;

 

public class ItemPickaxeheadStone extends Item

{

 

public ItemPickaxeheadStone(int id)

{

 

super(id);

 

setMaxStackSize(1);

setCreativeTab(CreativeTabs.tabMaterials);

setUnlocalizedName("pickaxeheadStone");

 

}

 

@SideOnly(Side.CLIENT)

@Override

public void registerIcons(IconRegister iconRegister)

{

    itemIcon = iconRegister.registerIcon("PrimalCraft:pickaxeheadstone");

}

 

}

 

 

Link to comment
Share on other sites

You might also want to register the items with the GameRegistry;

 

GameRegistry.registerItem(ItemKnappingStone, "Knapping Stone");

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

You made 2 different knapping stones:

        private final static Item ItemKnappingStone = new ItemKnappingStone(7500);
        private final static Item ItemPickaxeheadStone = new ItemKnappingStone(7501);

In case you aren't kicking yourself right now because you can't believe you missed it, the proper code would be:

        private final static Item ItemKnappingStone = new ItemKnappingStone(7500);
        private final static Item ItemPickaxeheadStone = new ItemPickaxeheadStone(7501);

Enjoy and good luck.  ;)

 

-edit

Also, you may want to (from a coding perspective) start a habit of giving your variables names that start with a lowercase letter:

private final static Item itemKnappingStone = new ItemKnappingStone(7500);

instead of

private final static Item ItemKnappingStone = new ItemKnappingStone(7500);

It is small, but there may come a time where you are confused if you are referring to a variable or a class and the distinction will help. Variables start with lowercase and classes start with uppercase. Just being ocd. Take it or leave it.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Link to comment
Share on other sites

You made 2 different knapping stones:

 

Missed that when I glanced at his code.

 

I've done that before. :P

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

You made 2 different knapping stones:

 

Missed that when I glanced at his code.

 

I've done that before. :P

 

Everyone has ;)

I didn't see this when I glanced at the code just now via my phone.. I blame the tiny screen <3

Getting code-blind on your own code is quite common, that's the reason why I haven't solved my problems myself like 80% of the times I have asked for help here ^^

 

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Getting code-blind on your own code is quite common, that's the reason why I haven't solved my problems myself like 80% of the times I have asked for help here ^^

 

Ever solved a problem through the process of writing out the post requesting help?

 

I once solved an issue (not a technical one, but what a recipe should be) in a dream.  Well, less dream and more "how would I explain this to my mother?" exploration as I fell asleep.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.