Make certain block constructors public

[peter1745]

I was recently trying to create a custom Effect and a custom glass pane.

But I had to make my own custom class that extended the Effect class since it's constructor is marked protected. I had to the same thing with my custom glass pane.

I don't get why these constructors are protected? Is there actually a reason for it? Seems unnecessary to have to create empty classes just to access a constructor of a vanilla one.

 

I mean yeah, if you're want implement some custom behavior then you obviously have to create a custom class, but I just want custom textures, not custom functionality which means that creating a brand new class is really wasteful.

[peter1745]

  On 3/28/2020 at 3:54 PM, diesieben07 said:

Vanilla Minecraft code is not written with mods in mind. It is written for the vanilla game and only that.

Plus, Minecraft code is ran through an obfuscator, which often does some optimizations and might reduce the actual visibility of the constructors.

 

All that said, there is nothing wrong with just making a subclass, it is not "really wasteful".

Expand  

Yeah I know vanilla isn't developed for mods, but it would still be convenient if you could easily make custom variants of certain blocks and things like effects.

It's not really a big deal to have to create a brand new class, but it's still more convenient if don't have to. Especially since you might not want to add custom behavior.

[DaemonUmbra]

Pretty sure simply using Reflection is also a viable option

[LexManos]

Forge can add ATs to class constructors. We do it for quite a bit. However you cant just be vague and say "some classes".

Make a specific PR and explain why.