If I want to change damage calculation of vanilla enchantments, is ASM the only way to achieve it or is it possible through reflection?

If it is only possible with ASM, then I want to create enchantment and disable vanilla ones.

In order to remove certain enchantments from game, should I just listen to events, such as world generation, fishing, enchanting and anvil, and cancel them or is there a better way to achieve it?

You can replace the Vanilla enchantments by registering your own enchantments with the same resource location as the originals. However, removing the enchantments completely is impossible to do without causing crashes.

40 minutes ago, CHEESEBOT314 said:

You can replace the Vanilla enchantments by registering your own enchantments with the same resource location as the originals.

Thanks. I will try that.

40 minutes ago, CHEESEBOT314 said:

However, removing the enchantments completely is impossible to do without causing crashes.

Enchanting methods are enchantment table, anvil combination and enchanted books which can be obtained through chest loot, fishing, trading, drops, enchanting and bartering.

Is removing enchantments still completely impossible even if I listen to these events and alter enchantments as I wish?

Just now, lisilew said:

Is removing enchantments still completely impossible even if I listen to these events and alter enchantments as I wish?

Even listening to all of those events won't stop other mods from having the vanilla enchants. IE if a tool or sword comes with an enchantment on it when crafted or dropped. What CHEESEBOT means is the enchantments will still exist within the game.

 

If you can get away with overriding the registry to change their function do that.

Honestly just saying you want to replace the vanilla enchantments isn't really enough information to help you. Which ones do you want to replace? And what do you hope to achieve by replacing them?

26 minutes ago, Animefan8888 said:

Honestly just saying you want to replace the vanilla enchantments isn't really enough information to help you.

I apologize for not providing enough information.

My main purpose is to change how damages are calculated.

For example, I want bane of arthropods to deal extra damage to enderman alongside with spider.

I will be playing with my mod only or at least with mods that do not add anything to game so other mods are not a concern to me.

What I mean by removing enchantments is preventing players from obtaining those enchantments through normal ways.

Obtaining those enchantments via commands or mods providing players with items that have those enchantments are fine.

I am aware that those enchantments can still be obtained through commands but I am okay with that as normal players will not have access to that.

Edited April 16, 20205 yr by lisilew
Clarifying what removing enchantments menas

4 minutes ago, lisilew said:

My main purpose is to change how damages are calculated.

The damage based enchantments in Minecraft control their effect through their class directly. IE Enchantment::calcDamageByCreature. However it can't be used to make Bane of Arthropods deal damage to Endermen. In order to do that you will need to use LivingDamageEvent however that might not work how you expect it to because

Quote

At this point armor, potion and absorption modifiers have already been applied to damage

 

38 minutes ago, Animefan8888 said:

In order to do that you will need to use LivingDamageEvent

This is actually what I have implemented.

I have created an enchantment Advanced Bane of Arthropods with calcDamageByCreature returning 0 and when LivingHurtEvent is fired, I modify damage according to enchantment level.

And this brought me another question: how are LivingDamageEvent and LivingHurtEvent different?

 

If using events is the only way to modify effects of enchantments, I will stick with it.

Now, if I want players to be able to use Advanced Bane of Arthropods only, do I register it as minecraft:bane_of_arthropods or is it possible to remove vanilla Bane of Arthropods from normal obtaining methods?

1 hour ago, lisilew said:

And this brought me another question: how are LivingDamageEvent and LivingHurtEvent different?

The difference is when the events are fired. You should actually use LivingHurtEvent I just didn't notice it because LivingDamageEvent shows up first.

 

LivingHurtEvent is fired before the damage reduction calculations are fired whereas LivingDamageEvent is fired afterwards.

1 hour ago, lisilew said:

Now, if I want players to be able to use Advanced Bane of Arthropods only, do I register it as minecraft:bane_of_arthropods or is it possible to remove vanilla Bane of Arthropods from normal obtaining methods?

You should just override the registry. Which is the first option. This way your enchantment will be treated exactly like the bane of arthropods enchantment.