Jump to content

[SOLVED] [1.15.2] Nullifying fall damage does not work


kaydogz

Recommended Posts

I made a dimension called the Realm of the Ancients, and when you fall into the abyss below, I want it to teleport you to the top of the Overworld, Aether-style. I made a capability called FallingFromSky which just stores a boolean that denotes if the player is falling from the dimension. Here is my code:

@SubscribeEvent
	public static void playerTick(final TickEvent.PlayerTickEvent event) {
		if (event.player.dimension == DBMDimension.getType(DBMDimensions.the_realm_of_the_ancients_dimension) && event.player.getPosition().getY() <= 0) {
			DBMTeleporter.teleportPlayerTop(event.player);
			if (!DaBoisMod.getCapabilityOf(event.player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).isFallingFromSky()) DBMPacketHandler.sendToServer(new SSyncFallingFromSkyPacket(true));
		}
		if (event.side == LogicalSide.SERVER && DaBoisMod.getCapabilityOf(event.player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).isFallingFromSky()) {
			if (!event.player.onGround) event.player.fallDistance = 0F;
			else DBMPacketHandler.sendToServer(new SSyncFallingFromSkyPacket(false));
		}
	}

The packets just set the falling from sky variable.

When I fall into the void of the dimension, it successfully teleports me to the top of the Overworld and I fall to the ground and take no damage. However, when I open to LAN just to test how it would work on a server, I die when falling. I tried to debug by logging to the console the falling from sky variable every tick, and it shows that the value is true for only a second in the Overworld, after which it turns false. Any help is appreciated.

Edited by kaydogz
solved
Link to comment
Share on other sites

if (event.side == LogicalSide.SERVER && DaBoisMod.getCapabilityOf(event.player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).isFallingFromSky()) {
	if (!event.player.onGround) event.player.fallDistance = 0F;
	else DBMPacketHandler.sendToServer(new SSyncFallingFromSkyPacket(false));
}

Assuming that the method names are correct, you are already on the server side in this if statement; however, you are still sending a packet to the server.

Also I think there is an entity land event or something, and it might be better to use that for your case.

 

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

I would highly recommend negating fall damage with the player fall event instead, it's super easy. Send a packet to server when it triggers, and negate it there. When the event triggers, just cancel the event. I use it to negate fall damage in exchange for player mana points.

Edited by Turtledove
Link to comment
Share on other sites

30 minutes ago, Turtledove said:

Send a packet to server when it triggers, and negate it there.

Isn't LivingFallEvent also fired on the server side?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Thanks guys! I finally got it to work. I'm not exactly sure how I didn't know the LivingFallEvent existed... but here's the code for anyone that wants to see:

@SubscribeEvent
public static void playerTick(final TickEvent.PlayerTickEvent event) {
	if (event.side == LogicalSide.SERVER && event.player.dimension == DBMDimension.getType(DBMDimensions.the_realm_of_the_ancients_dimension) && event.player.getPosition().getY() <= 0) {
		DBMTeleporter.teleportPlayerTop(event.player);
		if (!DaBoisMod.getCapabilityOf(event.player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).isFallingFromSky())
			DaBoisMod.getCapabilityOf(event.player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).setFallingFromSky(true);
	}
}

@SubscribeEvent
public static void livingFall(final LivingFallEvent event) {
	if (event.getEntity() instanceof PlayerEntity) {
		PlayerEntity player = (PlayerEntity) event.getEntity();
		if (DaBoisMod.getCapabilityOf(player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).isFallingFromSky()) {
			event.setCanceled(true);
			DaBoisMod.getCapabilityOf(player, FallingFromSkyProvider.FALLING_FROM_SKY_CAPABILITY).setFallingFromSky(false);
		}
	}
}
Edited by kaydogz
formatting issue again
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.