[1.15.2] Help setting up a packet sent from the server

[squidlex]

I have setup a packet handler using Forge's SimpleImpl documentation and by looking at other mods' source code. I want to send a packet containing common config values from the server to the client however my current code isn't working and I don't know what to do with it. I don't know how to send my variables across.

 

ConditionsMessage.java

public class ConditionsMessage implements IMessage<ConditionsMessage> {

	public static double dodgePower;

	@Override
	public void encode(ConditionsMessage message, PacketBuffer buffer) {
	}

	@Override
	public ConditionsMessage decode(PacketBuffer buffer) {
		return new ConditionsMessage();
	}

	@Override
	public void handle(ConditionsMessage message, Supplier<Context> supplier) {
		supplier.get().enqueueWork(() -> {
			// Get dodgePower from ConfigHandler class somehow
  			// originally was dodgePower = ConfigHandler.dodgePower;
		});

		supplier.get().setPacketHandled(true);

	}

}

 

Where I send my packet in my main mod class

@SubscribeEvent
	   public void onServerStarting(FMLServerStartedEvent event) {
		  PacketHandler.instance.send(PacketDistributor.ALL.noArg(), new ConditionsMessage());
	   }

 

PacketHandler.class

public class PacketHandler {
    private static final String PROTOCOL_VERSION = "1";
    private static int nextId = 0;
    public static SimpleChannel instance;

    public static void init()
    {
        instance = NetworkRegistry.ChannelBuilder
                .named(new ResourceLocation(Dodge.MODID, "network"))
                .networkProtocolVersion(() -> PROTOCOL_VERSION)
                .clientAcceptedVersions(PROTOCOL_VERSION::equals)
                .serverAcceptedVersions(PROTOCOL_VERSION::equals)
                .simpleChannel();

        register(ConditionsMessage.class, new ConditionsMessage());
    }

    private static <T> void register(Class<T> clazz, IMessage<T> message)
    {
        instance.registerMessage(nextId++, clazz, message::encode, message::decode, message::handle);
    }
}

 

Init() ran from main mod class

public MyMod() {

ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, ConfigHandler.COMMON_SPEC);

FMLJavaModLoadingContext.get().getModEventBus().addListener(this::onCommonSetup);
        MinecraftForge.EVENT_BUS.register(this);
}

private void onCommonSetup(FMLCommonSetupEvent event)
    {
        PacketHandler.init();
    }

 

I'd really appreciate any help given as I've been suck on this for a while.

Edited May 5, 2020 by squidlex
title improvement

[Ugdhar]

Just a thought (I haven't done any packet sending myself yet), you're sending the packet in the server start event, but are there even any clients connected at that point? Who is it sending the packet to? I'd check into that first!

[squidlex]

30 minutes ago, Ugdhar said:

Just a thought (I haven't done any packet sending myself yet), you're sending the packet in the server start event, but are there even any clients connected at that point? Who is it sending the packet to? I'd check into that first!

Thanks for the help!

That's fixed one of my problems now I just need help to sort out what's wrong with my packets.

Edited May 5, 2020 by squidlex

[poopoodice]

in encode() you can write your variables got from the message into the buffer.

in decode() you had already returned a new instance of the message, you can pass the variable read from the buffer to the new instance of the message through the constructor.

in handle() you should be able to access the field from the message.

Just from my experience, might be some mistakes, please point them out if find any.

Edited May 5, 2020 by poopoodice

[squidlex]

14 minutes ago, diesieben07 said:

What is this IMessage interface? It does not exist anymore in 1.15.2 and was superseded by a superior implementation... Why are you re-introducing it?

Thanks for pointing that out I removed it, sorry about that I took it from some source code I'd seen.

 

16 minutes ago, poopoodice said:

you should be able to access the field from the message.

Thanks for your reply, do you know why this isn't working?

public class ConditionsMessage {

	private double dodgePower;

	public ConditionsMessage() {

	}
	
	public ConditionsMessage(double dodgePower) {
		this.dodgePower = dodgePower;
	}

	public void encode(ConditionsMessage message, PacketBuffer buffer) {
        buffer.writeDouble(message.dodgePower);
	}

	public ConditionsMessage decode(PacketBuffer buffer) {
		return new ConditionsMessage(buffer.readDouble());
	}

	public void handle(ConditionsMessage message, Supplier<Context> supplier) {
		supplier.get().enqueueWork(() -> {
			DodgeEvents.dodgePower = message.dodgePower;
		});

		supplier.get().setPacketHandled(true);

	}

}

 

[poopoodice]

How do you register your message?

nvm

 

you sent a packet here

Quote

PacketHandler.instance.send(PacketDistributor.ALL.noArg(), new ConditionsMessage());

but with empty value (no value passed into the constructor

Edited May 5, 2020 by poopoodice

[squidlex]

1 minute ago, poopoodice said:

How do you register your message?

 

Removing the interface broke the way I was registering it, I rewrote how it's registered and it worked, thanks for making me check