[1.15.2] New SoundType - Registry Object not present

[Corgam]

 

Hi,

I'm trying to make a new SoundType for my blocks, but whatever I do I recieve an "java.lang.NullPointerException: Registry Object not present" error. I'm not sure what's exatly going on, maybe you need to assign sounds later or something?

Maybe there is some sort of trick to do it that I'm not aware of? 

Here is the code and the log:

Spoiler

[05maj2020 22:55:57.371] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmluserdevclient, --fml.mcpVersion, 20200307.202953, --fml.mcVersion, 1.15.2, --fml.forgeGroup, net.minecraftforge, --fml.forgeVersion, 31.1.29, --version, MOD_DEV, --assetIndex, 1.15, --assetsDir, C:\Users\Corgam\.gradle\caches\forge_gradle\assets, --username, Dev, --accessToken, ????????, --userProperties, {}]
[05maj2020 22:55:57.375] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 5.0.0-milestone.4+67+b1a340b starting: java version 1.8.0_221 by Oracle Corporation
[05maj2020 22:55:57.973] [main/INFO] [net.minecraftforge.fml.loading.FixSSL/CORE]: Added Lets Encrypt root certificates as additional trust
[05maj2020 22:55:59.131] [main/INFO] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Launching target 'fmluserdevclient' with arguments [--version, MOD_DEV, --gameDir, ., --assetsDir, C:\Users\Corgam\.gradle\caches\forge_gradle\assets, --assetIndex, 1.15, --username, Dev, --accessToken, ????????, --userProperties, {}]
[05maj2020 22:56:01.731] [Render thread/INFO] [net.minecraft.client.Minecraft/]: Setting user: Dev
[05maj2020 22:56:14.476] [Render thread/INFO] [net.minecraft.client.Minecraft/]: Backend library: LWJGL version 3.2.2 build 10
[05maj2020 22:56:16.126] [modloading-worker-1/INFO] [net.minecraftforge.common.ForgeMod/FORGEMOD]: Forge mod loading, version 31.1.29, for MC 1.15.2 with MCP 20200307.202953
[05maj2020 22:56:16.127] [modloading-worker-1/INFO] [net.minecraftforge.common.MinecraftForge/FORGE]: MinecraftForge v31.1.29 Initialized
[05maj2020 22:56:16.207] [modloading-worker-3/ERROR] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Failed to create mod instance. ModID: slavthology, class com.Corgam.Slavthology.Slavthology
java.lang.ExceptionInInitializerError: null
    at com.Corgam.Slavthology.Slavthology.<init>(Slavthology.java:28) ~[?:?]
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_221]
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_221]
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_221]
    at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[?:1.8.0_221]
    at java.lang.Class.newInstance(Unknown Source) ~[?:1.8.0_221]
    at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:131) ~[?:31.1]
    at java.util.function.Consumer.lambda$andThen$0(Unknown Source) ~[?:1.8.0_221]
    at java.util.function.Consumer.lambda$andThen$0(Unknown Source) ~[?:1.8.0_221]
    at net.minecraftforge.fml.ModContainer.transitionState(ModContainer.java:112) ~[?:?]
    at net.minecraftforge.fml.ModList.lambda$null$10(ModList.java:134) ~[?:?]
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) [?:1.8.0_221]
    at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source) [?:1.8.0_221]
    at java.util.stream.AbstractPipeline.copyInto(Unknown Source) [?:1.8.0_221]
    at java.util.stream.ForEachOps$ForEachTask.compute(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.CountedCompleter.exec(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) [?:1.8.0_221]
Caused by: java.lang.NullPointerException: Registry Object not present
    at java.util.Objects.requireNonNull(Unknown Source) ~[?:1.8.0_221]
    at net.minecraftforge.fml.RegistryObject.get(RegistryObject.java:91) ~[?:?]
    at com.Corgam.Slavthology.init.ModBlocks.<clinit>(ModBlocks.java:84) ~[?:?]
    ... 20 more
[05maj2020 22:56:16.291] [Render thread/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event CONSTRUCT, 1 errors found
[05maj2020 22:56:16.291] [Render thread/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 0 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
    at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:278) ~[eventbus-2.0.0-milestone.1-service.jar:?]
    at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:115) ~[forge-1.15.2-31.1.29_mapped_snapshot_20200225-1.15.1-recomp.jar:?]
    at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:97) ~[forge-1.15.2-31.1.29_mapped_snapshot_20200225-1.15.1-recomp.jar:?]
    at net.minecraft.client.Minecraft.<init>(Minecraft.java:398) ~[forge-1.15.2-31.1.29_mapped_snapshot_20200225-1.15.1-recomp.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:141) ~[forge-1.15.2-31.1.29_mapped_snapshot_20200225-1.15.1-recomp.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_221]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_221]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_221]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_221]
    at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55) ~[forge-1.15.2-31.1.29_mapped_snapshot_20200225-1.15.1-recomp.jar:?]
    at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-5.0.0-milestone.4.jar:?]
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-5.0.0-milestone.4.jar:?]
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-5.0.0-milestone.4.jar:?]
    at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-5.0.0-milestone.4.jar:?]
    at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-5.0.0-milestone.4.jar:?]
    at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:102) [forge-1.15.2-31.1.29_mapped_snapshot_20200225-1.15.1-recomp.jar:?]
[05maj2020 22:56:19.485] [Render thread/INFO] [com.mojang.text2speech.NarratorWindows/]: Narrator library for x64 successfully loaded
[05maj2020 22:56:19.591] [Render thread/INFO] [net.minecraft.resources.SimpleReloadableResourceManager/]: Reloading ResourceManager: Default, Mod Resources
[05maj2020 22:56:19.623] [Server-Worker-5/ERROR] [net.minecraftforge.fml.ModLoader/LOADING]: Skipping lifecycle event SETUP, 1 errors found.
[05maj2020 22:56:19.623] [Server-Worker-5/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event SETUP, 1 errors found
[05maj2020 22:56:19.623] [Server-Worker-5/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 0 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
    at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:278) ~[eventbus-2.0.0-milestone.1-service.jar:?]
    at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:115) ~[?:?]
    at net.minecraftforge.fml.client.ClientModLoader.startModLoading(ClientModLoader.java:123) ~[?:?]
    at net.minecraftforge.fml.client.ClientModLoader.lambda$onreload$3(ClientModLoader.java:105) ~[?:?]
    at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:113) ~[?:?]
    at java.util.concurrent.CompletableFuture$AsyncRun.run(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.CompletableFuture$AsyncRun.exec(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) [?:1.8.0_221]
[05maj2020 22:56:25.160] [Server-Worker-7/ERROR] [net.minecraftforge.fml.ModLoader/LOADING]: Skipping lifecycle event ENQUEUE_IMC, 1 errors found.
[05maj2020 22:56:25.161] [Server-Worker-7/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event ENQUEUE_IMC, 1 errors found
[05maj2020 22:56:25.161] [Server-Worker-7/FATAL] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: EventBus 0 shutting down - future events will not be posted.
java.lang.Exception: stacktrace
    at net.minecraftforge.eventbus.EventBus.shutdown(EventBus.java:278) ~[eventbus-2.0.0-milestone.1-service.jar:?]
    at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:115) ~[?:?]
    at net.minecraftforge.fml.client.ClientModLoader.finishModLoading(ClientModLoader.java:137) ~[?:?]
    at net.minecraftforge.fml.client.ClientModLoader.lambda$onreload$4(ClientModLoader.java:107) ~[?:?]
    at java.util.concurrent.CompletableFuture.uniRun(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.CompletableFuture$UniRun.tryFire(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.CompletableFuture$Completion.exec(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) [?:1.8.0_221]
    at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) [?:1.8.0_221]
[05maj2020 22:56:25.410] [Render thread/INFO] [net.minecraft.client.audio.SoundSystem/]: OpenAL initialized.
[05maj2020 22:56:25.411] [Render thread/INFO] [net.minecraft.client.audio.SoundEngine/SOUNDS]: Sound engine started
[05maj2020 22:56:25.584] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[05maj2020 22:56:25.636] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 128x128x4 minecraft:textures/atlas/signs.png-atlas
[05maj2020 22:56:25.637] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[05maj2020 22:56:25.637] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[05maj2020 22:56:25.638] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[05maj2020 22:56:25.639] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[05maj2020 22:56:25.639] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[05maj2020 22:56:26.151] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[05maj2020 22:56:26.153] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[05maj2020 22:56:26.154] [Render thread/INFO] [net.minecraft.client.renderer.texture.AtlasTexture/]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas
 

 

In main file:

 public Slavthology() {
    	final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
    	
    	modEventBus.addListener(this::onClientSetup);
    	
    	ModSounds.SOUND_EVENTS.register(modEventBus);
    	ModBlocks.BLOCKS.register(modEventBus);
    	ModItems.ITEMS.register(modEventBus);
    	ModEntityTypes.ENTITIES.register(modEventBus);
    	ModTileEntities.TILE_ENTITIES.register(modEventBus);
    	ModFeatures.FEATURES.register(modEventBus);
    	
    }

In ModSounds:

public class ModSounds {

	public static final DeferredRegister<SoundEvent> SOUND_EVENTS = new DeferredRegister<>(ForgeRegistries.SOUND_EVENTS, Reference.MOD_ID);


	public static final RegistryObject<SoundEvent> WICKER_WALK = SOUND_EVENTS.register("wicker_walk", () -> new SoundEvent(new ResourceLocation(Reference.MOD_ID,"block.wicker.walk")));
	public static final RegistryObject<SoundEvent> WICKER_BREAK = SOUND_EVENTS.register("wicker_break", () -> new SoundEvent(new ResourceLocation(Reference.MOD_ID,"block.wicker.break")));
	public static final RegistryObject<SoundEvent> WICKER_PLACE = SOUND_EVENTS.register("wicker_place", () -> new SoundEvent(new ResourceLocation(Reference.MOD_ID,"block.wicker.place")));

}

In ModBlocks:

static SoundType WICKER_SOUND = new SoundType(1.0F, 1.0F, ModSounds.WICKER_BREAK.get(), ModSounds.WICKER_WALK.get(), ModSounds.WICKER_PLACE.get(), ModSounds.WICKER_WALK.get(), ModSounds.WICKER_WALK.get());
public static final RegistryObject<Block> WICKER_BLOCK	 = BLOCKS.register("wicker_block", () -> new WillowPlanksBlock(Block.Properties.create(Material.WOOD, MaterialColor.WOOD).hardnessAndResistance(2.0F, 3.0F).sound(WICKER_SOUND)));
	

In sounds.json

{
    "block.wicker.walk": {
        "category": "block",
        "subtitle": "The wicker creaked",
        "sounds": [
            {
                "name": "slavthology:block/block.wicker.walk"
            }
        ]
    },
    "block.wicker.place": {
        "category": "block",
        "subtitle": "The wicker creaked",
        "sounds": [
            {
                "name": "slavthology:block/block.wicker.place"
            }
        ]
    },
    "block.wicker.break": {
        "category": "block",
        "subtitle": "The wicker creaked",
        "sounds": [
            {
                "name": "slavthology:block/block.wicker.break"
            }
        ]
    }
}  

 

Edited May 5, 2020 by Corgam

[Draco18s]

1 hour ago, Corgam said:

ModSounds.SOUND_EVENTS.register(modEventBus);

You call a method here, but the code you've shown does not contain this method.

 

1 hour ago, Corgam said:

java.lang.ExceptionInInitializerError: null
    at com.Corgam.Slavthology.Slavthology.<init>(Slavthology.java:28) ~[?:?]

What line is that?

[Corgam]

 

On 5/6/2020 at 12:05 AM, Draco18s said:

You call a method here, but the code you've shown does not contain this method.

 

What do you mean? You are talking about the register() methode? It is already implemented in DefferedRegister class. Other DefferedRegisters like Blocks or Items worked this way

 

 

On 5/6/2020 at 12:05 AM, Draco18s said:

You call a method here, but the code you've shown does not contain this method.

 

What line is that?

ModBlocks.BLOCKS.register(modEventBus);

 

And also the problem appears only when I try to create a SoundType object. If I register the sounds and don't use them, they work (I can use playsound command inside minecraft and it works fine) 

 

Edited May 7, 2020 by Corgam

[imacatlolol]

Sound events are registered after blocks, so I believe that's part of the issue. One option would be to extend SoundType and override its get methods to make them access RegistryObject entries as needed instead of on initialization. Feels like there should be a cleaner solution though...

[Draco18s]

That's my thought, too.

[Corgam]

1 hour ago, imacatlolol said:

Sound events are registered after blocks, so I believe that's part of the issue. One option would be to extend SoundType and override its get methods to make them access RegistryObject entries as needed instead of on initialization. Feels like there should be a cleaner solution though...

I hope there is. I feel like it is a common thing to do for modders, to add new blocks with new sounds, so it would be nice to have a easier methode to implement it.

[rbmatt]

On 5/7/2020 at 3:45 PM, Corgam said:

I hope there is. I feel like it is a common thing to do for modders, to add new blocks with new sounds, so it would be nice to have a easier methode to implement it.

found any solution? I also have this error

Edited May 13, 2020 by rbmatt

[imacatlolol]

4 hours ago, rbmatt said:

found any solution? I also have this error

Use the solution I posted, it's a fine workaround for the time being until Forge makes an official fix.

[rbmatt]

16 hours ago, imacatlolol said:

Use the solution I posted, it's a fine workaround for the time being until Forge makes an official fix.

could you give me an example of this, please? I'm a little beginner

[imacatlolol]

3 minutes ago, rbmatt said:

could you give me an example of this, please? I'm a little beginner

Spoon-feeding code is frowned upon on these forums, but I can try rewording what I already mentioned in a more tutorial-esque way:

1. Extend SoundType and override all of its "get sound" methods.
2. In the constructor, replace the parameters of SoundEvent with RegistryObject<SoundEvent>. You'll also need to place them is fields, obviously.
3. Put null when the super constructor wants SoundEvent objects, we won't be using them anyways.
4. In the overridden methods, return RegistryObject#get for each of your corresponding objects.

If any of that was confusing, you may need to spend some more time learning Java before you start modding.

[rbmatt]

3 minutes ago, imacatlolol said:

Spoon-feeding code is frowned upon on these forums, but I can try rewording what I already mentioned in a more tutorial-esque way:

1. Extend SoundType and override all of its "get sound" methods.
2. In the constructor, replace the parameters of SoundEvent with RegistryObject<SoundEvent>. You'll also need to place them is fields, obviously.
3. Put null when the super constructor wants SoundEvent objects, we won't be using them anyways.
4. In the overridden methods, return RegistryObject#get for each of your corresponding objects.

If any of that was confusing, you may need to spend some more time learning Java before you start modding.

gave you an idea, thanks