[1.14.4] Need Help with Enchantment Name

[TheMysticalBard]

Hello, I am new to modding on Minecraft and I'm having an issue with my localization. I have a pack.mcmeta file that is using v4, I have an en_us.json that is properly formatted, and I have a registered enchantment. I have no idea why the name is still showing up the way it is. Any help with this would be greatly appreciated. Will also take tips on code style and anything else you see. Thanks in advance.

 

Here's a link to the github: https://github.com/TheMysticalBard/LaunchMod

[Ugdhar]

33 minutes ago, TheMysticalBard said:

I have no idea why the name is still showing up the way it is.

How is that?

 

Also, there is no resources/assets/launch/lang/en_us.json in that repository

 

*edit: another tip, include the gradle stuff in your repo so someone could build your mod by downloading the zip/cloning it. You can see what's included in mine if you're not sure what to include: https://github.com/Ugdhar/structest

Edited May 8, 2020 by Ugdhar

[TheMysticalBard]

10 minutes ago, Ugdhar said:

How is that?

 

Also, there is no resources/assets/launch/lang/en_us.json in that repository

 

*edit: another tip, include the gradle stuff in your repo so someone could build your mod by downloading the zip/cloning it. You can see what's included in mine if you're not sure what to include: https://github.com/Ugdhar/structest

Thanks for the version control tip!

 

It's currently showing up as "enchantment.launch.launch III" on items and books enchanted with it. I do have the json it just wasn't pushed to the repo, let me do that real quick as well.

[TheMysticalBard]

15 minutes ago, Ugdhar said:

How is that?

 

Also, there is no resources/assets/launch/lang/en_us.json in that repository

 

*edit: another tip, include the gradle stuff in your repo so someone could build your mod by downloading the zip/cloning it. You can see what's included in mine if you're not sure what to include: https://github.com/Ugdhar/structest

For some reason the en_us.json is included in the .gitignore Forge supplied.

 

Edit: It's because it's ignoring all things that have "launch" in them, which is the namespace I chose. Rip.

Edited May 8, 2020 by TheMysticalBard
Additional info

[Ugdhar]

10 minutes ago, TheMysticalBard said:

For some reason the en_us.json is included in the .gitignore Forge supplied.

 

Edit: It's because it's ignoring all things that have "launch" in them, which is the namespace I chose. Rip.

Good catch figuring that out Yeah, I was thinking that, just hadn't mentioned it, that launch is probably not a great modid, it's somewhat generic. Not sure if that's causing the entire issue or not, but might be a place to start!

[Ugdhar]

16 minutes ago, TheMysticalBard said:

It's currently showing up as "enchantment.launch.launch III"

in your en_us.lang:

Quote

"enchantment.enchantment.launch.launch" : "Launch"

They don't match up, change the json to match what is displayed (ignore the III I think) and see if that makes a difference.

[TheMysticalBard]

39 minutes ago, Ugdhar said:

in your en_us.lang:

They don't match up, change the json to match what is displayed (ignore the III I think) and see if that makes a difference.

Oh shoot I changed that back when my file structure was wrong and never changed that back. That will probably fix it.

 

Edit: That was it! Originally my assets/launch was instead assets.launch which looks exactly the same in IntelliJ. Once I fixed that it was correct and I just forgot to change the enchantment.enchantment back. Thanks for the help!

Edited May 8, 2020 by TheMysticalBard