Jump to content

Recommended Posts

Posted (edited)

So, I recently tried to add a dimension. But when I try to teleport to it with a command,

it will get stuck, without any log output. I also have a feeling that I didin't register my dimension stuff properly.

 

DimensionInit.java:

Spoiler

 


package de.budschie.deepnether.dimension;

import de.budschie.deepnether.main.References;
import net.minecraft.world.dimension.DimensionType;
import net.minecraftforge.common.DimensionManager;
import net.minecraftforge.common.ModDimension;
import net.minecraftforge.event.world.RegisterDimensionsEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.registries.ObjectHolder;

@EventBusSubscriber(bus = Bus.FORGE, modid = References.MODID)
public class DimensionInit
{
	@ObjectHolder(References.MODID + ":deepnether_dim")
	public static final ModDimension DEEPNETHER_MOD_DIM = null;
	
	public static DimensionType DIMENSION_TYPE_DEEPNETHER = null;
	
	
	@SubscribeEvent
	public static void onDimensionRegistry(RegisterDimensionsEvent event)
	{
		if (DimensionType.byName(DeepnetherModDimension.MOD_DIM_RL) == null)
		{
			DIMENSION_TYPE_DEEPNETHER = DimensionManager.registerDimension(DeepnetherModDimension.MOD_DIM_RL, DEEPNETHER_MOD_DIM, null, false);
		}
	}
}

ModDimensionInit.java:

Spoiler

package de.budschie.deepnether.dimension;

import de.budschie.deepnether.main.References;
import net.minecraftforge.common.ModDimension;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@EventBusSubscriber(bus = Bus.MOD, modid = References.MODID)
public class ModDimensionInit
{
	@SubscribeEvent
	public static void registerModDimension(RegistryEvent.Register<ModDimension> event)
	{
		event.getRegistry().registerAll(new DeepnetherModDimension().setRegistryName(DeepnetherModDimension.MOD_DIM_RL));
	}
}

 

CommandTpDim.java:

Spoiler

package de.budschie.deepnether.commands;

import com.mojang.brigadier.CommandDispatcher;
import com.mojang.brigadier.context.CommandContext;
import com.mojang.brigadier.exceptions.CommandSyntaxException;
import com.mojang.brigadier.tree.LiteralCommandNode;

import net.minecraft.command.CommandSource;
import net.minecraft.command.Commands;
import net.minecraft.command.arguments.DimensionArgument;
import net.minecraft.entity.player.ServerPlayerEntity;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.world.dimension.DimensionType;

public class CommandTpDim
{
	public static void registerCommandTpDim(CommandDispatcher<CommandSource> dispatcher)
	{
		LiteralCommandNode<CommandSource> literalcommandnode = dispatcher.register(Commands.literal("tpdim").requires((p_198740_0_) -> {
	         return p_198740_0_.hasPermissionLevel(2);
	      }).then(Commands.argument("dim", new DimensionArgument()).executes((cmd) ->
			{
				return teleportToDimension(cmd);
			})
		));
		
	}
	
	private static int teleportToDimension(CommandContext<CommandSource> cmdContext)
	{
		try
		{
			ServerPlayerEntity player = cmdContext.getSource().asPlayer();
			player.changeDimension(cmdContext.getArgument("dim", DimensionType.class));

		} catch (CommandSyntaxException e)
		{
			cmdContext.getSource().sendErrorMessage(new StringTextComponent(e.getMessage()));
		}
		
		return 0;
	}
}
Edited by Budschie
Posted

My guess is that you just used the standard Minecraft Teleporter assuming that it works for all dimensions. Note: you can't do that as the teleporter handles logic specifically for teleporting to and from the nether. My knowledge on the matter however is a bit outdated. However, you can verify this by debugging your code at the method you have selected and watch it return null.

  • Like 1
Posted

Well, now I teleport with this code:

			ServerWorld worldnew = DeepnetherMain.server.getWorld(cmdContext.getArgument("dim", DimensionType.class));
						
			player.teleport(worldnew, player.getPosX(), player.getPosY(), player.getPosZ(), player.rotationYaw, player.rotationPitch);

but I will still get stuck.

Posted
22 minutes ago, Budschie said:

Well, now I teleport with this code:


			ServerWorld worldnew = DeepnetherMain.server.getWorld(cmdContext.getArgument("dim", DimensionType.class));
						
			player.teleport(worldnew, player.getPosX(), player.getPosY(), player.getPosZ(), player.rotationYaw, player.rotationPitch);

but I will still get stuck.

Why don't you just use forge setdimension ingame?

  • Thanks 1

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Posted (edited)

I'm pretty sure I've done something wrong while registering my dimension. If I try to teleport to my dimension on the client, it "works", but gets stuck. On the server, my dimension isn't even shown in the autocomplete of the /forge setdimension command.

Edited by Budschie
Posted (edited)
50 minutes ago, Budschie said:

I'm pretty sure I've done something wrong while registering my dimension. If I try to teleport to my dimension on the client, it "works", but gets stuck. On the server, my dimension isn't even shown in the autocomplete of the /forge setdimension command.

Try usingDeferedRegister, it'll most likely fix all your problems.

Edited by Novârch

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Posted
1 minute ago, Budschie said:

Thanks. But how do I use the DeferredRegister with dimensions?

Here's an example of how I did it in my mod. 

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Posted

Side note: you can use DimensionManager.registerOrGetDimension instead of checking for the dimensiontype by name being null.

 

Have you tried setting breakpoints, stepping through the code, and seeing where the code execution gets stuck?

Posted
Just now, Budschie said:

@Ugdhar It gets stuck after the dimension is initialized and after the chunk generator is created. Some network stuff can also be processed and recieved on the main thread.

If you keep stepping through it, do you get to an endless loop or something? I mean, doing that should show you exactly where in the code it's getting stuck. I'm guessing something is null, or there's a loop that never meets its exist condition or something.

 

And I figured you weren't getting a crash since you mentioned that it got stuck. :)

 

You should push this to a github so that people can see updated code as you change things, and see the big picture.

For instance, we have no dimension code, and can't see the resource location of the dimension. Sometimes something that appears unrelated might have something to do with the problem, that's why when I have an issue I always share all my code, I figure since I'm asking for help, what do I know what code is relevant or not? :D

  • Like 1
Posted
Just now, Budschie said:

@Ugdhar I sadly have no github.

It's free, there's no reason to not have one! And it's so helpful. Not to mention if you're not using git, you should start, because its awesome. Here are some links that may help you get started, don't be scared!

https://github.com/

https://readwrite.com/2013/09/30/understanding-github-a-journey-for-beginners-part-1/

https://www.atlassian.com/git/tutorials/using-branches

Posted
6 hours ago, Budschie said:

@Novârch

Thats a bit long. You can do this shorter:


public static final RegistryObject<ModDimension> D4C_DIMENSION = DIMENSIONS.register("d4c_dimension", D4CDimensionType::new);

 

Congratulations, you shortened my code by TWO CHARACTERS.

  • Haha 1

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Posted
2 hours ago, Budschie said:

@Ugdhar I think I have now set up my github repo, please tell me if I did

something wrong. Link: https://github.com/Budschie/Deepnether-Mod

Hmm, where are you registering your DimensionType? I can't seem to find it anywhere, and based on the first post it was supposed to be in DimensionInit.

 

Also, I noticed there are still a few references to examplemod in your mods.toml and build.gradle, don't forget to change them to reference deepnether :)

Posted
19 minutes ago, Budschie said:

@Ugdhar Thanks. How do I register my DimensionType with a deferred register?

 

On 5/13/2020 at 1:01 PM, Novârch said:
On 5/13/2020 at 12:59 PM, Budschie said:

Thanks. But how do I use the DeferredRegister with dimensions?

Here's an example of how I did it in my mod. 

 

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.