Jump to content

[1.15.2] Dimension registering problem


QuantumSoul

Recommended Posts

Hey,

I tried registering my custom dimension but it crashes, I checked different times but couldn't find why.

 

 DimensionMod: 

Spoiler

@ObjectHolder(BinaryMod.MOD_ID)
@Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class DimensionMod
{
    private final static String DIM_BINARY_ID = "binary_dimension";
    public static final ResourceLocation DIM_BINARY_RL = new ResourceLocation(BinaryMod.MOD_ID, DIM_BINARY_ID);


    // MODDIMENSION REGISTERING
    @ObjectHolder(DIM_BINARY_ID)
    public static final ModDimension DIM_BINARY_MOD = null;

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(DIM_BINARY_ID));
    }


    // DIMENSION REGISTERING
    @Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus=Mod.EventBusSubscriber.Bus.FORGE)
    private static class ForgeEvents
    {
        @SubscribeEvent
        public static void onRegisterDimensionsEvent(RegisterDimensionsEvent event)
        {
            if(DimensionType.byName(DIM_BINARY_RL) == null)
                DimensionManager.registerDimension(DIM_BINARY_RL, DIM_BINARY_MOD, null, true);
        }
    }
}

 

Crash report:

https://pastebin.com/MsqtmeqS

Link to comment
Share on other sites

6 minutes ago, QuantumSoul said:

Hey,

I tried registering my custom dimension but it crashes, I checked different times but couldn't find why.

 

 DimensionMod: 

  Hide contents


@ObjectHolder(BinaryMod.MOD_ID)
@Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class DimensionMod
{
    private final static String DIM_BINARY_ID = "binary_dimension";
    public static final ResourceLocation DIM_BINARY_RL = new ResourceLocation(BinaryMod.MOD_ID, DIM_BINARY_ID);


    // MODDIMENSION REGISTERING
    @ObjectHolder(DIM_BINARY_ID)
    public static final ModDimension DIM_BINARY_MOD = null;

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(DIM_BINARY_ID));
    }


    // DIMENSION REGISTERING
    @Mod.EventBusSubscriber(modid = BinaryMod.MOD_ID, bus=Mod.EventBusSubscriber.Bus.FORGE)
    private static class ForgeEvents
    {
        @SubscribeEvent
        public static void onRegisterDimensionsEvent(RegisterDimensionsEvent event)
        {
            if(DimensionType.byName(DIM_BINARY_RL) == null)
                DimensionManager.registerDimension(DIM_BINARY_RL, DIM_BINARY_MOD, null, true);
        }
    }
}

 

Crash report:

https://pastebin.com/MsqtmeqS

Your setRegistryName does not include a namespace.

Link to comment
Share on other sites

25 minutes ago, kaydogz said:

Your setRegistryName does not include a namespace.

I changed it to

    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(BinaryMod.MOD_ID + ":" + DIM_BINARY_ID));
    }

And It still crashes with the same error.

Link to comment
Share on other sites

Your object holder annotation is bad.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

4 minutes ago, Draco18s said:

Your object holder annotation is bad.

How ? I tried adding a namespace but it didn't work so I removed it and

I found that it is the top one, the @ObjectHolder at the top which is crashing.

My work around is to do that

Spoiler

    public static final ModDimension DIM_BINARY_MOD = new ModDimension() {
        @Override
        public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
        {
            return BinaryDimension::new;
        }
    };

    // MODDIMENSION REGISTERING
    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(DIM_BINARY_MOD.setRegistryName(DIM_BINARY_RL));
    }

But I think it's not good

 

Edited by QuantumSoul
Link to comment
Share on other sites

16 minutes ago, QuantumSoul said:

I changed it to


    @SubscribeEvent
    public static void registerModDimensions(final RegistryEvent.Register<ModDimension> event)
    {
        event.getRegistry().register(new ModDimension() {
            @Override
            public BiFunction<World, DimensionType, ? extends Dimension> getFactory()
            {
                return BinaryDimension::new;
            }
        }.setRegistryName(BinaryMod.MOD_ID + ":" + DIM_BINARY_ID));
    }

And It still crashes with the same error.

Use your resource location, not a concatenation of strings.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.