[1.15.2] Problems with custom inventory

[Nozzomi]

I currently have a custom inventory that has two problems:

• Client side doesn't allow items to enter the custom slots (as it should), but server side allows items to enter the slots
• Opening the custom inventory will move items around and sometimes dupe things as well.

I think the second problem is possibly coming from how I add the slots are being added in the container, but I'm not exactly sure why beyond that.

 

Container class

Spoiler

package mod.mythusteam.mythus.inventory;

import mod.mythusteam.mythus.capabilities.interfaces.ICoreStorage;
import mod.mythusteam.mythus.init.MythusContainers;
import mod.mythusteam.mythus.inventory.slots.MythusSlotCores;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.player.PlayerInventory;
import net.minecraft.inventory.container.ClickType;
import net.minecraft.inventory.container.Container;
import net.minecraft.inventory.container.Slot;
import net.minecraft.item.ItemStack;
import org.apache.commons.lang3.tuple.ImmutablePair;

import java.util.ArrayList;
import java.util.List;

public class CoreStorageContainer extends Container
{
    private final int CORES_SIZE;
    private static final List<ImmutablePair<Integer,Integer>> slotCoords = new ArrayList<ImmutablePair<Integer, Integer>>(5)
    {{
        //(x,y)
        add(new ImmutablePair<>(80, 17));
        add(new ImmutablePair<>(44, 44));
        add(new ImmutablePair<>(116, 44));
        add(new ImmutablePair<>(61, 84));
        add(new ImmutablePair<>(101, 84));
    }};

    public CoreStorageContainer(int id, PlayerInventory inventory, ICoreStorage cores)
    {
        super(MythusContainers.CORE_STORAGE_CONTAINER.get(), id);

        CORES_SIZE = cores.getSlots();

        //TODO Change texture locations
        for(int i = 0; i < cores.getSlots(); i++)
        {
            this.addSlot(new MythusSlotCores(cores, i, slotCoords.get(i).left, slotCoords.get(i).right));
        }

        for (int i = 0; i < 3; ++i)
        {
            for (int j = 0; j < 9; ++j)
            {
                this.addSlot(new Slot(inventory, j + i * 9 + 9, 8 + j * 18, 132 + i * 18));
            }
        }

        for (int i = 0; i < 9; ++i)
        {
            this.addSlot(new Slot(inventory, i, 8 + i * 18, 190));
        }
    }

    @Override
    public boolean canInteractWith(PlayerEntity playerIn) {
        return true;
    }

    @Override
    public ItemStack slotClick(int slotId, int dragType, ClickType clickTypeIn, PlayerEntity player) {
        return super.slotClick(slotId, dragType, clickTypeIn, player);
    }

    @Override
    public ItemStack transferStackInSlot(PlayerEntity playerIn, int index)
    {
        ItemStack itemstack = null;
        Slot slot = this.inventorySlots.get(index);

        if(slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();
            if(index >= 0 && index < CORES_SIZE)
            {
                if (!this.mergeItemStack(itemstack1, CORES_SIZE+1, CORES_SIZE+36+1, true))
                {
                    return null;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if(index >= CORES_SIZE)
            {
                if(!this.mergeItemStack(itemstack1, 0, CORES_SIZE, false))
                {
                    return null;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }

            if (itemstack1.getCount() == 0)
            {
                slot.putStack(null);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.getCount() == itemstack.getCount())
            {
                return null;
            }

        }

        return itemstack;
    }
}
 

  

Capability Instance Class

Spoiler

package mod.mythusteam.mythus.capabilities.instances;

import mod.mythusteam.mythus.capabilities.interfaces.ICoreStorage;
import mod.mythusteam.mythus.items.cores.MythusCore;
import net.minecraft.item.ItemStack;
import net.minecraftforge.items.ItemStackHandler;

import javax.annotation.Nonnull;

public class CoreStorageInstance extends ItemStackHandler implements ICoreStorage
{
    int level;

    public CoreStorageInstance()
    {
        super(5); //TODO Change?
    }

    @Override
    public int getLevel() {
        return level;
    }

    @Override
    public void setLevel(int level) {
        this.level = level;
    }

    @Override
    public boolean isItemValid(int slot, @Nonnull ItemStack stack) {
        return stack.getItem() instanceof MythusCore;
    }

    @Nonnull
    @Override
    public ItemStack insertItem(int slot, @Nonnull ItemStack stack, boolean simulate) {
        if(stack.getItem() instanceof MythusCore)
            return super.insertItem(slot, stack, simulate);
        else
            return ItemStack.EMPTY;
    }
}
 

 

The transferStackInSlot method is screwed up, but I'll try to fix it after I get these two pretty serious problems out of the way

[Draco18s]

14 minutes ago, Nozzomi said:

publicpublic ItemStack insertItem(int slot, @Nonnull ItemStack stack, boolean simulate) {
        if(stack.getItem() instanceof MythusCore)
            return super.insertItem(slot, stack, simulate);
        else
            return ItemStack.EMPTY;
    }

So, if it is the wrong item, destroy it?

[Nozzomi]

@Draco18s Oops right, I think I just put that there just to see if checking for the right item there would stop server side from allowing it into the slot

[Nozzomi]

Alright, i fixed the problems with the player inventory, but the server side not agreeing with client side still is happening

[Nozzomi]

@diesieben07 Whenever i try to click an invalid item into one of the custom slots, it won't let the item in, but when i open and close that inventory, the item ends up in that slot

[Nozzomi]

I open the gui in the container by using ClientTickEvent

Spoiler

@SubscribeEvent
    public static void onClientTickEvent(final TickEvent.ClientTickEvent event)
    {
        if (event.phase != TickEvent.Phase.END) return;

        if(Mythus.keyBindings[0].isPressed())
        {
            MythusPacketHandler.INSTANCE.sendToServer(new MythusCoreStorageGUIPacket());
        }
    }

Then in the packet I just use the NetworkHooks#openGui

Spoiler

public static void handle(MythusCoreStorageGUIPacket pkt, Supplier<NetworkEvent.Context> ctx)
    {
        if(ctx.get().getDirection().getReceptionSide().isServer())
        {
            ctx.get().enqueueWork(() -> {
                PlayerEntity player = ctx.get().getSender();
                player.getCapability(CapabilityCoreStorage.CORE_STORAGE_CAPABILITY).ifPresent(cap -> {
                    NetworkHooks.openGui((ServerPlayerEntity) player, new CoreStorageContainerProvider());
                });
            });
            ctx.get().setPacketHandled(true);
        }
    }

 

 

And uhhh, I just register the container type using the DeferredRegister

public static final RegistryObject<ContainerType<CoreStorageContainer>> CORE_STORAGE_CONTAINER = CONTAINERS.register("core_storage_container",
            () -> new ContainerType<CoreStorageContainer>((id, inv) -> new CoreStorageContainer(id, inv, new CoreStorageInstance())));

 

[Nozzomi]

How would I get the player instance?

[Nozzomi]

11 minutes ago, diesieben07 said:

You're given a PlayerInventory, which has the PlayerEntity.

I tried using the capability, but the result is the same. The inventory is saving properly though, but so at least that's not a problem.

 

This is what I have now instead

public static final RegistryObject<ContainerType<CoreStorageContainer>> CORE_STORAGE_CONTAINER = CONTAINERS.register("core_storage_container",
            () -> new ContainerType<>((id, inv) -> new CoreStorageContainer(id, inv, inv.player.getCapability(CapabilityCoreStorage.CORE_STORAGE_CAPABILITY).orElse(new CoreStorageInstance()))));

 

[Nozzomi]

18 hours ago, diesieben07 said:

Well, I don't see the problem. Post a Git repo of your mod so people can try this locally.

https://github.com/soravoid/Mythus

[Nozzomi]

5 minutes ago, diesieben07 said:

Both your IItemHandler and your slot (the latter unnecessarily, because the item handler already does it) check for instanceof MythusCore. An item with that class is never created. Thus, nothing can ever be put in the slots (client or server side).

I was not able to reproduce any duping or moving of items in the survival inventory that's shown below. I was not able to put any items into the upper slots (for the reason explained above).

 

Please clarify what your issue is and how to reproduce it.

Here's a video of me showing what I'm having problems with.

 

First, I'm showing the clicking the item into the slot that's doesn't allow it, then opening and closing that inventory, where the item ends up in the slot. After that, I'm switching between the vanilla inventory and the custom inventory quickly and the items eventually start to pile up in my inventory. 

 

[Draco18s]

That usually happens when you screw up your slot indexes.

[Nozzomi]

20 minutes ago, Draco18s said:

That usually happens when you screw up your slot indexes.

for (int i = 0; i < 3; ++i)
{
    for (int j = 0; j < 9; ++j)
    {
        Mythus.LOG.info(j + i * 9 + 9);
        this.addSlot(new Slot(inventory, j + i * 9 + 9, 8 + j * 18, 132 + i * 18));
    }
}

for (int i = 0; i < 9; ++i)
{
        Mythus.LOG.info(i);
        this.addSlot(new Slot(inventory, i, 8 + i * 18, 190));
}

What would be wrong with this? No numbers are repeating in the logs I think

[Draco18s]

Those aren't your only slots, are they.

 

[Nozzomi]

Just now, Draco18s said:

Those aren't your only slots, are they.

 

No, they aren't

for(int i = 0; i < cores.getSlots(); i++)
{
    this.addSlot(new SlotItemHandler(cores, i, slotCoords.get(i).left, slotCoords.get(i).right));
}

I didn't think that they'd affect the player inventory because they're using the indices for a different IItemHandler...it seems I might be wrong though...?

[Draco18s]

48 minutes ago, Nozzomi said:

No, they aren't

for(int i = 0; i < cores.getSlots(); i++)
{
    this.addSlot(new SlotItemHandler(cores, i, slotCoords.get(i).left, slotCoords.get(i).right));
}

I didn't think that they'd affect the player inventory because they're using the indices for a different IItemHandler...it seems I might be wrong though...?

Had to check.

[Nozzomi]

1 hour ago, diesieben07 said:

I'm unable to reproduce the effect you showed in your video.

I clicked the slot with an item like a madman, the item does not go in.

 

I also smashed ^ and e in succession like a mad man to quickly switch between the inventory and your GUI. No duplication could be observed.

That's super weird, I guess the only option now is to...reinstantiate (is that the correct term or even a word?!?!) the forge project and will see what happens

39 minutes ago, Draco18s said:

Had to check.

Was there anything that might've royally screwed me over in terms of adding the inventory?

[Draco18s]

18 minutes ago, Nozzomi said:

Was there anything that might've royally screwed me over in terms of adding the inventory?

If you had inadvertently linked the player inventory instead of your container inventory.

When that happens, you get a very similar effect to your video.

[Nozzomi]

Is it possible for me to extend on the player's regular ItemStackHandler capability? Maybe if I add the container through an already existing capability, it'll go more smoothly. How would I extend upon that capability?

[Nozzomi]

1 hour ago, diesieben07 said:

Since I can't reproduce this on my end, you need to debug this yourself.

Put a breakpoing in insertItem (and setStackInSlot) of your item handler. Then reproduce the "wrong item in slot" bug and see where the method is called from.

Then report your findings here.

I think what I've found is that inserItem and setStackInSlot isn't called when I try to ghost insert my item in the custom inventory, but the item somehow still ends up in the slot it's not supposed to be in. I also tried sticking an extra isItemValid() check in the setStackInSlot method before the super, but it ended up not showing the items, but if I clicked on the slot, the item would still be there, just no longer showing.

[Nozzomi]

27 minutes ago, diesieben07 said:

That's... not possible...

Video

 

The sword is placed in according to the server but the breakpoint doesn't stop me when I click with the sword. The setStackInSlot part is because the item is already recognized as in there...? (It's definitely your word over mine, I'm a little lost)

[Nozzomi]

4 hours ago, diesieben07 said:

Did some more digging. You never attach CapabilityCoreStorage.CORE_STORAGE_CAPABILITY to the player. Which is why getCapability for it always returns an empty optional. Which you ignore and just create an empty one. This is not how you handle errors. If you expect the capability to be there, throw an error if it's absent! This is how you get hard to debug problems like this. "Oh, something strange happend that I didn't expect? Oh well, carry on."

This is not PHP.

Wait, but don't I? I have

e.addCapability(CapabilityCoreStorage.LOCATION, new CapabilityCoreStorage());

where LOCATION is just the ResourceLocation needed to attach the capability, right?

[Nozzomi]

Also, I changed the orElse into an orElseThrow and it hasn't given me any errors (though I'm  not sure whether or not to be happy since the problem isn't any clearer...)

public static final RegistryObject<ContainerType<CoreStorageContainer>> CORE_STORAGE_CONTAINER = CONTAINERS.register("core_storage_container",
    () -> new ContainerType<>((id, inv) -> new CoreStorageContainer(id, inv, inv.player.getCapability(CapabilityCoreStorage.CORE_STORAGE_CAPABILITY).orElseThrow(() -> new NullPointerException("Core Storage Capability not found!")))));

 

Edited May 30, 2020 by Nozzomi

[Nozzomi]

2 hours ago, diesieben07 said:

Please clone your own repo in a separate folder and check if you have the error there as well.

Huh, I couldn't reproduce it either...

 

I ended up fixing the problem in the original code by creating a new world since I figured that if it worked in the git clone, it must've had something to do with the run folder. In hindsight, I probably should've created a new world in the first place since I was attaching a capability to the player. Thank you for helping me through!