FireworkRocketEntity should fire ProjectileImpactEvent

[[NoOneButNo]]

The title is very self-explanatory.

[DavidM]

FireworkRocketEntity is not a projectile; it wouldn’t make sense for it to trigger ProjectileImpactEvent.

[[NoOneButNo]]

I don't know about that

public class FireworkRocketEntity extends Entity implements IRendersAsItem, IProjectile

 

The class CLEARLY implements IProjectile.

Edited June 10, 2020 by [NoOneButNo]
Addition

[DaemonUmbra]

It doesn't act like anything else that uses the interface, other projectiles follow an arc, Fireworks just go up.

What's the use case here?

[Novârch]

  On 6/10/2020 at 6:23 PM, DaemonUmbra said:

Fireworks just go up.

Expand  

What about when they're fired from a crossbow?

[DaemonUmbra]

I didn't realize that was a thing! I haven't really played in a long time.

Edit: https://github.com/MinecraftForge/MinecraftForge/pull/6758

Edited June 10, 2020 by DaemonUmbra

[DavidM]

  On 6/10/2020 at 10:21 AM, [NoOneButNo] said:

I don't know about that

public class FireworkRocketEntity extends Entity implements IRendersAsItem, IProjectile

 

The class CLEARLY implements IProjectile.

Expand  

It doesn't act similarly to other projectiles.

 

  On 6/10/2020 at 6:26 PM, Novârch said:

What about when they're fired from a crossbow?

Expand  

Whoa when did that get added?

Edited June 11, 2020 by DavidM

[[NoOneButNo]]

  On 6/11/2020 at 12:58 AM, DavidM said:

It doesn't act similarly to other projectiles.

Expand  

While yes they do, the fact that they are fire-able from crossbows and code-wise uses raytrace means that they should be treated as such (imo). I imagined it as real life firework flying towards you and not calling it a projectile (Projectile definition: an object propelled through the air, especially one thrown as a weapon).

[Novârch]

  On 6/11/2020 at 12:58 AM, DavidM said:

Whoa when did that get added?

Expand  

1.14