[1.15.2] Recipe getRemainingItems not triggered

[Slexom]

In a custom recipe use a Water Bucket as ingredient to create another fluid bucket. The recipe work except for an empty bucket left on the crafting matrix.
To remove the empty bucket I was trying to use the ItemCraftedEvent, because I suppose is an event that trigger when an item is crafted. The problem is that the event don't run.
The code just contain some println to check what the methods of the event return to me.

 

REMOVED

Edited June 11, 2020 by Slexom
Changed title

[DavidM]

You can’t modify the crafting matrix in that event.

Create a custom IRecipe instead.

[Slexom]

Created a recipe extending a ShapelessRecipe but the getRemainingItems is not triggered. I think is in that function where I can exclude the empty bucket, no?

Recipe

Spoiler

 

public class MudBucketRecipe extends ShapelessRecipe {

    public MudBucketRecipe(ResourceLocation idIn, String groupIn, ItemStack recipeOutputIn, NonNullList<Ingredient> recipeItemsIn) {
        super(idIn, groupIn, recipeOutputIn, recipeItemsIn);
    }

    @Override
    public NonNullList<ItemStack> getRemainingItems(final CraftingInventory inv) {
        System.out.println("HERE");
        final NonNullList<ItemStack> remainingItems = NonNullList.withSize(inv.getSizeInventory(), ItemStack.EMPTY);
        for (int i = 0; i < remainingItems.size(); ++i) {
            ItemStack itemstack = inv.getStackInSlot(i);
            if (itemstack.hasContainerItem() && itemstack.getItem() != Items.BUCKET) {
                remainingItems.set(i, itemstack.getContainerItem());
            }
        }
        return remainingItems;
    }
    public IRecipeSerializer<?> getSerializer() {
        return RecipesInit.MUD_BUCKET_RECIPE.get();
    }

    public static class Serializer extends ForgeRegistryEntry<IRecipeSerializer<?>> implements IRecipeSerializer<MudBucketRecipe> {
        @Override
        public MudBucketRecipe read(final ResourceLocation recipeID, final JsonObject json) {
            final String group = JSONUtils.getString(json, "group", "");
            final NonNullList<Ingredient> ingredients = NonNullList.create();
            for (final JsonElement element : JSONUtils.getJsonArray(json, "ingredients")) {
                ingredients.add(CraftingHelper.getIngredient(element));
            }
            if (ingredients.isEmpty()) {
                throw new JsonParseException("No ingredients for shapeless recipe");
            }
            final ItemStack result = CraftingHelper.getItemStack(JSONUtils.getJsonObject(json, "result"), true);
            return new MudBucketRecipe(recipeID, group, result, ingredients);
        }

        @Override
        public MudBucketRecipe read(final ResourceLocation recipeID, final PacketBuffer buffer) {
            final String group = buffer.readString(Short.MAX_VALUE);
            final int numIngredients = buffer.readVarInt();
            final NonNullList<Ingredient> ingredients = NonNullList.withSize(numIngredients, Ingredient.EMPTY);
            for (int j = 0; j < ingredients.size(); ++j) {
                ingredients.set(j, Ingredient.read(buffer));
            }
            final ItemStack result = buffer.readItemStack();
            return new MudBucketRecipe(recipeID, group, result, ingredients);
        }

        @Override
        public void write(final PacketBuffer buffer, final MudBucketRecipe recipe) {
            buffer.writeString(recipe.getGroup());
            buffer.writeVarInt(recipe.getIngredients().size());
            for (final Ingredient ingredient : recipe.getIngredients()) {
                ingredient.write(buffer);
            }
            buffer.writeItemStack(recipe.getRecipeOutput());
        }
    }
}

 

 

 

 

Registration

Spoiler

public class RecipesInit {

    public static final DeferredRegister<IRecipeSerializer<?>> RECIPES = new DeferredRegister<>(ForgeRegistries.RECIPE_SERIALIZERS, EarthtojavamobsMod.MOD_ID);

    public static final RegistryObject<MudBucketRecipe.Serializer> MUD_BUCKET_RECIPE = RECIPES.register("mud_bucket", MudBucketRecipe.Serializer::new);

}

 

JSON

Spoiler

 

{
  "type": "minecraft:crafting_shapeless",
  "ingredients": [
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:water_bucket"
    },
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:dirt"
    },
    {
      "item": "minecraft:dirt"
    }
  ],
  "result": {
    "item": "earthtojavamobs:mud_fluid_bucket"
  }
}

 

 

 

 

Edited June 11, 2020 by Slexom

[Draco18s]

7 minutes ago, Slexom said:

"type": "minecraft:crafting_shapeless",

You aren't using your own IRecipe type.

[Slexom]

... T-T 

Thank you