Jump to content

Recommended Posts

Posted (edited)

My custom bow that extends the regular BowItem works perfectly fine with the exception of it not loading the pullback textures besides pulling_0. Here is my code:

diamond_bow.json:

 

{
  "parent": "item/generated",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow"
  },
  "display": {
    "thirdperson_righthand": {
      "rotation": [ -80, 260, -40 ],
      "translation": [ -1, -2, 2.5 ],
      "scale": [ 0.9, 0.9, 0.9 ]
    },
    "thirdperson_lefthand": {
      "rotation": [ -80, -280, 40 ],
      "translation": [ -1, -2, 2.5 ],
      "scale": [ 0.9, 0.9, 0.9 ]
    },
    "firstperson_righthand": {
      "rotation": [ 0, -90, 25 ],
      "translation": [ 1.13, 3.2, 1.13],
      "scale": [ 0.68, 0.68, 0.68 ]
    },
    "firstperson_lefthand": {
      "rotation": [ 0, 90, -25 ],
      "translation": [ 1.13, 3.2, 1.13],
      "scale": [ 0.68, 0.68, 0.68 ]
    }
  },
  "overrides": [
    {
      "predicate": {
        "pulling": 1
      },
      "model": "otherutilities:item/diamond_bow_pulling_0"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.65
      },
      "model": "otherutilities:item/diamond_bow_pulling_1"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.9
      },
      "model": "otherutilities:item/diamond_bow_pulling_2"
    }
  ]
}

 

diamond_bow_pulling_0.json:

{
  "parent": "item/bow",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow_pulling_0"
  }
}

 

diamond_bow_pulling_1.json:

{
  "parent": "item/bow",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow_pulling_1"
  }
}

diamond_bow_pulling_2.json:

{
  "parent": "item/bow",
  "textures": {
    "layer0": "otherutilities:items/diamond_bow_pulling_2"
  }
}

I have confirmed that all of the images in the items folder do in fact exist, but only diamond_bow_pulling_0.png loads.

Here is my BaseBow Class:

package com.Silver2040.OtherUtilities.items;

import com.Silver2040.OtherUtilities.OtherUtilities;
import net.minecraft.item.*;
import net.minecraft.util.ResourceLocation;


public class BaseBow extends BowItem {

    public BaseBow(int damage) {
        super((new Item.Properties()).group(OtherUtilities.TAB)
                .maxStackSize(1)
                .maxDamage(damage));


        this.addPropertyOverride(new ResourceLocation("pull"), (stack, world, entity) -> {
            if (entity == null) {
                return 0F;
            } else {
                if (entity.getActiveItemStack().getItem() instanceof BaseBow) {
                    return 0F;
                } else {
                    return (float)(stack.getUseDuration() - entity.getItemInUseCount()) / 20F;
                }
            }
        });

        this.addPropertyOverride(new ResourceLocation("pulling"), (stack, world, entity) -> entity != null && entity.isHandActive() && entity.getActiveItemStack() == stack ? 1F : 0F);

    }

    @Override
    public int getItemEnchantability() {
        return 10;
    }

    
    private boolean isArrow(ItemStack stack) {
        return stack.getItem() instanceof ArrowItem;
    }


}

 

And here is my DiamondBow class:

package com.Silver2040.OtherUtilities.items;

public class DiamondBow extends BaseBow {

    public DiamondBow() {
        super(800);
    }
}

 

To avoid spam and also because I don't think it's really needed, I haven't included the registry file or my main file but if needed I can provide it.

Again, the bow itself loads perfectly, everything works as expected, but the drawback only has 1 pulling frame which is diamond_bow_pulling_0.png 

Thank you in advance.

Edited by fracturx
Posted

Yeah, it looks like the first predicate is matching every pull value, and it's first in the list so it's overriding the other textures.

Add a low pull value.

Posted

Yep, you should add 0 since iirc it will fit the criteria when the value given is larger or equal to the predicate value. Anyways, I remember that forge doc has a explanation on this and you might want to have a look at it.

Posted

Nope, setting

 {
      "predicate": {
        "pulling": 1,
        "pull": 0
      },
      "model": "otherutilities:item/diamond_bow_pulling_0"
    },

pull to 0 doesn't work unfortunately

Posted

it does? what I mean is

    {
      "predicate": {
        "pulling": 1,
        "pull": 0.65
      },
      "model": "otherutilities:item/diamond_bow_pulling_1"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.9
      },
      "model": "otherutilities:item/diamond_bow_pulling_2"
    }
  ]

pull is always 0 which < 0.65 and 0.9

Posted

I think they mean, swap the 0F line with the one below it : the one involving getUseDuration.

If you set it to 1, then the last image will always apply. You need it to change, which is what that line was for:

image.png.f31d3f1c1f0e7f74a8592c8c4f75d848.png

Posted

you misunderstood what I mean.

                if (entity.getActiveItemStack().getItem() instanceof BaseBow) {
                    return 0F;
                } else {
                    return (float)(stack.getUseDuration() - entity.getItemInUseCount()) / 20F;
                }
            }

change the 0F to 1F does not matter because what are you trying to do is to change the bow's model correspond to the bow's pulling duration (time pulled), which you've done that in the else statement. But the else statement is never going to be reached because the item you are holding is an instance of the custom bow class so it will always return the value in the if statement

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have no idea what the flip is going on, I can load the modpack just fine at forge 42.2.0 but any forge version above it insta-crashes with exit code 1. Can somebody tell me what's going on, this is minecraft 1.20.1 Latest.log: https://pastebin.com/pBUL1ZFa
    • does anyone know how to incorporate custom noise settings into a custom dimension through the use of datagen, I have created a custon json file for the noise settings that I want but I just don't know how to get it to register with the generated json file of the custom dimension.   here is the code for the dimension class package net.hurst.lustria.worldgen.dimension; import com.mojang.datafixers.util.Pair; import net.hurst.lustria.Lustria; import net.hurst.lustria.worldgen.biome.ModBiomes; import net.hurst.lustria.worldgen.registries.LustriaNoiseSettings; import net.minecraft.core.HolderGetter; import net.minecraft.core.registries.Registries; import net.minecraft.data.worldgen.BootstapContext; import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; import net.minecraft.tags.BlockTags; import net.minecraft.util.valueproviders.ConstantInt; import net.minecraft.world.level.Level; import net.minecraft.world.level.biome.*; import net.minecraft.world.level.dimension.BuiltinDimensionTypes; import net.minecraft.world.level.dimension.DimensionType; import net.minecraft.world.level.dimension.LevelStem; import net.minecraft.world.level.levelgen.NoiseBasedChunkGenerator; import net.minecraft.world.level.levelgen.NoiseGeneratorSettings; import java.util.List; import java.util.OptionalLong; public class ModDimensions { public static final ResourceKey<LevelStem> LUSTRIA_KEY = ResourceKey.create(Registries.LEVEL_STEM, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<Level> LUSTRIA_LEVEL_KEY = ResourceKey.create(Registries.DIMENSION, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<DimensionType> LUSTRIA_DIM_TYPE = ResourceKey.create(Registries.DIMENSION_TYPE, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim_type")); public static void bootstrapType(BootstapContext<DimensionType> context) { context.register(LUSTRIA_DIM_TYPE, new DimensionType( OptionalLong.of(12000), // fixedTime false, // hasSkylight true, // hasCeiling false, // ultraWarm false, // natural 1.0, // coordinateScale true, // bedWorks false, // respawnAnchorWorks -64, // minY 256, // height 256, // logicalHeight BlockTags.INFINIBURN_OVERWORLD, // infiniburn BuiltinDimensionTypes.OVERWORLD_EFFECTS, // effectsLocation 0.0f, // ambientLight new DimensionType.MonsterSettings(false, false, ConstantInt.of(0), 0))); } public static void bootstrapStem(BootstapContext<LevelStem> context) { HolderGetter<Biome> biomeRegistry = context.lookup(Registries.BIOME); HolderGetter<DimensionType> dimTypes = context.lookup(Registries.DIMENSION_TYPE); HolderGetter<NoiseGeneratorSettings> noiseGenSettings = context.lookup(Registries.NOISE_SETTINGS); NoiseBasedChunkGenerator wrappedChunkGenerator = new NoiseBasedChunkGenerator( new FixedBiomeSource(biomeRegistry.getOrThrow(Biomes.BEACH)), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); NoiseBasedChunkGenerator noiseBasedChunkGenerator = new NoiseBasedChunkGenerator( MultiNoiseBiomeSource.createFromList( new Climate.ParameterList<>(List.of(Pair.of( Climate.parameters(0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BEACH)), Pair.of( Climate.parameters(0.1F, 0.2F, 0.0F, 0.2F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BIRCH_FOREST)), Pair.of( Climate.parameters(0.3F, 0.6F, 0.1F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.OCEAN)), Pair.of( Climate.parameters(0.4F, 0.3F, 0.2F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.DARK_FOREST)) ))), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); LevelStem stem = new LevelStem(dimTypes.getOrThrow(ModDimensions.LUSTRIA_DIM_TYPE), noiseBasedChunkGenerator); context.register(LUSTRIA_KEY, stem); } } minecraft version is 1.20.1
    • Please read the FAQ (https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/) and post logs as described there using a site like https://mclo.gs and post the link to it here. It may have the information required to solve your problem.  
    • the error code comes up when i trry to run it and ive tried to fix it but i cant  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.