[1.15.2] [SOLVED] Custom Tree Help

Posted July 25, 20205 yr

Hi, I'm making my own mod and when creating a custom tree my leaves starts falling always.

TreeClass:

package com.handreans.dancinglizards.world.feature;

import com.handreans.dancinglizards.init.BlockInit;
import net.minecraft.block.trees.Tree;
import net.minecraft.world.gen.blockstateprovider.SimpleBlockStateProvider;
import net.minecraft.world.gen.feature.ConfiguredFeature;
import net.minecraft.world.gen.feature.Feature;
import net.minecraft.world.gen.feature.TreeFeatureConfig;
import net.minecraft.world.gen.foliageplacer.BlobFoliagePlacer;

import java.util.Random;

public class DLTree extends Tree
{
    public static final TreeFeatureConfig DL_TREE_CONFIG = (new TreeFeatureConfig.Builder(
            new SimpleBlockStateProvider(BlockInit.DL_LOG.get().getDefaultState()),
            new SimpleBlockStateProvider(BlockInit.DL_LEAVES.get().getDefaultState()),
            new BlobFoliagePlacer(2, 0)))
            .baseHeight(4)
            .heightRandA(2)
            .foliageHeight(3)
            .ignoreVines()
            .setSapling((net.minecraftforge.common.IPlantable)BlockInit.DL_SAPLING.get()).build();

    @Override
    protected ConfiguredFeature<TreeFeatureConfig, ?> getTreeFeature(Random randIn, boolean b)
    {
        return Feature.NORMAL_TREE.withConfiguration(DL_TREE_CONFIG);
    }
}

LeavesClass:

package com.handreans.dancinglizards.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.LeavesBlock;
import net.minecraft.item.BlockItemUseContext;
import net.minecraft.state.IntegerProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.tags.BlockTags;
import net.minecraft.util.Direction;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IWorld;
import net.minecraft.world.World;

import java.util.Random;

public class DLLeavesBlock extends LeavesBlock
{
    public static final IntegerProperty DISTANCE = IntegerProperty.create("distance2", 1, 11);

    public DLLeavesBlock(Block.Properties properties)
    {
        super(properties);
        this.setDefaultState(this.getStateContainer().getBaseState().with(DISTANCE, Integer.valueOf(11)).with(PERSISTENT, Boolean.valueOf(false)));
    }

    @Override
    public boolean ticksRandomly(BlockState state)
    {
        return state.get(DISTANCE) == 11 && !state.get(PERSISTENT);
    }

    public void randomTick(BlockState state, World worldIn, BlockPos pos, Random rand)
    {
        if (!state.get(PERSISTENT) && state.get(DISTANCE) == 11)
        {
            spawnDrops(state, worldIn, pos);
            worldIn.removeBlock(pos, false);
        }
    }

    public void tick(BlockState state, World worldIn, BlockPos pos, Random rand)
    {
        worldIn.setBlockState(pos, updateDistance(state, worldIn, pos), 3);
    }

    @Override
    public BlockState updatePostPlacement(BlockState stateIn, Direction facing, BlockState facingState, IWorld worldIn, BlockPos currentPos, BlockPos facingPos)
    {
        int i = getDistance(facingState) + 1;
        if (i != 1 || stateIn.get(DISTANCE) != 1)
        {
            worldIn.getPendingBlockTicks().scheduleTick(currentPos, this, 1);
        }
        return stateIn;
    }

    public static BlockState updateDistance(BlockState p_208493_0_, IWorld p_208493_1_, BlockPos p_208493_2_)
    {
        int i = 11;

        try (BlockPos.PooledMutable blockpos$pooledmutable = BlockPos.PooledMutable.retain())
        {
            for(Direction direction : Direction.values())
            {
                blockpos$pooledmutable.setPos(p_208493_2_).move(direction);
                i = Math.min(i, getDistance(p_208493_1_.getBlockState(blockpos$pooledmutable)) + 1);
                if (i == 1)
                {
                    break;
                }
            }
        }
        return p_208493_0_.with(DISTANCE, Integer.valueOf(i));
    }

    public static int getDistance(BlockState neighbor)
    {
        if (BlockTags.LOGS.contains(neighbor.getBlock()))
        {
            return 0;
        }
        else
        {
            return neighbor.getBlock() instanceof DLLeavesBlock ? neighbor.get(DISTANCE) : 11;
        }
    }

    @Override
    protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder)
    {
        builder.add(DISTANCE);
        super.fillStateContainer(builder);
    }

    @Override
    public BlockState getStateForPlacement(BlockItemUseContext context)
    {
        return updateDistance(this.getDefaultState().with(PERSISTENT, Boolean.valueOf(true)), context.getWorld(), context.getPos());
    }
}

LogClass:

package com.handreans.dancinglizards.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.LogBlock;
import net.minecraft.block.material.MaterialColor;
import net.minecraft.item.BlockItemUseContext;
import net.minecraft.state.EnumProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.util.Direction;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockReader;

public class DLLogBlock extends LogBlock
{
    public final MaterialColor verticalColor;
    public static final EnumProperty<Direction.Axis> AXIS = BlockStateProperties.AXIS;

    public DLLogBlock(MaterialColor verticalColorIn, Properties properties)
    {
        super(verticalColorIn, properties);
        this.verticalColor = verticalColorIn;
        this.setDefaultState(this.getDefaultState().with(AXIS, Direction.Axis.Y));
    }

    public BlockState rotate(BlockState state, Rotation rot) {
        switch(rot) {
            case COUNTERCLOCKWISE_90:
            case CLOCKWISE_90:
                switch((Direction.Axis)state.get(AXIS)) {
                    case X:
                        return state.with(AXIS, Direction.Axis.Z);
                    case Z:
                        return state.with(AXIS, Direction.Axis.X);
                    default:
                        return state;
                }
            default:
                return state;
        }
    }

    public MaterialColor getMaterialColor(BlockState state, IBlockReader worldIn, BlockPos pos) {
        return state.get(AXIS) == Direction.Axis.Y ? this.verticalColor : this.materialColor;
    }

    public void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
        builder.add(AXIS);
    }

    public BlockState getStateForPlacement(BlockItemUseContext context) {
        return this.getDefaultState().with(AXIS, context.getFace().getAxis());
    }
}

SaplingClass:

package com.handreans.dancinglizards.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.BushBlock;
import net.minecraft.block.IGrowable;
import net.minecraft.block.trees.Tree;
import net.minecraft.state.IntegerProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.shapes.ISelectionContext;
import net.minecraft.util.math.shapes.VoxelShape;
import net.minecraft.world.IBlockReader;
import net.minecraft.world.World;
import net.minecraft.world.server.ServerWorld;
import net.minecraftforge.event.ForgeEventFactory;

import java.util.Random;
import java.util.function.Supplier;

public class DLSaplingBlock extends BushBlock implements IGrowable
{
    public static final IntegerProperty STAGE = BlockStateProperties.STAGE_0_1;
    protected static final VoxelShape SHAPE  = Block.makeCuboidShape(2.0D, 0.0D, 2.0D, 14.0D, 12.0D, 14.0D);
    private final Supplier<Tree> tree;

    public DLSaplingBlock(Supplier<Tree> treeIn, Properties properties)
    {
        super(properties);
        this.tree = treeIn;
    }

    public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context)
    {
        return SHAPE;
    }

    @Override
    public void tick(BlockState state, ServerWorld worldIn, BlockPos pos, Random rand) {
        super.tick(state, worldIn, pos, rand);
        if(!worldIn.isAreaLoaded(pos, 1))
        {
            return;
        }
        if(worldIn.getLight(pos.up()) >= 9 && rand.nextInt(7) == 0)
        {
            this.grow(worldIn, pos, state, rand);
        }
    }

    public void grow(ServerWorld serverWorld, BlockPos pos, BlockState state, Random rand)
    {
        if(state.get(STAGE) == 0)
        {
            serverWorld.setBlockState(pos, state.cycle(STAGE), 4);
        }
        else
        {
            if(!ForgeEventFactory.saplingGrowTree(serverWorld, rand, pos)) return;
            this.tree.get().place(serverWorld, serverWorld.getChunkProvider().getChunkGenerator(), pos, state, rand);
        }
    }

    @Override
    public void grow(ServerWorld serverWorld, Random rand, BlockPos pos, BlockState state)
    {
        this.grow(serverWorld, pos, state, rand);
    }

    @Override
    public boolean canGrow(IBlockReader worldIn, BlockPos pos, BlockState state, boolean isClient)
    {
        return true;
    }

    @Override
    public boolean canUseBonemeal(World worldIn, Random rand, BlockPos pos, BlockState state)
    {
        return (double)worldIn.rand.nextFloat() < 0.45D;
    }

    @Override
    protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder)
    {
        builder.add(STAGE);
    }
}

BlockInitClass:

package com.handreans.dancinglizards.init;

import com.handreans.dancinglizards.DancingLizards;
import com.handreans.dancinglizards.blocks.*;
import com.handreans.dancinglizards.world.feature.DLTree;
import net.minecraft.block.*;
import net.minecraft.block.material.Material;
import net.minecraft.block.material.MaterialColor;
import net.minecraftforge.common.ToolType;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

public class BlockInit
{
    public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<Block>(ForgeRegistries.BLOCKS, DancingLizards.MOD_ID);

    public static final RegistryObject<Block> SCALE_BLOCK = BLOCKS.register("scale_block", () -> new ScaleBlock(Block.Properties.create(Material.IRON)
            .hardnessAndResistance(5.0f, 6.0f)
            .sound(SoundType.METAL)
            .harvestLevel(2)
            .harvestTool(ToolType.PICKAXE)));

    public static final RegistryObject<Block> LIZARDIUM_ORE = BLOCKS.register("lizardium_ore", () -> new LizardiumOre(Block.Properties.create(Material.IRON)
            .hardnessAndResistance(5.0f, 6.0f)
            .sound(SoundType.STONE)
            .harvestLevel(2)
            .harvestTool(ToolType.PICKAXE)));

    public static final RegistryObject<Block> LIZARDIUM_BLOCK = BLOCKS.register("lizardium_block", () -> new LizardiumBlock(Block.Properties.create(Material.IRON)
            .hardnessAndResistance(5.0f, 6.0f)
            .sound(SoundType.METAL)
            .harvestLevel(2)
            .harvestTool(ToolType.PICKAXE)));

    public static final RegistryObject<Block> DLCHEST = BLOCKS.register("dlchest", () -> new DLChestBlock(Block.Properties.from(BlockInit.SCALE_BLOCK.get())));

    //Tree and derivatives
    public static final RegistryObject<Block> DL_PLANKS = BLOCKS.register("dl_planks", () -> new Block(Block.Properties.from(Blocks.OAK_PLANKS)));
    public static final RegistryObject<Block> DL_LOG = BLOCKS.register("dl_log", () -> new DLLogBlock(MaterialColor.WOOD, Block.Properties.from(Blocks.OAK_LOG)));
    public static final RegistryObject<Block> DL_LEAVES = BLOCKS.register("dl_leaves", () -> new LeavesBlock(Block.Properties.from(Blocks.OAK_LEAVES)));
    public static final RegistryObject<Block> DL_SAPLING = BLOCKS.register("dl_sapling", () -> new DLSaplingBlock(() -> new DLTree(), Block.Properties.from(Blocks.OAK_SAPLING)));
}

Edited July 26, 20205 yr by Handreans

Quote

July 25, 20205 yr

You likely need to add leaves and logs tags jsons/datagens

Quote

July 26, 20205 yr

Author

And how do I call the Tag Class?

Quote

July 26, 20205 yr

3 hours ago, Handreans said:

And how do I call the Tag Class?

It isn't a class, it's a json file you need to add.

Edited July 26, 20205 yr by Novârch

It's sad how much time mods spend saying "x is no longer supported on this forum. Please update to a modern version of Minecraft to receive support".

Quote

1

July 26, 20205 yr

7 hours ago, Handreans said:

And how do I call the Tag Class?

Look at vanilla resources in data/minecraft/tags/blocks for examples.

Unfortunately I still haven't tinkered with data generators so I cannot tell you how they work, but they will generate the json for you via code so you do not have to write it by hand (which can be prone to typos/repetitiveness/etc)

Quote

July 26, 20205 yr

Author

It worked, i tought that I had to call it in a class or something but it was just my .json that was with a few errors, thank you very much!

Quote

Sign In

[1.15.2] [SOLVED] Custom Tree Help

Featured Replies

Join the conversation

Posts

Having a "crashed whilst rendering overlay" situation.

Orbital strike cannon fishing rod mod

Minecraft Modpack (self-made) keeps crashing when I launch it. Error code: -1

I need help with a custom structure in my mod.

Having a "crashed whilst rendering overlay" situation.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)