I have an error and have no clue how to fix it

[MrGreenyboy]

[m[36m[08:57:09] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid forge : RegistryEvent.NewRegistry
[m[36m[08:57:09] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid forge : RegistryEvent.NewRegistry
[m[36m[08:57:09] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid tutorialmod : RegistryEvent.NewRegistry
[m[36m[08:57:09] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid tutorialmod : RegistryEvent.NewRegistry
[m[36m[08:57:09] [Render thread/DEBUG] [ne.mi.re.ObjectHolderRegistry/REGISTRIES]: Processing ObjectHolder annotations
[m[33m[08:57:09] [Render thread/WARN] [ne.mi.re.ObjectHolderRegistry/REGISTRIES]: Found an unqualified ObjectHolder annotation (tutorialmod) without a modid context at Lcom/MrGreenyboy/TutorialMod/init/ItemInit;.example_item, ignoring
[m[32m[08:57:09] [Render thread/INFO] [STDOUT/]: [net.minecraft.util.registry.Bootstrap:printToSYSOUT:120]: ---- Minecraft Crash Report ----
// This doesn't make any sense!

Time: 27/07/20 08:57
Description: Initializing game

java.lang.IllegalStateException: Unqualified reference to ObjectHolder
    at net.minecraftforge.registries.ObjectHolderRegistry.scanTarget(ObjectHolderRegistry.java:146) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading}
    at net.minecraftforge.registries.ObjectHolderRegistry.lambda$findObjectHolders$8(ObjectHolderRegistry.java:110) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading}
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.AbstractPipeline.copyInto(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.AbstractPipeline.evaluate(Unknown Source) ~[?:1.8.0_251] {}
    at java.util.stream.ReferencePipeline.forEach(Unknown Source) ~[?:1.8.0_251] {}
    at net.minecraftforge.registries.ObjectHolderRegistry.findObjectHolders(ObjectHolderRegistry.java:110) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading}
    at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:203) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading}
    at net.minecraftforge.fml.client.ClientModLoader.lambda$begin$2(ClientModLoader.java:93) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading,pl:runtimedistcleaner:A}
    at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:109) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading,pl:runtimedistcleaner:A}
    at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:93) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading,pl:runtimedistcleaner:A}
    at net.minecraft.client.Minecraft.<init>(Minecraft.java:425) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
    at net.minecraft.client.main.Main.main(Main.java:149) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {re:classloading,pl:runtimedistcleaner:A}
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251] {}
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_251] {}
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_251] {}
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_251] {}
    at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55) ~[forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {}
    at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-5.1.0.jar:?] {}
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-5.1.0.jar:?] {}
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-5.1.0.jar:?] {}
    at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-5.1.0.jar:?] {}
    at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-5.1.0.jar:?] {}
    at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:105) [forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar:?] {}

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
    at net.minecraftforge.registries.ObjectHolderRegistry.scanTarget(ObjectHolderRegistry.java:146)
    at net.minecraftforge.registries.ObjectHolderRegistry.lambda$findObjectHolders$8(ObjectHolderRegistry.java:110)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
    at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
    at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
    at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source)
    at java.util.stream.AbstractPipeline.copyInto(Unknown Source)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
    at java.util.stream.AbstractPipeline.evaluate(Unknown Source)
    at java.util.stream.ReferencePipeline.forEach(Unknown Source)
    at net.minecraftforge.registries.ObjectHolderRegistry.findObjectHolders(ObjectHolderRegistry.java:110)
    at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:203)
    at net.minecraftforge.fml.client.ClientModLoader.lambda$begin$2(ClientModLoader.java:93)
    at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$5(ClientModLoader.java:109)
    at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:93)
    at net.minecraft.client.Minecraft.<init>(Minecraft.java:425)

-- Initialization --
Details:
Stacktrace:
    at net.minecraft.client.main.Main.main(Main.java:149)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55)
    at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37)
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54)
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72)
    at cpw.mods.modlauncher.Launcher.run(Launcher.java:81)
    at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)
    at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:105)

-- System Details --
Details:
    Minecraft Version: 1.16.1
    Minecraft Version ID: 1.16.1
    Operating System: Windows 10 (amd64) version 10.0
    Java Version: 1.8.0_251, Oracle Corporation
    Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
    Memory: 152545304 bytes (145 MB) / 802160640 bytes (765 MB) up to 1417150464 bytes (1351 MB)
    CPUs: 4
    JVM Flags: 1 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump
    ModLauncher: 5.1.0+69+master.79f13f7
    ModLauncher launch target: fmluserdevclient
    ModLauncher naming: mcp
    ModLauncher services:
        /mixin-0.8.jar mixin PLUGINSERVICE
        /eventbus-2.2.0-service.jar eventbus PLUGINSERVICE
        /forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16-launcher.jar object_holder_definalize PLUGINSERVICE
        /forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16-launcher.jar runtime_enum_extender PLUGINSERVICE
        /accesstransformers-2.1.3-shadowed.jar accesstransformer PLUGINSERVICE
        /forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16-launcher.jar capability_inject_definalize PLUGINSERVICE
        /forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16-launcher.jar runtimedistcleaner PLUGINSERVICE
        /mixin-0.8.jar mixin TRANSFORMATIONSERVICE
        /forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16-launcher.jar fml TRANSFORMATIONSERVICE
    FML: 32.0
    Forge: net.minecraftforge:32.0.75
    FML Language Providers:
        javafml@32.0
        minecraft@1
    Mod List:
        client-extra.jar Minecraft {minecraft@1.16.1 LOAD_REGISTRIES}
        forge-1.16.1-32.0.75_mapped_snapshot_20200514-1.16.jar Forge {forge@32.0.75 LOAD_REGISTRIES}
        main Tutorial Mod {tutorialmod@1.0 LOAD_REGISTRIES}
    Launched Version: MOD_DEV
    Backend library: LWJGL version 3.2.2 build 10
    Backend API: Radeon RX 580 Series GL version 4.6.13587 Compatibility Profile Context 20.2.2 26.20.15019.19000, ATI Technologies Inc.
    GL Caps: Using framebuffer using OpenGL 3.0
    Using VBOs: Yes
    Is Modded: Definitely; Client brand changed to 'forge'
    Type: Client (map_client.txt)
    CPU: 4x AMD Ryzen 3 3200G with Radeon Vega Graphics
[m[32m[08:57:09] [Render thread/INFO] [STDOUT/]: [net.minecraft.util.registry.Bootstrap:printToSYSOUT:120]: #@!@# Game crashed! Crash report saved to: #@!@# C:\Users\dangr\Documents\Youtube\mods\TutorialMod1.16.1(2)\run\.\crash-reports\crash-2020-07-27_08.57.09-client.txt
[m

[sciwhiz12]

  On 7/27/2020 at 8:06 AM, MrGreenyboy said:

[08:57:09] [Render thread/WARN] [ne.mi.re.ObjectHolderRegistry/REGISTRIES]: Found an unqualified ObjectHolder annotation (tutorialmod) without a modid context at Lcom/MrGreenyboy/TutorialMod/init/ItemInit;.example_item, ignoring

Expand  

You put a `@ObjectHolder` annotation on `ItemInit.example_item` without specifying a modid in either the annotation on the field or on the class (through @Mod or @ObjectHolder). See the documentation on @ObjectHolder for its rules and examples. (ignore the 1.14.x version, it is the same up to 1.16.+)

[MrGreenyboy]

This is my code where would i add the modid

 

package com.MrGreenyboy.TutorialMod.init;

import com.MrGreenyboy.TutorialMod.TutorialMod;

import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.registries.ObjectHolder;

@Mod.EventBusSubscriber(modid = "tutorialmod", bus = Bus.MOD)
public class ItemInit
{
    
    @ObjectHolder("tutorialmod" + "example_item")
    public static Item example_item;
    
    @SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName("example_item"));
    }
}

[Novârch]

  On 7/28/2020 at 5:29 PM, MrGreenyboy said:

@ObjectHolder("tutorialmod" + "example_item")

Expand  

Remove your item name, all you need is the modid, you can also annotate the class with it if you're going to use to for lots of items.

[MrGreenyboy]

I still had minecraft crash with the same error so here is my main code

 

package com.MrGreenyboy.TutorialMod;

import net.minecraft.block.Block;
import net.minecraft.block.Blocks;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.InterModComms;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.event.lifecycle.InterModEnqueueEvent;
import net.minecraftforge.fml.event.lifecycle.InterModProcessEvent;
import net.minecraftforge.fml.event.server.FMLServerStartingEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.stream.Collectors;

// The value here should match an entry in the META-INF/mods.toml file
@Mod("tutorialmod")
public class TutorialMod
{
    // Directly reference a log4j logger.
    private static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "tutorialmod";
    public static TutorialMod instance;

    public TutorialMod() {
        // Register the setup method for mod loading
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        // Register the doClientStuff method for mod loading
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);

        // Register ourselves for server and other game events we are interested in
        MinecraftForge.EVENT_BUS.register(this);
        instance = this;
    }

    private void setup(final FMLCommonSetupEvent event)
    {
        
    }

    private void doClientStuff(final FMLClientSetupEvent event) {
        
    }

    // You can use SubscribeEvent and let the Event Bus discover methods to call
    @SubscribeEvent
    public void onServerStarting(FMLServerStartingEvent event) {
        
    }

}

 

[MrGreenyboy]

  On 7/28/2020 at 5:57 PM, MrGreenyboy said:

I still had minecraft crash with the same error so here is my main code

 

package com.MrGreenyboy.TutorialMod;

import net.minecraft.block.Block;
import net.minecraft.block.Blocks;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.InterModComms;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.event.lifecycle.InterModEnqueueEvent;
import net.minecraftforge.fml.event.lifecycle.InterModProcessEvent;
import net.minecraftforge.fml.event.server.FMLServerStartingEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.stream.Collectors;

// The value here should match an entry in the META-INF/mods.toml file
@Mod("tutorialmod")
public class TutorialMod
{
    // Directly reference a log4j logger.
    private static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "tutorialmod";
    public static TutorialMod instance;

    public TutorialMod() {
        // Register the setup method for mod loading
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        // Register the doClientStuff method for mod loading
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);

        // Register ourselves for server and other game events we are interested in
        MinecraftForge.EVENT_BUS.register(this);
        instance = this;
    }

    private void setup(final FMLCommonSetupEvent event)
    {
        
    }

    private void doClientStuff(final FMLClientSetupEvent event) {
        
    }

    // You can use SubscribeEvent and let the Event Bus discover methods to call
    @SubscribeEvent
    public void onServerStarting(FMLServerStartingEvent event) {
        
    }

}

 

Expand  

Oh and i did remove "example_mod" from the other code

[Novârch]

  On 7/28/2020 at 5:58 PM, MrGreenyboy said:

Oh and i did remove "example_mod" from the other code

Expand  

You mean example_item, right? Please post your full debug.log. Before you ask where it is like everyone else, remember that your OS 's file manager has a search function.

[sciwhiz12]

  On 7/28/2020 at 5:29 PM, MrGreenyboy said:

    @ObjectHolder("tutorialmod" + "example_item")
    public static Item example_item;

Expand  

In the future, please use the code blocks (the `<>` in the editor) when pasting code.

 

You are missing the colon between the modid and item name: "tutorialmod:example_item".

 

  On 7/28/2020 at 5:45 PM, Novârch said:

Remove your item name, all you need is the modid

Expand  

That isn't true for annotations on fields; you explicitly need to specify the registry path and, as there is no @ObjectHolder annotation on the class, also the modid/namespace has to be specified. It's all written in the documentation. (see the last example in UnannotatedHolder)

Edited July 28, 2020 by sciwhiz12
clarifying some words

[MrGreenyboy]

  On 7/28/2020 at 6:02 PM, Novârch said:

You mean example_item, right? Please post your full debug.log. Before you ask where it is like everyone else, remember that your OS 's file manager has a search function.

Expand  

Yes i do mean example_item

[MrGreenyboy]

  On 7/28/2020 at 6:03 PM, sciwhiz12 said:

In the future, please use the code blocks (the `<>` in the editor) when pasting code.

 

You are missing the colon between the modid and item name: "tutorialmod:example_item".

 

That isn't true for annotations on fields; you explicitly need to specify the registry name and, as there is no @ObjectHolder annotation on the class, also the modid has to be specified. It's all written in the documentation. (see the last example in UnannotatedHolder)

Expand  

so I have to put the mod id at the top of the class and then the item id above where i make it?

[MrGreenyboy]

Guys thank you I fixed it by adding the mod id above the class and then the item id above where i made it.

[sciwhiz12]

Just adding onto that, if you put your modid into an @ObjectHolder above your class, then any `public static final` fields will be auto-injected with the object according to their fields' name. Again, I refer you to the documentation on this, as it has examples.

[MrGreenyboy]

  On 7/28/2020 at 6:07 PM, MrGreenyboy said:

Guys thank you I fixed it by adding the mod id above the class and then the item id above where i made it.

Expand  

Saying that I played the game it didn't crash but now the item has no graphic

[sciwhiz12]

What does your model JSON for example_item contain? Post it.

[MrGreenyboy]

  On 7/28/2020 at 6:14 PM, sciwhiz12 said:

What does your model JSON for example_item contain? Post it.

Expand  

Ok here is the code:

{
    "parent": "item/generated",
    "textures": {
        "layer0": "tutorialmod:item/example_item"
    }
}

[sciwhiz12]

  On 7/28/2020 at 6:16 PM, MrGreenyboy said:

tutorialmod:item/example_item

Expand  

That is referring to the texture under `assets/tutorialmod/textures/item/example_item.png`. Your assets/textures folder has an `s` in `items`, rename it to be just `item`.

[MrGreenyboy]

  On 7/28/2020 at 6:18 PM, sciwhiz12 said:

That is referring to the texture under `assets/tutorialmod/textures/item/example_item.png`. Your assets/textures folder has an `s` in `items`, rename it to be just `item`.

Expand  

I can Now make items thank you so much again.