[1.16.1] Overriding vanilla recipes

[NathaFred]

Basically, I want to change a vanilla recipe to use slightly different ingredients. Many other solutions to this problem use this event:

@SubscribeEvent
public static void RegistryRecipe(RegistryEvent.Register<IRecipe> event){
    //remove recipe entry
}

 

However, this gives an error: " Type parameter 'net.minecraft.item.crafting.IRecipe' is not within its bound; should extend 'net.minecraftforge.registries.IForgeRegistryEntry<net.minecraft.item.crafting.IRecipe>' " So I believe this has changed in version 1.16. Additionally the Forge Documentation (1.15.x) states this should work. I am wondering if there is any way to do this now, or if it has changed to some other way, or maybe I am doing something wrong? Thanks!

 

[NathaFred]

I believe you mean just placing a .json file into the recipes folder. If I try to override the recipe by placing an edited .json of the same name into resources/data/minecraft/recipes nothing changes. If I put it into resources/data/mod-id/recipes it adds the recipe so both the vanilla and modded way works. I know my /minecraft folder works because I have successfully overridden a loot table there. I do have a number of non-datapack features in my mod if that makes any difference. 

Edited August 9, 2020 by NathaFred
typos

[NathaFred]

Okay so I figured it out. Maybe this is the normal way of doing it, but I don't know. The name of the recipe .json file doesn't matter since the output item is stated inside the .json. This way you create two files, one to override the old recipe and another with the updated recipe. The override recipe is identical to the vanilla one but with an output of air. Also both recipies must be in the resources/data/mod-id/recipes folder not the /minecraft folder. 

 

Please correct me if this isn't the best way to do this, but it works.

[Draco18s]

19 minutes ago, NathaFred said:

The name of the recipe .json file doesn't matter

One of them should name-match (I recommend the one that has the desired output, name the other one something like "{original}_override" or "{original}_dummy"). If for nothing else than so people know what it's for.

[NathaFred]

Yes that's true.On a very related subject, the problem now is that both recipes show up in the recipe book. The dummy one shows up for the normal advancement, and the override shows up once the dummy one is viewed. Is there any way to remove the dummy from the book? I think I can set up a custom advancement for the override.

[Draco18s]

1 hour ago, NathaFred said:

Is there any way to remove the dummy from the book? I think I can set up a custom advancement for the override.

That's exactly what you need to do.

Just remember to give a blank dummy for the original advancement.

[NathaFred]

Ah, so I can override the advancement by giving it a dummy, and implement a new advancement for the override.

[Draco18s]

Yes.

[NathaFred]

Hmm... Well this is harder than I thought it would be. I can't find anything online or in the vanilla code... A lot of people have said the advancement should be added in the data pack as a .json, and the minecraft wiki agrees with that. However, I cannot find a good example of an advancement json. I found an advancement .json generator online, but it dosen't work so either it's outdated, or I did something wrong. Here is my .json file that the website generated.

 

{
  "display": {
    "description": "",
    "title": "",
    "show_toast": false,
    "announce_to_chat": false,
    "background": "minecraft:textures/blocks/stone.png"
  },
  "criteria": {
    "inv_changed-diamond": {
      "trigger": "minecraft:inventory_changed",
      "conditions": {
        "items": [
          {
            "item": "minecraft:diamond",
            "data": 0
          }
        ]
      }
    }
  },
  "rewards": {
    "recipes": [
      "grindstone_override"
    ]
  },
  "requirements": [
    [
      "inv_changed-diamond"
    ]
  ]
}

 

I placed this file in resources/data/mod-id/advancements  and  resources/data/minecraft/advancements. Neither did anything. I am assuming that the recipe string should hold the name of the recipe file, but I don't know if that is true. Also the   "data": 0   line is kinda sus...

 

 

Edited August 10, 2020 by NathaFred

[NathaFred]

Isn't it weird how when you explain things suddenly you realize whats wrong!? Well, I figured it out. I am not sure what specifically was wrong in that .json, but I changed a bunch of things and put it in the resources/data/minecraft/advancements folder, and it works! Here is the new .json. You have to use your mod-id namespace for the reward recipe, and it seems the  "data": 0 line was wrong.

 

So if you need an example of how to add a new recipe advancement, here one is!

 

 

{
  "criteria": {
    "inv_changed-diamond": {
      "trigger": "minecraft:inventory_changed",
      "conditions": {
        "items": [
          {
            "item": "minecraft:diamond"
          }
        ]
      }
    }
  },
  "rewards": {
    "recipes": [
      "nmgrepair:grindstone_override"
    ]
  }
}

 

Now I just have to figure out how to override/ remove the other one...

 

Edited August 10, 2020 by NathaFred

[Draco18s]

2 minutes ago, NathaFred said:

Now I just have to figure out how to override/ remove the other one...

Should just be creating a dummy one that's essentially impossible to obtain.
I swear I have it around somewhere...

 

Ah ha there it is. Couldn't find it last night.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/minecraft/advancements/recipes/misc/bone_meal.json

Edited August 10, 2020 by Draco18s

[NathaFred]

Hmm... So when the player gets a stone slab, the advancement that I need to override gives you the grindstone recipe... I am not sure how your example works as it just creates a new impossible advancement. It doesn't seem like it is tied to bone meal at all unless the name matters. I have tried putting that file, with the name "grindstone.json" under

data/minecraft/advancements/

data/minecraft/advancements/recipes

data/minecraft/advancements/minecraft/recipes

data/advancements/recipes

data/advancements/minecraft/recipes

 

none have nulled the original advancement. Is there something I am not realizing here? Also, I have so many worlds now because every time I test it I have to create a new one to test the advancement XD

[Draco18s]

1 hour ago, NathaFred said:

just creates a new impossible advancement.

No, it makes the advancement that unlocks the bone -> bonemeal recipe impossible to get. Its not a new advancement at all, notice where it lives.

If you create a similar advancement for the grindstone, then picking up a slab won't give you the grindstone recipe. Or you can alter the condition, unlock reward, etc.

[NathaFred]

Your file does indeed work when it is named bone_meal.json, however if I try to use it for the grindstone it doesn't work.

I tried a bunch of names and directories. None of these configurations work. How should I name this file, and where should I put it? 

 

 

[Draco18s]

What's the vanilla file named?

[NathaFred]

That's the thing, I can't find any vanilla .json advancements... I'm sure they're there somewhere but I have looked through everything and can't find them!

[NathaFred]

Why do I keep doing this! I just found them 🤦‍♂️ okay it's under the decorations folder not decoration... and it is called grindstone.

 

Edit

It works...

 

For anyone wondering where the advancements and a bunch of other stuff is:

net.minecraft:client:extra:version-number

(at least for now)

Edited August 10, 2020 by NathaFred

[nayna]

Thank you for this thread! I was looking for the same info.

 

One thing I can add from my experience is that one item can have multiple recipes (I wanted to override a Wooden Pickaxe, which I found has a minecraft vanilla recipe AND a forge recipe (?)), so you will have to override all the recipes to fully get rid of the vanilla behavior.

[Draco18s]

The forge version overrides the vanilla version already.

[nayna]

Hm, I tried to override the forge version only but I could still create a Wooden Pickaxe.
Maybe I didn't place the recipe correctly?
I placed both recipes in resources/data/minecraft/recipes

[Draco18s]

Whatever recipe you're using to replace the vanilla recipe needs to be named the same and placed in the same location (so, you have the location correct, I assume you've named it correctly).

I am aware of, but thought it got fixed, that any recipe forge overrides from vanilla could not, itself, be overridden. 

[NathaFred]

2 hours ago, nayna said:

one item can have multiple recipes

This is exactly the problem I was trying to solve in this thread. A recipe is only actually overridden if the shape and ingredients are the same. In other words, if you create an identical recipe to the wooden pickaxe but set the output to air, you will find that it is impossible to craft a wooden pickaxe. So the steps to take if you want to change or replace a recipe are:

1. create a recipe with the desired ingredients and output

2. create a recipe identical to the vanilla recipe, but outputting air

3. create an identical advancement to the vanilla and have it reward your custom recipe (and change criteria as needed)

4. create an impossible advancement to override the vanilla one, since the vanilla advacement will give the player a recipe that no longer works.

 

In step four the .json file must be named the same as the vanilla advancement and be placed in the same location in the data folder. Like I said before you can find all the vanilla advancements if you go to your external libraries and look under net.minecraft:client:extra:1.16.1. 

 

These are the steps that I went through in this thread and should get you the same result.

Edited August 11, 2020 by NathaFred

[nayna]

16 minutes ago, NathaFred said:

These are the steps that I went through in this thread and should get you the same result.

I followed the steps you mentioned but I could still create the Wooden Pickaxe. The advancement worked first try.
I then found out there are 2 recipes:
vanilla:

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    "XXX",
    " # ",
    " # "
  ],
  "key": {
    "#": {
      "item": "minecraft:stick"
    },
    "X": {
      "tag": "minecraft:planks"
    }
  },
  "result": {
    "item": "minecraft:wooden_pickaxe",
  }
}

forge:

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    "XXX",
    " # ",
    " # "
  ],
  "key": {
    "#": {
      "tag": "forge:rods/wooden"
    },
    "X": {
      "tag": "minecraft:planks"
    }
  },
  "result": {
    "item": "minecraft:wooden_pickaxe",
  }
}

So I did an override for both of these recipes and then I could not create the Wooden Pickaxe.

 

I noticed this because I made the custom recipe for the Wooden Pickaxe, which had a different pattern (and it worked), and decided to result air on that one, and I could not create the Wooden Pickaxe with the new pattern! Therefore I searched through the forge and vanilla recipes and found the 2 recipes.

I assume that when the vanilla recipe is overrode alone, the forge recipe will work, and when the forge recipe is overrode alone, the vanilla one will work.

2 hours ago, Draco18s said:

I am aware of, but thought it got fixed, that any recipe forge overrides from vanilla could not, itself, be overridden. 

But the vanilla could be? Then would forge automatically know to make the pattern unavailable when the vanilla one is overrode?

 

[NathaFred]

Wait, so did it work or not?

[Draco18s]

38 minutes ago, nayna said:

But the vanilla could be? Then would forge automatically know to make the pattern unavailable when the vanilla one is overrode?

Forge overrides vanilla. Any override you create therefor must override Forge.

Note this is not a "I would like to override Forge" conscious decision. It is forced upon you by the very nature of the system's design.

Edited August 11, 2020 by Draco18s