1.16 Enumerate Deferred Registries to create Block Items

[urbanxx001]

Many tutorials use this nifty event to create block items for a given Deferred Registry:

1   @SubscribeEvent
2   public static void createBlockItems(final RegistryEvent.Register<Item> event) {
3
4     final IForgeRegistry<Item> registry = event.getRegistry();
5
6     ModBlocks.BLOCK_REGISTRY.getEntries().stream().map(RegistryObject::get).forEach(block -> {
7
8         IForgeRegistry blockRegistry = GameRegistry.findRegistry(Block.class).getRegistrySuperType();
9
10        final Item.Properties properties = new Item.Properties().group(ItemGroup.GROUP);
11        final BlockItem blockItem = new BlockItem(block, properties);
12        blockItem.setRegistryName(Objects.requireNonNull(block.getRegistryName()));
13        registry.register(blockItem);
14    });
15  }

However this only works when registering all the blocks to a single creative tab. I have an idea for multiple tabs. Naming the registries in class ModBlocks after ItemGroups, surround the inside code in a for-loop to enumerate over them in line 6 (for instance, ModBlocks.DECORATIONS, ModBlocks.BUILDING_BLOCKS, etc.). Then convert the name of each registry into an actual ItemGroup to be passed in line 10. I read that GameRegistry.findRegistry(Block.class) may work for getting a registry name from a global registry, but I'm not sure. Is this idea feasible?

Edited August 10, 2020 by urbanxx001

[Draco18s]

Don't use a giant massive list?

[urbanxx001]

You mean just settle for one tab? (I know one could duplicate the code and manually change the fields that way, but a dynamic solution seems better)

Edited August 10, 2020 by urbanxx001

[Draco18s]

No. I mean "don't use a list."

public static void createBlockItems(final RegistryEvent.Register<Item> event) {
    final IForgeRegistry<Item> registry = event.getRegistry();
	
    registry.register(new BlockItem(ModBlock.BlockA, new Item.Properties().group(ItemGroup.GROUP)).setRegistryName(ModBlock.BlockA.getRegistryName()));
    registry.register(new BlockItem(ModBlock.BlockB, new Item.Properties().group(ItemGroup.BLOCKS)).setRegistryName(ModBlock.BlockB.getRegistryName()));
    registry.register(new BlockItem(ModBlock.BlockC, new Item.Properties().group(ItemGroup.REDSTONE)).setRegistryName(ModBlock.BlockC.getRegistryName()));
    registry.register(new BlockItem(ModBlock.BlockD, new Item.Properties().group(ItemGroup.DECORATION)).setRegistryName(ModBlock.BlockD.getRegistryName()));
}

 

Also this line:

IForgeRegistry blockRegistry = GameRegistry.findRegistry(Block.class).getRegistrySuperType();

Is useless, you never actually do anything with the blockRegistry.

Objects.requireNonNull(block.getRegistryName())

RequireNonNull here is also useless. If it was null, the game would have already crashed.

12        blockItem.setRegistryName(Objects.requireNonNull(block.getRegistryName()));
13        registry.register(blockItem);

setRegistryName returns the object, removing the need for a local variable.

Edited August 10, 2020 by Draco18s

[urbanxx001]

Oops yeah line 8 was from me toying to see how .findRegistry works. Wouldn't any enumeration method create a long list though? Is it a performance issue?

 

I suppose it could be simplified to:

 

@SubscribeEvent
public static void createBlockItems(final RegistryEvent.Register<Item> event) {

    final IForgeRegistry<Item> registry = event.getRegistry();

    ModBlocks.BLOCK_REGISTRY.getEntries().stream().map(RegistryObject::get).forEach(block -> {

        final RegistryObject<Item> BLOCK_NAME = ModItems.ITEMS.register(block, () -> new BlockItem(block, new Item.Properties().group(ItemGroup.GROUP)));
    });
}

Where the Item Register is already defined in ModItems. But there would need to be some way to make BLOCK_NAME a dynamic variable, which I don't see happening (or maybe with a hashmap?)

Edited August 10, 2020 by urbanxx001

[Draco18s]

11 hours ago, urbanxx001 said:

But there would need to be some way to make BLOCK_NAME a dynamic variable, which I don't see happening (or maybe with a hashmap?)

What? Why?

11 hours ago, urbanxx001 said:

I suppose it could be simplified to:

Yes, but that still doesn't let you have different blocks in different tabs.

11 hours ago, urbanxx001 said:

Is it a performance issue?

No.

[urbanxx001]

I'm aware it doesn't allow blocks in different tabs still, it requires to:

• Call the names of registries to pass into it (why I was playing with .findRegistry())
• Convert that name to an ItemGroup name
• Convert block to Block_Name

Block_Name is a variable now since it's not the actual name of a block (Instead it would be Block_A, Block_B, etc.). Unless there's a simpler way.

Edited August 10, 2020 by urbanxx001

[Draco18s]

45 minutes ago, urbanxx001 said:

I was hoping you knew how to call the names of registries to pass into it

Don't. There is no reason to.

The only registry that matters in the Registry.Register<Item> event is the items registry, which is given to you by the event.

46 minutes ago, urbanxx001 said:

Unless there's a simpler way.

A simpler way to do what? You don't do anything with that variable.

[urbanxx001]

What  I'm referring to is passing the block registry into the ModBlocks line (Where the registries are already defined in that class), which will be converted to an item_group name. The item registry ITEMS is already defined in ModItems, i.e.:

 

@SubscribeEvent
public static void createBlockItems(final RegistryEvent.Register<Item> event) {

    final IForgeRegistry<Item> registry = event.getRegistry();

    registry_size = size of Block registries

    for i = 1 : registry_size
         
        BLOCK_REGISTRY_I = Registry(i) (where registry name is Building Blocks, Decorations, etc);
        ModBlocks.BLOCK_REGISTRY_I.getEntries().stream().map(RegistryObject::get).forEach(block -> {

            GROUP = (convert Block Regsitry to ItemGroup name)
            BLOCK_NAME = (convert block to BLOCK_NAME)
            final RegistryObject<Item> BLOCK_NAME = ModItems.ITEMS.register(block, () -> new BlockItem(block, new Item.Properties().group(ItemGroup.GROUP)));
        });
}

Sorry I'm using Matlab notation for some of this

Edited August 10, 2020 by urbanxx001

[Draco18s]

7 minutes ago, urbanxx001 said:

BLOCK_REGISTRY_I = Registry(i);

ModBlocks.BLOCK_REGISTRY_I...

This makes no sense.

Edited August 10, 2020 by Draco18s

[urbanxx001]

Sorry I'm using Matlab notation. I just mean some way in Java to get the ith registry from the list of all block registries.The registries in class ModBlocks are:

public static final DeferredRegister<Block> DECORATIONS = DeferredRegister.create(ForgeRegistries.BLOCKS, Reference.MOD_ID);
public static final RegistryObject<Block> BLOCK_A = DECORATIONS.register("block_a", () -> new Block(Block.Properties.create(WOOD)));

public static final DeferredRegister<Block> BUILDING_BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, Reference.MOD_ID); 
public static final RegistryObject<Block> BLOCK_B = BUILDING_BLOCKS.register("block_b", () -> new Block(Block.Properties.create(WOOD))); 

 

 

Edited August 10, 2020 by urbanxx001

[urbanxx001]

Yeah. This would work:

public static class RegistryArray {
    public static void main(DeferredRegister args) {
        ArrayList<DeferredRegister> block_registries = new ArrayList<DeferredRegister>();
        block_registries.add(DECORATIONS);
        block_registries.add(BUILDING_BLOCKS);
    }
}

That's resolved, just need to convert the ith entry:

ModBlocks.RegistryArray.get(i)

to an ItemGroup name 

Edited August 10, 2020 by urbanxx001

[urbanxx001]

Understood. I'll create another array that stores the actual ItemGroups. Think I got this now. Thanks for you and Dracos advice.

Edited August 10, 2020 by urbanxx001

[urbanxx001]

Well it's almost done. Even though the code window doesn't throw any errors, the block items don't register in-game. I'll leave it here in case any future modders can resolve it.

 

BlockItem Class

package com.author.extra;

import com.author.extra.core.ModBlocks;
import com.author.extra.proxy.ClientProxy;
import com.author.extra.proxy.CommonProxy;
import net.minecraft.block.AbstractBlock;
import net.minecraft.block.Block;
import net.minecraft.item.BlockItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.DistExecutor;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.IForgeRegistry;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.*;

@Mod(Reference.MOD_ID)
@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
public class Main
{
    public static Main instance;
    public static final Logger LOGGER = LogManager.getLogger(Reference.MOD_ID);
    public static final CommonProxy PROXY = DistExecutor.runForDist(() -> ClientProxy::new, () -> CommonProxy::new);

    public Main()
    {
        instance = this;

        final IEventBus eventBus = FMLJavaModLoadingContext.get().getModEventBus();
        eventBus.addListener(this::onCommonSetup);
        eventBus.addListener(this::onClientSetup);

        final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
        ModBlocks.DECORATIONS_REG.register(modEventBus);
        ModBlocks.BUILDING_BLOCKS_REG.register(modEventBus);
    }

    private ModBlocks registry_list;
    private ModBlocks group_list;

    @SubscribeEvent
    public void createBlockItems(final RegistryEvent.Register<Item> event) {

        final IForgeRegistry<Item> registry = event.getRegistry();

        registry_list = new ModBlocks();
        List<DeferredRegister<Block>> registries = registry_list.getRegList();

        group_list = new ModBlocks();
        List<ItemGroup> groups = group_list.getGroupList();

        int i = 0;

        while (i < registries.size()) {

            DeferredRegister<Block> registry_i = registries.get(i);
            ItemGroup group_i = groups.get(i);

            registry_i.getEntries().stream().map(RegistryObject::get).forEach(block -> {

                final Item.Properties properties = new Item.Properties().group(group_i);
                final BlockItem blockItem = new BlockItem(block, properties);
                blockItem.setRegistryName(Objects.requireNonNull(block.getRegistryName()));
                registry.register(blockItem);
            });

            i++;
        }
    }
}

 

ModBlocks Class

package com.author.extra.core;

import com.author.extra.Reference;
import com.author.extra.block.ChairBlock;
import com.author.extra.block.TableBlock;
import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.material.MaterialColor;
import net.minecraft.block.material.PushReaction;
import net.minecraft.item.ItemGroup;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

import java.util.ArrayList;
import java.util.List;

public class ModBlocks
{
    //public static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, Reference.MOD_ID);

    public static final DeferredRegister<Block> DECORATIONS_REG = DeferredRegister.create(ForgeRegistries.BLOCKS, Reference.MOD_ID);

    public static final RegistryObject<Block> BLOCK_A = DECORATIONS_REG.register("block_a", () -> new Block(Block.Properties.create(Material.ROCK));
    public static final RegistryObject<Block> BLOCK_B = DECORATIONS_REG.register("block_b", () -> new Block(Block.Properties.create(Material.ROCK)));

    public static final DeferredRegister<Block> BUILDING_BLOCKS_REG = DeferredRegister.create(ForgeRegistries.BLOCKS, Reference.MOD_ID);

    public static final RegistryObject<Block> BLOCK_C = BUILDING_BLOCKS_REG.register("block_c", () -> new Block(Block.Properties.create(Material.ROCK)));
    public static final RegistryObject<Block> BLOCK_D = BUILDING_BLOCKS_REG.register("block_d", () -> new Block(Block.Properties.create(Material.ROCK)));
    
    private final List<DeferredRegister<Block>> registries;
    private final List<ItemGroup> groups;

    public ModBlocks() {

        registries = new ArrayList<DeferredRegister<Block>>();
        registries.add(ModBlocks.DECORATIONS_REG);
        registries.add(ModBlocks.BUILDING_BLOCKS_REG);

        groups = new ArrayList<ItemGroup>();
        groups.add(ItemGroup.DECORATIONS);
        groups.add(ItemGroup.BUILDING_BLOCKS);
    }

    public List<DeferredRegister<Block>> getRegList () {
        return registries;
    }

    public List<ItemGroup> getGroupList () {
        return groups;
    }
}

Edited August 11, 2020 by urbanxx001

[Draco18s]

This and this and this

:

1 hour ago, urbanxx001 said:

@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)

1 hour ago, urbanxx001 said:

eventBus.addListener(this::onCommonSetup);

1 hour ago, urbanxx001 said:

ModBlocks.DECORATIONS_REG.register(modEventBus);

All do the same thing. Pick one. (Ok, the last one registers another class, but all three are "I would like to register something with the event bus please")

 

1 hour ago, urbanxx001 said:

@SubscribeEvent public void createBlockItems(final RegistryEvent.Register<Item> event) {

[Choonster]

Instead of using multiple DeferredReigsters and iterating through your Blocks to register your BlockItems, it's probably simpler to just register the BlockItem at the same time as the Block (with DeferredRegister, so the actual registration still happens at the right time). This can be done helper methods like these; you could create a single method that takes the ItemGroup as a parameter, or separate methods for each ItemGroup.

Edited August 11, 2020 by Choonster

[urbanxx001]

Choonster thank you! That's so much simpler, I had no idea about helper functions. Draco thank you as well, I didn't realize the events were clashing like that. I'll credit you all in the toml file.