issue with detecting blocks

[dontrell94]

I'm going to say this:

 

Any person who can help me program this correctly will have their name on the credits of this mod for coding.

[ObsequiousNewt]

I'm going to say this:

 

Any person who can help me program this correctly will have their name on the credits of this mod for coding.

You bumped this after, what, not even four minutes?

 

Anyway, what's wrong with Mew's code?

[dontrell94]

It works to a point..... just that it makes the blocks like they are invisible non solids, but when you walk into them its like the player has a continuous, sand fall in place disorder.....

[Draco18s]

im trying to code it for a 3X3X4 square this block being on the top row.

 

essentially 3 blocks below this plus the row its on

 

You have < 2 right now.  Which means it will do 0 and 1, but not 2.

 

Also, it's not centered on your pit trap.

 

for(i=-1;i<=1;i++) {
  for(j=-1;j<=1;j++) {
    for(k=0;k<=3;k++ {

[dontrell94]

where does that go?

[Draco18s]

where does that go?

 

...in place of your current loop..?

[dontrell94]

how do you handle the x, y, and z variables?

[Draco18s]

how do you handle the x, y, and z variables?

 

seriously?

 

x+i

y-j

z+k

[dontrell94]

public class PitfallHandler

{ 

    public World world; // the world you are using

    public int i, j, k; // X, Y, and Z axis variables

    public int x, y, z;

 

i had to add the last line for it to not error

[Mew]

This is when I facepalm myself to death...

 

Can you tell we and/or show screenshots of the "null" blocks (blocks that are invisible and glitch the game. My name for 'em )?a

[dontrell94]

Upon further investigation, my code only errors when I take out the

 

this.world = world;

 

line......

 

Anybody have ideas?

 

 

package huntingTraps.Resources;

 

import net.minecraft.world.World;

 

public class PitfallHandler

{ 

    public World world; // the world you are using

    public int i, j, k; // X, Y, and Z axis variables

    private int x, y, z;

   

    public PitfallHandler(World world, int x, int y, int z)

    {

        this.world = world; // the world

        this.x = i; // X axis

        this.y = j; // Y axis

        this.z = k; // Z axis

    }

 

    public void generatePitfall()

    {

        // this nested for loop will make a 'block' of air to the dimensions specified in numOfBlocksOn***

        for(i=-1;i<=1;i++)

        {

            for(j=-1;j<=1;j++)

            {

              for(k=0;k<=3;k++)

                      {

                        //if(world.getBlockId(i+x, j-y, k+z) == Block.stone.blockID)

                      // {

                            world.setBlock(

                                i + x, // this makes blocks of air go out however many numOfBlocksOnXAxis was

                                j - y, // this makes blocks of air go out however many numOfBlocksOnYAxis was

                                k + z, // this makes blocks of air go out however many numOfBlocksOnZAxis was

                                00 // the block of air

                                );

                      //  }

                }

            }

        }

    }

}

 

[Mew]

change your constructor from this:

public PitfallHandler(World world, int x, int y, int z)
    {
        this.world = world; // the world
        this.x = i; // X axis
        this.y = j; // Y axis
        this.z = k; // Z axis
    }

 

to this:

public PitfallHandler(World world, int x, int y, int z)
    {
        this.world = world; // the world
        this.x = x; // X axis
        this.y = y; // Y axis
        this.z = z; // Z axis
    }

 

because at the moment you are still using null variables. but only with the location variables. the world variable is correct though

[dontrell94]

I wouldn't mind if it even showed any indication of what it's even doing tho....... it does absolutely nothing now...no block change, no error, nothing....

[FlameAtronach93]

I wouldn't mind if it even showed any indication of what it's even doing tho....... it does absolutely nothing now...no block change, no error, nothing....

 

... what are you developing your code with? Eclipse alike many other IDEs come with a debugger. You should use that. It helps a lot finding out why your code doesn't work at all anymore.

[Draco18s]

I give up.  You need basic java help, which I cannot provide.

[dontrell94]

I don't even know if its the loop

[Draco18s]

I don't even know if its the loop

 

My point is:

 

You need to learn the basics before you can mod minecraft.

 

By not understanding that you needed to replace one set of loops with another set of loops and how to convert the pseudocode I posted into actual code, you have demonstrated that you have no idea what your doing.

[Mew]

I don't even know if its the loop

 

My point is:

 

You need to learn the basics before you can mod minecraft.

 

By not understanding that you needed to replace one set of loops with another set of loops and how to convert the pseudocode I posted into actual code, you have demonstrated that you have no idea what your doing.

 

^^^ Agreed...

[dontrell94]

naw, my brain has been dead for a day or so now cuz of this problem......I can't even talk straight to my friends at this point. leave me alone about the "basics"

[Mew]

naw, my brain has been dead for a day or so now cuz of this problem......I can't even talk straight to my friends at this point. leave me alone about the "basics"

 

Okay. (Sorry about that, had a run in with a teacher at school ) Do you have your source code anywhere? That way we can help a lot more. Can I see your Block code (where you activate the trap), and your current Pitfall generator?

[dontrell94]

draco and mew,pm me your emails and i can send you a bitbucket read only invite

[dontrell94]

Would writing a method similar to what the filler from buildcraft does?