[1.16.3] Lighting/Shadow issues with blocks taller than 1m

[Fubar]

I have some lighting issues since 1.15
I'm using a block that is 1m wide and 2m high. The problem I have are shadows on the upper part of the model that seem to be affected by the bottom part.
Any idea how I can get rid of them? I'm registering the block render layer on FMLClientSetupEvent as RenderType.Cutout since the upper part will not be a full block.

I'm not setting the block's lighting property, only the material (earth) and hardness/resistance.

 

Example (White texture for testing purposes):

 

Edited October 4, 2020 by Fubar

[ChampionAsh5357]

A block should never be more than a 16x16x16 area or else these any many other issues start to occur. You must split the block in two and make it a multipart of sorts. Also, assuming you understand the render types, make sure you are not unnecessarily using one which is not relevant to what you are doing.

[Fubar]

I thought about splitting it in two blocks, but I hoped there's an easier 1-block-solution. It worked before 1.15 and I had no problems with it. I would even go so far as to say that there are less problems with a single block since you don't have to care about other blocks that belong to the model.

[ChampionAsh5357]

8 minutes ago, Fubar said:

I would even go so far as to say that there are less problems with a single block since you don't have to care about other blocks that belong to the model

Just because something is easier doesn't mean it is right. Feel free to try and find a fix the way you are doing it. However, the correct way would be to create two separate blocks that are within the bounds.

[Fubar]

Okay, I guess I'll go with the two-block solution then. Could you tell me, if the following approach would be correct?

Source block (A) will be at the bottom, Child block (B) on top. Both blocks can not be moved by pistons.

 

1. Block A: Use Block.isValidPosition to check if the block above is free (air). Cancel/Allow placement depending on the outcome.

2. Block A: Use Block.onBlockPlacedBy to spawn block B on top

3. Block A & B: Use Block.onReplaced to destroy the connected block A/B.

 

Anything else I need to consider?

[ChampionAsh5357]

3 I would say is correct. As for the other two, they might be already handled in the BlockItem implementation you'll probably need to extend. I think there's already some tall block placements used for that, but I forget the class name.

[Draco18s]

(FWIW, there's no "one block" solution: the game doesn't know that the upper half is occupied, so you can place other blocks there and mobs will pathfind through it)