Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Custom Ore Generation
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
myounge

Custom Ore Generation

By myounge, October 21, 2020 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

myounge    0

myounge

myounge    0

  • Tree Puncher
  • myounge
  • Members
  • 0
  • 14 posts
Posted October 21, 2020

I wanted to made Custom Ore and I make a new ore.

I want to gen it.

I found this  

 

At here 8:50, There are CountRangeConfig and my intellij doesn't suggest me to use that

package com.frost.frost.world.gen;


import com.frost.frost.Frost;
import com.frost.frost.blocks.FrozeOre;
import net.minecraft.block.BlockState;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.gen.feature.OreFeatureConfig;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLLoadCompleteEvent;
import net.minecraftforge.registries.ForgeRegistries;

@Mod.EventBusSubscriber(modid = Frost.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class ModOreGen {

    @SubscribeEvent
    public static void generateOres(FMLLoadCompleteEvent event){
        for (Biome biome : ForgeRegistries.BIOMES){

            //Nether Gen
            if (biome.getCategory() == Biome.Category.NETHER) {

            }
            //End Gen
            else if (biome.getCategory() == Biome.Category.THEEND){
            }
            //Overworld Gen
            else {
            }
        }

    }

    private static void genOre(Biome biome, int count, int bottomOffSet, int topOffset, int max, OreFeatureConfig.FillerBlockType filler, BlockState defaultBlockState, int size){
        CountRangeConfig
    }
}

How do I fix it

  • Quote

Share this post


Link to post
Share on other sites

myounge    0

myounge

myounge    0

  • Tree Puncher
  • myounge
  • Members
  • 0
  • 14 posts
Posted October 21, 2020

My mod's version is 1.16

  • Quote

Share this post


Link to post
Share on other sites

myounge    0

myounge

myounge    0

  • Tree Puncher
  • myounge
  • Members
  • 0
  • 14 posts
Posted October 21, 2020 (edited)

pls help me

Edited October 21, 2020 by myounge
  • Quote

Share this post


Link to post
Share on other sites

Beethoven92    69

Beethoven92

Beethoven92    69

  • Dragon Slayer
  • Beethoven92
  • Members
  • 69
  • 556 posts
Posted October 21, 2020

It seems to me that you did not import the package where CountRangeConfig is

  • Quote

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

A little fun project: https://www.curseforge.com/minecraft/mc-mods/two-players-one-horse

Share this post


Link to post
Share on other sites

MkUltra    0

MkUltra

MkUltra    0

  • Tree Puncher
  • MkUltra
  • Members
  • 0
  • 3 posts
Posted October 21, 2020

Hey i have been doing the same i been working backwards to find all the different inputs of the "boime.addfeature" functionality. Sorry if i am going at this wrong... i am new to coding in java. Here is what i found.

    private static void genOre(Biome biome, int count, int bottomOffset, int topOffset, int max, RuleTest filler, BlockState defualtBlockstate,int size){
        IPlacementConfig range =;
        ConfiguredPlacement config = Placement.field_242903_g.configure(range);
        OreFeatureConfig feature = new OreFeatureConfig(filler, defualtBlockstate, size);
        biome.func_242427_a(GenerationStage.Decoration.UNDERGROUND_ORES,Feature.ORE.withConfiguration(feature).withPlacement(config));
    }
}

 

So firstly biome.addFeature is func_242427 in 1.16.3 ( I don't know if this is the same for you but it is what i have) it takes in the generation stage which is same as the video.  Then the Feature.Ore.Oreconfig(feature) which is same as the video, as well as the with placement which is the same as the video. But CountRangeConfig functionality probably has changed to something else like the biome.addFeature has change to func_242427 (ignore the IPlacementConfig i haven't looked into it yet but i am going through the code of everything related to withPlacement).

Sadly i have to call it a day before i worked out what range is needed to be I hope this help you or someone else find the solution to this or just teach me i am doing it wrong for a vaild reason.

If you have further questions please ask i will get back as soon as i can.

  • Quote

Share this post


Link to post
Share on other sites

MkUltra    0

MkUltra

MkUltra    0

  • Tree Puncher
  • MkUltra
  • Members
  • 0
  • 3 posts
Posted October 21, 2020 (edited)

removed second post same as above.

Edited October 21, 2020 by MkUltra
  • Quote

Share this post


Link to post
Share on other sites

ChampionAsh5357    160

ChampionAsh5357

ChampionAsh5357    160

  • World Shaper
  • ChampionAsh5357
  • Members
  • 160
  • 1019 posts
Posted October 21, 2020

Problematic Code 11. If you would like example implementations, look at the Features class. You will notice that there are some helper methods for placements as there can be multiple assigned to the same feature. Therefore, you can have a placement that handles the amount generate, the spread across the chunk, the height level in the chunk, etc. Do note that their order is important.

 

Second, do not use the above tutorial as a reference. It's outdated and uses terrible practices. It's better to just ask questions and infer from your own knowledge of Java than to follow someone else line by line.

  • Quote

Share this post


Link to post
Share on other sites

myounge    0

myounge

myounge    0

  • Tree Puncher
  • myounge
  • Members
  • 0
  • 14 posts
Posted October 22, 2020
7 hours ago, MkUltra said:

Hey i have been doing the same i been working backwards to find all the different inputs of the "boime.addfeature" functionality. Sorry if i am going at this wrong... i am new to coding in java. Here is what i found.


    private static void genOre(Biome biome, int count, int bottomOffset, int topOffset, int max, RuleTest filler, BlockState defualtBlockstate,int size){
        IPlacementConfig range =;
        ConfiguredPlacement config = Placement.field_242903_g.configure(range);
        OreFeatureConfig feature = new OreFeatureConfig(filler, defualtBlockstate, size);
        biome.func_242427_a(GenerationStage.Decoration.UNDERGROUND_ORES,Feature.ORE.withConfiguration(feature).withPlacement(config));
    }
}

 

So firstly biome.addFeature is func_242427 in 1.16.3 ( I don't know if this is the same for you but it is what i have) it takes in the generation stage which is same as the video.  Then the Feature.Ore.Oreconfig(feature) which is same as the video, as well as the with placement which is the same as the video. But CountRangeConfig functionality probably has changed to something else like the biome.addFeature has change to func_242427 (ignore the IPlacementConfig i haven't looked into it yet but i am going through the code of everything related to withPlacement).

Sadly i have to call it a day before i worked out what range is needed to be I hope this help you or someone else find the solution to this or just teach me i am doing it wrong for a vaild reason.

If you have further questions please ask i will get back as soon as i can.

I can't find biome.func_242427

 

  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2403

Draco18s

Draco18s    2403

  • Reality Controller
  • Draco18s
  • Members
  • 2403
  • 15926 posts
Posted October 22, 2020

Look for biome.addFeature or similar, then.

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

myounge    0

myounge

myounge    0

  • Tree Puncher
  • myounge
  • Members
  • 0
  • 14 posts
Posted October 23, 2020
23 hours ago, Draco18s said:

Look for biome.addFeature or similar, then.

know I know it is biome.generateFeatures

 

  • Quote

Share this post


Link to post
Share on other sites

myounge    0

myounge

myounge    0

  • Tree Puncher
  • myounge
  • Members
  • 0
  • 14 posts
Posted October 23, 2020
On 10/22/2020 at 5:07 AM, MkUltra said:

Hey i have been doing the same i been working backwards to find all the different inputs of the "boime.addfeature" functionality. Sorry if i am going at this wrong... i am new to coding in java. Here is what i found.


    private static void genOre(Biome biome, int count, int bottomOffset, int topOffset, int max, RuleTest filler, BlockState defualtBlockstate,int size){
        IPlacementConfig range =;
        ConfiguredPlacement config = Placement.field_242903_g.configure(range);
        OreFeatureConfig feature = new OreFeatureConfig(filler, defualtBlockstate, size);
        biome.func_242427_a(GenerationStage.Decoration.UNDERGROUND_ORES,Feature.ORE.withConfiguration(feature).withPlacement(config));
    }
}

 

So firstly biome.addFeature is func_242427 in 1.16.3 ( I don't know if this is the same for you but it is what i have) it takes in the generation stage which is same as the video.  Then the Feature.Ore.Oreconfig(feature) which is same as the video, as well as the with placement which is the same as the video. But CountRangeConfig functionality probably has changed to something else like the biome.addFeature has change to func_242427 (ignore the IPlacementConfig i haven't looked into it yet but i am going through the code of everything related to withPlacement).

Sadly i have to call it a day before i worked out what range is needed to be I hope this help you or someone else find the solution to this or just teach me i am doing it wrong for a vaild reason.

If you have further questions please ask i will get back as soon as i can.

biome.generateFeatures (GenationStage.Decoration.UNDERGROUND_ORES, Feature.ORE.withConfiguration).withPlacement();
If you put config in 'Placement', you will get an error.

I want to fix it

  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2403

Draco18s

Draco18s    2403

  • Reality Controller
  • Draco18s
  • Members
  • 2403
  • 15926 posts
Posted October 23, 2020
1 hour ago, myounge said:

you will get an error

And what's the error?

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

MkUltra    0

MkUltra

MkUltra    0

  • Tree Puncher
  • MkUltra
  • Members
  • 0
  • 3 posts
Posted October 23, 2020
On 10/21/2020 at 11:18 PM, ChampionAsh5357 said:

Problematic Code 11. If you would like example implementations, look at the Features class. You will notice that there are some helper methods for placements as there can be multiple assigned to the same feature. Therefore, you can have a placement that handles the amount generate, the spread across the chunk, the height level in the chunk, etc. Do note that their order is important.

 

Second, do not use the above tutorial as a reference. It's outdated and uses terrible practices. It's better to just ask questions and infer from your own knowledge of Java than to follow someone else line by line.


Hey Champion,

Thanks for the help so far i been looking into the Features class. Here is an example of ore_iron from that class. I am just struggling with how to implement this with the forge hook of BiomeloadingEvent is there as i wouldn't want to use biome.func_242427 / "addFeature" ?

public static final ConfiguredFeature<?, ?> field_243898_br = func_243968_a("ore_iron", Feature.ORE.withConfiguration(new OreFeatureConfig(OreFeatureConfig.FillerBlockType.field_241882_a, Features.States.field_244046_aj, 9)).func_242733_d(64).func_242728_a().func_242731_b(20));
  • Quote

Share this post


Link to post
Share on other sites

ChampionAsh5357    160

ChampionAsh5357

ChampionAsh5357    160

  • World Shaper
  • ChampionAsh5357
  • Members
  • 160
  • 1019 posts
Posted October 23, 2020

Biomes are final classes now. The event hooks into the construction process of the biomes and hijacks it's creation allowing for extra entries or fields in the builders to be set. So, the builder contains the methods to add the features.

Also, you do not need to register the ConfiguredFeature. That's more for getting the JSON generated ones to grab the feature for the specific biome.

Finally, Problematic Code 1. You cannot be certain that the feature is present when constructing a static version of ConfiguredFeature. If your class is loaded before the Features are registered, then it will be problematic. This is not to mention the registries might be frozen at that point. However, this is irrelevant as you do not need to register it. This is just for future case.

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • diesieben07
      Minecraft forge not fully loading

      By diesieben07 · Posted just now

      1.8 is no longer supported on this forum. Please update to a modern version of Minecraft to receive support.
    • BastouP
      [1.16.4] Get Overworld save directory

      By BastouP · Posted just now

      Yeah but I am creating a perpheral for computercraft that uses SQL. So i think using a sqlite file would be the easiest way. (You do not need to maintain a server.) However if there is another way I’d be glad to test it. Testing this this evening btw.
    • diesieben07
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By diesieben07 · Posted 1 minute ago

      All living entities already have an armor and held item inventory, you don't need to add it manually. Look at LivingEntity#getCapability, it will return you IItemHandler instances for those inventories.
    • diesieben07
      [1.15.2] Render as 2D icon in GUI, 3D model in hand

      By diesieben07 · Posted 3 minutes ago

      Good question. I don't know much about rendering, so nothing comes to mind immediately.
    • diesieben07
      Forge unable to find model

      By diesieben07 · Posted 5 minutes ago

      1.12 is no longer supported on this forum. Please update to a modern version of Minecraft to receive support.
  • Topics

    • Fars3O_
      1
      Minecraft forge not fully loading

      By Fars3O_
      Started 2 hours ago

    • BastouP
      3
      [1.16.4] Get Overworld save directory

      By BastouP
      Started 12 hours ago

    • Klarks
      1
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By Klarks
      Started 2 hours ago

    • Woodside
      15
      [1.15.2] Render as 2D icon in GUI, 3D model in hand

      By Woodside
      Started Sunday at 08:26 PM

    • CatSack
      1
      Forge unable to find model

      By CatSack
      Started 10 hours ago

  • Who's Online (See full list)

    • Choonster
    • diesieben07
    • DevilishPoint
    • MrDuck20
    • Lucie
    • BastouP
    • Klarks
    • VoidTheFloof
    • Will11690
    • monkeysHK
    • Sr_endi
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Custom Ore Generation
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community