Jump to content

Recommended Posts

Posted

So I want the player to break the block. Like if he is in survival break with correct speed, in creative instamine. I also want it to drop

I am assuming there is a function I need to call in order for that to happen

 

thx!

Posted
9 minutes ago, diesieben07 said:

Look at Minecraft#sendClickBlockToController for the client-side part.

Uhh can you explain? I am using block.harvestBlock. figuring out its arguments

Posted

Okay

Just now, diesieben07 said:

Well, that's the last step of breaking a block. Before that comes showing the breaking damage, etc. I pointed you to the entrypoint of the whole process ("the player just pressed the left mouse button this tick - do something with that information"). You need to trace the code path from there (and across the network packets being sent) and figure out which methods are being called.

It's not as simple as just "call method X".

I'm like a real newbie to the blocks n stuff. How can I trace the code? do I set a debug breakpoint on every line or wut?

Posted
1 minute ago, diesieben07 said:

You open the code in your IDE. Look at which methods are called, click on them, see what they do, etc.

Breakpoints definitely do help if you have trouble understanding what exactly is going on.

Okay, How to I use this thing u told me?

 

17 minutes ago, diesieben07 said:

Look at Minecraft#sendClickBlockToController for the client-side part.

---------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------

Posted
1 hour ago, diesieben07 said:

Use ctrl-shift-alt-n to search for symbols, then enter the method name.

Hello! I have this code now:

public static boolean attack(){
        ClientPlayerEntity player = Minecraft.getInstance().player;
        if ((player == null)) {return false;}

        RayTraceResult lookingAt = Minecraft.getInstance().objectMouseOver;
        assert lookingAt != null;
        System.out.println(lookingAt.getType().toString());
        if (lookingAt.getType() == RayTraceResult.Type.BLOCK) {
            if (lookingAt.getType().toString() == "a"){
                System.out.println("Yeaaa");
            }
            double x = lookingAt.getHitVec().getX();
            double y = lookingAt.getHitVec().getY();
            double z = lookingAt.getHitVec().getZ();
            Minecraft.getInstance().particles.addBlockHitEffects(new BlockPos(x, y, z), (BlockRayTraceResult) lookingAt);
            Minecraft.getInstance().player.swingArm(Hand.MAIN_HAND);
            player.world.getBlockState(new BlockPos(x, y, z))
                    .getBlock().
                            harvestBlock(
                    player.world,
                    player,
                    new BlockPos(x, y, z),
                    player.world.getBlockState(new BlockPos(x, y, z)),
                    player.world.getTileEntity(new BlockPos(x, y, z)),
                                    player.getHeldItemMainhand()
                                    );
        }


        return true;
    }

And It just animates the block breaking, but dosent drop the block. pls help :)

Posted
3 hours ago, diesieben07 said:

It cannot be both a client-only mod and not a client-only mod.

That's like saying something is alive and dead at the same time.

It is basically a helper mod for my project. All I need this mod to do is to do what a normal player can whenever I ask it to do something from python. the python-java communication is flawless. just need a way to contol the player. so I guess it is up to you who says what I need :D 

Posted (edited)

The client, as the client, obviously has some way to make blocks break and drop their loot on the server.

It doesn't happen by magic (unless packets are magic).

All you need to do is find the code that the client already does and make it run automatically instead of on user input.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
2 minutes ago, Draco18s said:

The client, as the client, obviously has some way to make blocks break and drop their loot on the server.

It doesn't happen by magic (unless packets are magic).

All you need to do is find the code that the client already does and make it run automatically instead of on user input.

Do u know the function that is called?

Posted
1 minute ago, diesieben07 said:

I will keep quoting this until you read it.

I checked it a long time ago. heres the new code I updated but didnt post:

public static boolean attack(){
        ClientPlayerEntity player = Minecraft.getInstance().player;
        if ((player == null)) {return false;}

        RayTraceResult lookingAt = Minecraft.getInstance().objectMouseOver;
        assert lookingAt != null;
        System.out.println(lookingAt.getType().toString());
        if (lookingAt.getType() == RayTraceResult.Type.BLOCK) {
            if (lookingAt.getType().toString() == "a"){
                System.out.println("Yeaaa");
            }
            double x = lookingAt.getHitVec().getX();
            double y = lookingAt.getHitVec().getY();
            double z = lookingAt.getHitVec().getZ();
            net.minecraftforge.client.event.InputEvent.ClickInputEvent inputEvent = net.minecraftforge.client.ForgeHooksClient.onClickInput(0, Minecraft.getInstance().gameSettings.keyBindAttack, Hand.MAIN_HAND);
            if (inputEvent.shouldSwingHand()) {
                Minecraft.getInstance().particles.addBlockHitEffects(new BlockPos(x, y, z), (BlockRayTraceResult) lookingAt);
                Minecraft.getInstance().player.swingArm(Hand.MAIN_HAND);
            }
            player.world.getBlockState(new BlockPos(x, y, z))
                    .getBlock().
                            harvestBlock(
                    player.world,
                    player,
                    new BlockPos(x, y, z),
                    player.world.getBlockState(new BlockPos(x, y, z)),
                    player.world.getTileEntity(new BlockPos(x, y, z)),
                                    player.getHeldItemMainhand()
                                    );
        }


        return true;
    }

 

Posted

I would suggest you try with Block#destroyBlock, instead of Block#harvestBlock:

 

            player.world.getBlockState(new BlockPos(x, y, z))
                    .getBlock().
                    .destroyBlock(player, false/true);

or you can also use Block#spawnDrops whenever needed.

 

Posted
11 minutes ago, Kalma said:

I would suggest you try with Block#destroyBlock, instead of Block#harvestBlock:

 


            player.world.getBlockState(new BlockPos(x, y, z))
                    .getBlock().
                    .destroyBlock(player, false/true);

or you can also use Block#spawnDrops whenever needed.

 

This cannot be done client side. #ReadTheThread.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
On 10/30/2020 at 12:52 AM, Kalma said:

I would suggest you try with Block#destroyBlock, instead of Block#harvestBlock:

 


            player.world.getBlockState(new BlockPos(x, y, z))
                    .getBlock().
                    .destroyBlock(player, false/true);

or you can also use Block#spawnDrops whenever needed.

 

destroyBlock dosent exists -_-

Posted

hahahahaha!

 

I am not sure if this is what you really need as draco18s estated. I mean, blockDestroy is server-side, so you should change most of the code you posted since it is definitely client-side. Besides that, you can not input "false/true"! You have to call the function using "false" (no drops) or true (drop items)...

 

I would recommend you follow diesieben7 suggestion, and take a look to "Minecraft#sendClickBlockToController for the client-side part."

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.