Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.16.3] ArrayIndexOutOfBounds on Packet

Razzokk

By Razzokk
in Modder Support

 Share

Recommended Posts

Razzokk Tree Puncher

Razzokk

Posted
Posted

Exception thrown:

 

[Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.ArrayIndexOutOfBoundsException: null

 

I get this exception when playing on the server. I open a client-side only gui and when pressing a button I am sending a packet that sets an integer in the blocks TileEntity but because of this error, the integer is not actually set. Any ideas what that could be? I do not get any errors on the client. It works correctly when playing on singleplayer.

Link to comment
Share on other sites
DaemonUmbra Reality Controller

DaemonUmbra

Posted
Posted

Please provide debug.log (more info on where it is and how to provide it in my signature below, just expand the spoiler)

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/: 100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites
Razzokk Tree Puncher

Razzokk

Posted
  • Author
Posted

Exception thrown:

 

[Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.ArrayIndexOutOfBoundsException: null

 

I get this exception when playing on the server. I open a client-side only gui and when pressing a button I am sending a packet that sets an integer in the blocks TileEntity but because of this error, the integer is not actually set. Any ideas what that could be? I do not get any errors on the client. It works correctly when playing on singleplayer.

 

debug.log: https://pastebin.pl/view/6c5c281a

Link to comment
Share on other sites
Razzokk Tree Puncher

Razzokk

Posted
  • Author
Posted (edited) 
public class PacketHandler
{
	private static int id = 0;
	private static final String PROTOCOL_VERSION = "1.0";
	public static final SimpleChannel INSTANCE = NetworkRegistry.newSimpleChannel(
			new ResourceLocation(WirelessRedstone.MODID, "main_channel"),
			() -> PROTOCOL_VERSION,
			PROTOCOL_VERSION::equals,
			PROTOCOL_VERSION::equals
	);

	public static void registerMessages()
	{
		registerMessage(PacketFrequencyBlock.class, PacketFrequencyBlock::new);
		registerMessage(PacketFrequencyItem.class, PacketFrequencyItem::new);
	}

	public static <P extends Packet> void registerMessage(Class<P> packetType, Function<PacketBuffer, P> decoder)
	{
		INSTANCE.registerMessage(id++, packetType, Packet::toBytes, decoder, Packet::handle);
	}
}
public abstract class Packet
{
	public Packet() {}

	public Packet(PacketBuffer buffer) {}

	public abstract void toBytes(PacketBuffer buffer);

	public abstract void handle(Supplier<NetworkEvent.Context> ctx);
}
public abstract class PacketFrequency extends Packet
{
	private int frequency;

	public PacketFrequency(int frequency)
	{
		this.frequency = frequency;
	}

	public PacketFrequency(PacketBuffer buffer)
	{
		super(buffer);
		frequency = buffer.readInt();
	}

	@Override
	public void toBytes(PacketBuffer buffer)
	{
		buffer.writeInt(frequency);
	}

	public void setFrequency(int frequency)
	{
		this.frequency = frequency;
	}

	public int getFrequency()
	{
		return frequency;
	}
}
public class PacketFrequencyBlock extends PacketFrequency
{
	private final BlockPos pos;

	public PacketFrequencyBlock(BlockPos pos)
	{
		super(-1);
		this.pos = pos;
	}

	public PacketFrequencyBlock(PacketBuffer buffer)
	{
		super(buffer);
		pos = BlockPos.fromLong(buffer.readLong());
	}

	@Override
	public void toBytes(PacketBuffer buffer)
	{
		super.toBytes(buffer);
		buffer.writeLong(pos.toLong());
	}

	@Override
	public void handle(Supplier<NetworkEvent.Context> ctx)
	{
		ctx.get().enqueueWork(() ->
		{
			ServerPlayerEntity player = ctx.get().getSender();
			ServerWorld world = player != null ? player.getServerWorld() : null;

			if (world != null && world.isAreaLoaded(pos, 0))
				WorldUtils.ifTilePresent(world, pos, TileFrequency.class, tile -> tile.setFrequency(getFrequency()));

		});
		ctx.get().setPacketHandled(true);
	}
}
@OnlyIn(Dist.CLIENT)
public class GuiFrequency extends Screen
{
	public static final ResourceLocation GUI_TEXTURE_NORMAL = new ResourceLocation(WirelessRedstone.MODID, "textures/gui/frequency.png");
	public static final ResourceLocation GUI_TEXTURE_EXTENDED = new ResourceLocation(WirelessRedstone.MODID, "textures/gui/frequency_extended.png");
	private ResourceLocation gui_texture = GUI_TEXTURE_NORMAL;

	private int guiLeft;
	private int guiTop;
	private int xSize;
	private int ySize;

	private int frequency;
	private PacketFrequency frequencyPacket;

	// Standard GUI
	private Button close;
	private TextFieldWidget frequencyField;
	private Button buttonSubtract_1;
	private Button buttonSubtract_10;
	private Button buttonAdd_1;
	private Button buttonAdd_10;
	private Button done;

	// Extended GUI
	private boolean extended;
	private Button buttonExtend;
	private TextFieldWidget frequencyName;
	private Button buttonAddName;
	private TextFieldWidget searchbar;

	public GuiFrequency(int frequency, PacketFrequency frequencyPacket)
	{
		super(new TranslationTextComponent(LangKeys.Gui.FREQUENCY));
		this.frequency = frequency;
		this.frequencyPacket = frequencyPacket;
	}

	@Override
	protected void init()
	{
		xSize = 192;
		ySize = 96;
		guiLeft = (width - xSize) / 2;
		guiTop = (height - ySize) / 2 - 40;

		// Standard GUI

		addButton(close = new SizedButton(guiLeft + xSize - 18, guiTop + 6, 12, 12, new StringTextComponent("x"), 0, -1, button -> minecraft.player.closeScreen()));
		addButton(buttonSubtract_1 = new SizedButton(guiLeft + 28, guiTop + 24, 36, 16, new StringTextComponent("-1"), this::buttonPressed));
		addButton(buttonSubtract_10 = new SizedButton(guiLeft + 28, guiTop + 44, 36, 16, new StringTextComponent("-10"), this::buttonPressed));
		addButton(buttonAdd_1 = new SizedButton(guiLeft + 128, guiTop + 24, 36, 16, new StringTextComponent("+1"), this::buttonPressed));
		addButton(buttonAdd_10 = new SizedButton(guiLeft + 128, guiTop + 44, 36, 16, new StringTextComponent("+10"), this::buttonPressed));
		addButton(done = new SizedButton(guiLeft + 78, guiTop + 64, 36, 18, new TranslationTextComponent(LangKeys.Gui.DONE), onPress -> sendPacket()));

		frequencyField = new TextFieldWidget(font, guiLeft + 76, guiTop + 35, 38, 14, new TranslationTextComponent(LangKeys.Gui.FREQUENCY))
		{
			@Override
			public void writeText(String textToWrite)
			{
				StringBuilder stringbuilder = new StringBuilder();

				for (char c0 : textToWrite.toCharArray())
					if (c0 >= 48 && c0 <= 57)
						stringbuilder.append(c0);

				super.writeText(stringbuilder.toString());
			}
		};

		frequencyField.setMaxStringLength(5);
		frequencyField.setText(String.valueOf(frequency));
		frequencyField.setResponder(text ->
		{
			if (text == null || text.isEmpty())
			{
				done.active = false;
				setFrequency(0);
			}
			else
			{
				done.active = true;
				setFrequency(Integer.parseInt(text));
			}
		});
		children.add(frequencyField);

		// Extended GUI


		addButton(buttonExtend = new SizedButton(guiLeft + xSize - 48, guiTop + ySize - 22, 42, 16, new TranslationTextComponent(LangKeys.Gui.EXTEND), this::extend));
		frequencyName = new TextFieldWidget(font, guiLeft + 7, guiTop + 100, 144, 14, new TranslationTextComponent(LangKeys.Gui.FREQUENCY_NAME));
		addButton(buttonAddName = new SizedButton(guiLeft + 154, guiTop + 99, 32, 16, new TranslationTextComponent(LangKeys.Gui.ADD), onPress -> System.out.println("add to list")));
		buttonAddName.visible = extended;
		searchbar = new TextFieldWidget(font, guiLeft + 7, guiTop + 130, 178, 14, new TranslationTextComponent(LangKeys.Gui.SEARCHBAR));

		children.add(frequencyName);
		children.add(searchbar);
	}

	private void setFrequency(int frequency)
	{
		this.frequency = MathUtils.constrain(frequency, 0, 99999);
	}

	private void buttonPressed(Button button)
	{
		setFrequency(frequency + Integer.parseInt(button.getMessage().getString()));
		frequencyField.setText(String.valueOf(frequency));
	}

	private void extend(Button button)
	{
		extended = !extended;

		if (extended)
		{
			ySize = 176;
			buttonExtend.setMessage(new TranslationTextComponent(LangKeys.Gui.REDUCE));
			gui_texture = GUI_TEXTURE_EXTENDED;
		}
		else
		{
			ySize = 96;
			buttonExtend.setMessage(new TranslationTextComponent(LangKeys.Gui.EXTEND));
			gui_texture = GUI_TEXTURE_NORMAL;
		}
		buttonAddName.visible = extended;
	}

	@Override
	public boolean keyPressed(int keyCode, int scanCode, int modifiers)
	{
		switch (keyCode)
		{
			case GLFW.GLFW_KEY_LEFT_SHIFT:
			case GLFW.GLFW_KEY_RIGHT_SHIFT:
				buttonSubtract_1.setMessage(new StringTextComponent("-100"));
				buttonSubtract_10.setMessage(new StringTextComponent("-1000"));
				buttonAdd_1.setMessage(new StringTextComponent("+100"));
				buttonAdd_10.setMessage(new StringTextComponent("+1000"));
				break;
		}

		return frequencyField.keyPressed(keyCode, scanCode, modifiers) || frequencyField.canWrite() || super.keyPressed(keyCode, scanCode, modifiers);
	}

	@Override
	public boolean keyReleased(int keyCode, int scanCode, int modifiers)
	{
		switch (keyCode)
		{
			case GLFW.GLFW_KEY_LEFT_SHIFT:
			case GLFW.GLFW_KEY_RIGHT_SHIFT:
				buttonSubtract_1.setMessage(new StringTextComponent("-1"));
				buttonSubtract_10.setMessage(new StringTextComponent("-10"));
				buttonAdd_1.setMessage(new StringTextComponent("+1"));
				buttonAdd_10.setMessage(new StringTextComponent("+10"));
				break;
		}

		return super.keyReleased(keyCode, scanCode, modifiers);
	}

	@Override
	public void render(MatrixStack matrixStack, int mouseX, int mouseY, float partialTicks)
	{
		renderBackground(matrixStack);
		drawGuiBackgroundTexture(matrixStack, mouseX, mouseY, partialTicks);

		font.drawString(matrixStack, title.getString(), guiLeft + (xSize - font.getStringWidth(title.getString())) / 2, guiTop + 7, 0x404040);
		frequencyField.render(matrixStack, mouseX, mouseY, partialTicks);

		if (extended)
		{
			font.drawString(matrixStack, new TranslationTextComponent(LangKeys.Gui.FREQUENCY_NAME).getString(), guiLeft + 6, guiTop + 80, 0x404040);
			frequencyName.render(matrixStack, mouseX, mouseY, partialTicks);
			searchbar.render(matrixStack, mouseX, mouseY, partialTicks);
		}

		super.render(matrixStack, mouseX, mouseY, partialTicks);
	}

	private void drawGuiBackgroundTexture(MatrixStack matrixStack, int mouseX, int mouseY, float partialTicks)
	{
		RenderSystem.color4f(1.0F, 1.0F, 1.0F, 1.0F);
		minecraft.getTextureManager().bindTexture(gui_texture);
		blit(matrixStack, guiLeft, guiTop, 0, 0, xSize, ySize);
	}

	private void sendPacket()
	{
		frequencyPacket.setFrequency(frequency);
		PacketHandler.INSTANCE.sendToServer(frequencyPacket);
		minecraft.player.closeScreen();
	}

	@Override
	public boolean isPauseScreen()
	{
		return false;
	}
}

 

Edited by Razzokk
formatting
Link to comment
Share on other sites
Razzokk Tree Puncher

Razzokk

Posted
  • Author
Posted

Ok got the thing with @OnlyIn. But the Packet Instance is created when opening the gui (I have to refactor this, I made this really crappy I just realized).

  

@Override
	public ActionResultType onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult hit)
	{
		if (world.isRemote)
			WorldUtils.ifTilePresent(world, pos, TileFrequency.class, tile ->
					WirelessRedstone.proxy.openFrequencyGui(tile.getFrequency(), new PacketFrequencyBlock(pos)));
		return ActionResultType.SUCCESS;
	}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept