Jump to content

[1.16.3] Generate structure in custom biome


Beethoven92

Recommended Posts

I am experiencing troubles trying to add a custom structure into a custom biome. The problem is that my biome is registering before my structure and so of course i get a "Registry object not present" error on startup:

Quote

Exception message: java.lang.NullPointerException: Registry Object not present: betterendforge:mountain_structure

I saw this post a while ago but this seems to not be applicable concerning structure registration: https://forums.minecraftforge.net/topic/93134-solved-1163-registering-biome-with-modded-features/ at least not in a way i can figure out. It seems that there is not an overload of BiomeGenerationSettings.Builder#withStructure that accepts a Supplier. I should mention that both the biome and the structure works perfectly on their own. My biome is correctly added and generated in the End and i can generate my structure in vanilla biomes using the BiomeLoadingEvent, so the problem shows up only when trying to register the structure in my custom biome. Code for reference:

 

BiomeTemplate is just workaround wrapper to help constructing the biome, and BetterEndBiome stores a Biome object internally

public class CrystalMountainsBiome extends BetterEndBiome
{
	public CrystalMountainsBiome() 
	{
		super(new BiomeTemplate("crystal_mountains").setGrassColor(255, 133, 211).
				                  setFoliageColor(255, 133, 211).
				                  setMobSpawn(EntityClassification.MONSTER, EntityType.ENDERMAN, 50, 1, 2).
				                  addStructure(ModConfiguredStructures.MOUNTAIN_STRUCTURE)); // This will crash on startup
	}
}

Biome registry:

public class ModBiomes 
{
	public static final DeferredRegister<Biome> BIOMES = 
			DeferredRegister.create(ForgeRegistries.BIOMES, BetterEnd.MOD_ID);

	public static final RegistryObject<Biome> CRYSTAL_MOUNTAINS = BIOMES.register("crystal_mountains",
			() -> new CrystalMountainsBiome().getBiome());
}

Structure registry:

public class ModStructures 
{
    public static final Map<Structure<?>, StructureSeparationSettings> BETTEREND_STRUCTURES = new HashMap<>();
	
	public static final DeferredRegister<Structure<?>> STRUCTURES = 
			DeferredRegister.create(ForgeRegistries.STRUCTURE_FEATURES, BetterEnd.MOD_ID);
	
	public static final RegistryObject<Structure<NoFeatureConfig>> MOUNTAIN = registerStructure("mountain_structure", 
			new MountainStructure(NoFeatureConfig.field_236558_a_));
    
    private static <T extends Structure<?>> RegistryObject<T> registerStructure(String name, T structure) 
    {
        return STRUCTURES.register(name, () -> structure);
    }
    
    public static void setupStructures()
    {
    	setupStructure(MOUNTAIN.get(), 
    			new StructureSeparationSettings(5, 2, 1234567890));
    }
    
    private static <F extends Structure<?>> void setupStructure(F structure, 
    		StructureSeparationSettings structureSeparationSettings)
    {
       	//NAME_STRUCTURE_BIMAP
    	Structure.field_236365_a_.put(structure.getRegistryName().toString(), structure);

    	DimensionStructuresSettings.field_236191_b_ = // Default structures
                ImmutableMap.<Structure<?>, StructureSeparationSettings>builder()
                        .putAll(DimensionStructuresSettings.field_236191_b_)
                        .put(structure, structureSeparationSettings)
                        .build();
    	
    	BETTEREND_STRUCTURES.put(structure, structureSeparationSettings);
      }
 }

Configured structures:

public class ModConfiguredStructures 
{
    public static final StructureFeature<NoFeatureConfig, ? extends Structure<NoFeatureConfig>> MOUNTAIN_STRUCTURE = 
    		ModStructures.MOUNTAIN.get().func_236391_a_(IFeatureConfig.NO_FEATURE_CONFIG);

    private static <FC extends IFeatureConfig, F extends Structure<FC>> StructureFeature<FC, F> register(String name, StructureFeature<FC, F> structureFeature)
    {
        return WorldGenRegistries.register(WorldGenRegistries.CONFIGURED_STRUCTURE_FEATURE, name, structureFeature);
    }
    
    public static void registerStructureFeatures()
    {
    	WorldGenRegistries.register(WorldGenRegistries.CONFIGURED_STRUCTURE_FEATURE, 
    			new ResourceLocation(BetterEnd.MOD_ID, "mountain_structure"), MOUNTAIN_STRUCTURE);
    }
}

Relevant main class code:

    public BetterEnd() 
    {
    	IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

        modEventBus.addListener(this::setupCommon);
    	
        ModStructures.STRUCTURES.register(modEventBus);
    	ModBiomes.BIOMES.register(modEventBus);
    }

    private void setupCommon(final FMLCommonSetupEvent event)
    {
    	event.enqueueWork(() -> {
            ModStructures.setupStructures();
            ModConfiguredStructures.registerStructureFeatures();
        });     
    }

 

Does anyone know which way to go about this?

Edited by Beethoven92

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Link to comment
Share on other sites

58 minutes ago, Beethoven92 said:

Does anyone know which way to go about this?

I am not super familiar with the world generation part of Minecraft, so forgive me if I am way off, but could you not just wait and add the structure to the biome until after your structure is registered (i.e. last in setupCommon)?

Link to comment
Share on other sites

I tried with this line at the end of the enqueueWork:

ModBiomes.CRYSTAL_MOUNTAINS.get().getGenerationSettings().structures.add(() -> ModConfiguredStructures.MOUNTAIN_STRUCTURE);

No crash but the structure is nowhere to be found inside the biome, and using the /locate command shows that in fact it is not generating anywhere

Edited by Beethoven92

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Link to comment
Share on other sites

  • Beethoven92 changed the title to [1.16.3] Generate structure in custom biome
On 11/8/2020 at 9:15 PM, Beethoven92 said:

No crash but the structure is nowhere to be found inside the biome, and using the /locate command shows that in fact it is not generating anywhere

Alright, let's try another way: If you extend the BiomeGenerationSettings.Builder class, and add your own method that takes a structure supplier, i.e. something like this:

public static class Builder extends BiomeGenerationSettings.Builder {
  public BiomeGenerationSettings.Builder withStructureSupplier(Supplier<StructureFeature<?, ?>> structure) {
    this.structures.add(structure);
    return this;
  }
}

and then use this builder to create your biome instead. Does that work?

  • Like 1
Link to comment
Share on other sites

Oh sorry Vemerion, i actually solved that issue yesterday and forgot to say that in the post..i have not tried what you suggest so i don't know if it works but it seems it actually could. Anyway i solved it by giving away the structure deferred register and by using static initializers for the Structure and the StructureFeature. Those are then registered inside the RegistryEvent.Register<Structure<?>. This way the code above works because now the structure is known at the time the biome is initalized. I was kinda hoping to do the job without giving away the deferred register though..so i may also try your idea. World generation stuff really seems to be a dirty job to handle right now..

  • Like 1

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Link to comment
Share on other sites

9 hours ago, Beethoven92 said:

Oh sorry Vemerion, i actually solved that issue yesterday and forgot to say that in the post..i have not tried what you suggest so i don't know if it works but it seems it actually could. Anyway i solved it by giving away the structure deferred register and by using static initializers for the Structure and the StructureFeature. Those are then registered inside the RegistryEvent.Register<Structure<?>. This way the code above works because now the structure is known at the time the biome is initalized. I was kinda hoping to do the job without giving away the deferred register though..so i may also try your idea. World generation stuff really seems to be a dirty job to handle right now..

Ah, I am glad you were able to solve it! I agree with you, world generation is such a hassle right now, I am hesitant to even go near those systems. But it will get better down the line I guess. Also, just because I am curious, are you working on a port of the fabric BetterEnd mod, or are you creating your mod from scratch? Either way, interesting mod idea!

Link to comment
Share on other sites

3 hours ago, vemerion said:

Also, just because I am curious, are you working on a port of the fabric BetterEnd mod, or are you creating your mod from scratch? Either way, interesting mod idea!

Yep, i am porting the BetterEnd fabric mod to Forge, because i find their asthetics crazy good (not really minecrafty though) and i think this mod deserves to be played by forge users also. Luckily they are working under the MIT license!

  • Like 1

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Link to comment
Share on other sites

1 hour ago, Beethoven92 said:

Yep, i am porting the BetterEnd fabric mod to Forge, because i find their asthetics crazy good (not really minecrafty though) and i think this mod deserves to be played by forge users also. Luckily they are working under the MIT license!

Alright, cool! Be sure to give me a ping when you release the mod :) 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Honestly i gave up on hiring a online hacker due to the bad experienced i always encounter with them but this time i was really in urgent need for a legit one cos i needed to be sure what my partners plan is as he is avoiding me and always hiding hen making calls couple with his late night movement. i was so scared so i got a helping hand from a friend Hyung who introduced me with this expert hacker, i was scared and lost trust in him at first but after giving him a try in couple of hours i got access to my partner phone and saw his call recordings, hidden text messages, social accounts , hidden photos and more. Thank you [ Hacker11tech @ gm ail . c om ] for been legit.
    • Hello I'm looking for help launching minecraft through curseforge. I've scoured the Internet and can't seem to find anyone with a solution to my specific situation/fix that I haven't tried. I'll post the Curseforge debug Logs below. But basically I'm on a Laptop (Lenovo Legion Slim 7 2021) And the people I've seen with the most similar scenario and found a fix they always had an AMD graphics card and were missing the correct drivers, Well i have the Nvidia geforce RTX 3060 Laptop version with all the most updated drivers, I've reinstalled the drivers so that doesn't seem to me the problem. Also, minecraft will launch in vanilla and through another modloader called modrinth. So it doesn't feel like a Java error either but I don't no how to read this debug page so I'm looking for advice. Please help?!  
    • Hello. Basically I made a custom standalone util library (https://github.com/lolhol/Pathfinder3D) and want to use it with my mod. Although I have done the normal jit pack stuff (basically the tutorial on their website) the Minecraft crashes the second it starts saying that it cannot find the name of a class inside of my library. (When I remove the implement(<my library link thingy>) mc launches normally and does not crash (if I comment out the code that uses the custom lib)). Now then, is there a quick fix for this because all of the other questions that I found on this topic were trying to load another mod (again, not what I’m trying to do). Am I doing something wrong? 
    • Fast Leaf Decay (by olafskiii) Rubidium (by Asek3) Artifacts (by ochotonida) Framework (by MrCrayfish) Max Health Fix (by DarkhaxDev) Embeddium/Rubidium Extras (by Txni) Essential Mod (by SparkUniverse_) Immersive Aircraft [Fabric/Forge] (by Conczin) Cherished Worlds (Fabric/Forge/NeoForge/Quilt) (by TheIllusiveC4) ExpandAbility (by florensie) Sophisticated Core (by P3pp3rF1y) Tinkers' Levelling Addon (by Pyre540) Better Advancements (by way2muchnoise) Immersive Melodies [Fabric/Forge] (by Conczin) Citadel (by sbom_xela) Vampirism - Become a vampire! (by maxanier) FerriteCore ((Neo)Forge) (by malte0811) CoroUtil (by Corosus) Create Big Cannons (by rbasamoyai) Controlling (by Jaredlll08) Cloth Config API (Fabric/Forge/NeoForge) (by shedaniel) Mekanism (by bradyaidanc) BetterF3 (by cominixo) Supplementaries (by MehVahdJukaar) Chest Cavity - Forge Port (by booneldanforever) ConnectedTexturesMod (by tterrag1098) NetherPortalFix (by BlayTheNinth) Spartan Weaponry (by ObliviousSpartan) Charm of Undying (Fabric/Forge/Quilt) (by TheIllusiveC4) Plushie Mod (by Link4real) JourneyMap (by techbrew) Farmer's Delight (by vectorwing) Connectivity[Forge/Fabric] (by someaddon) Create : Misc & Things (by To0pa) Create: Steam 'n' Rails (by IThundxr) Shutup Experimental Settings! (by Corgi_Taco) Alex's Mobs (by sbom_xela) Quark (by Vazkii) Tool Belt (by gigaherz) Just Enough Items (JEI) (by mezz) Bookshelf (by DarkhaxDev) FastWorkbench (by Shadows_of_Fire) Tinkers Construct (by mDiyo) Collective (by Serilum) Inventory HUD+ (by dmitrylovin) Explorer's Compass (by Chaosyr) playerAnimator (by KosmX) Size Devices (by DaFlame_rl) Jade 🔍 (by Snownee) Create Slice & Dice (by possible_triangle) Create Jetpack (by possible_triangle) Carry On (by Tschipp) Moonlight Lib (by MehVahdJukaar) Kotlin for Forge (by thedarkcolour) CraftTweaker (by Jaredlll08) Just Enough Resources (JER) (by way2muchnoise) AI Improvements (by QueenOfMissiles) Patchouli (by Vazkii) Catalogue (by MrCrayfish) Tool Stats (by DarkhaxDev) It Takes a Pillage (by izofar) JEITweaker (by Jaredlll08) Waystones (by BlayTheNinth) Vampires Need Umbrellas (by focamacho) Oculus (by Asek3) Mantle (by mDiyo) Mob Grinding Utils (by vadis365) Chiseled (by freepeopleworking) AutoRegLib (by Vazkii) Mystical Agriculture (by BlakeBr0) Embeddium/Rubidium Dynamic Lights (by Txni) Flywheel (Legacy) (by jozufozu) Builder's Delight (Forge) (by Tynoxs) Apotheosis (by Shadows_of_Fire) What Are They Up To (Watut) (by Corosus) Create: Interiors (by sudolev) FastFurnace (by Shadows_of_Fire) Balm (Forge Edition) (by BlayTheNinth) Clumps (by Jaredlll08) Iris & Oculus Flywheel Compat (by leon_mout) Configured (by MrCrayfish) Tinkers' Expansion (by Insane96) Crafting on a stick (by OfekN_) MrCrayfish's Gun Mod (by MrCrayfish) Create: Crystal Clear (by singularity_cyvack) FTB Library (Forge) (by FTB) AppleSkin (by squeek502) Curios API (Forge/NeoForge) (by TheIllusiveC4) Better Third Person (by Socolio) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Sons Of Sins (by Furti_Two) SwingThroughGrass (by exidex) AttributeFix (by DarkhaxDev) Quests Additions (Forge) (by NaturaSpell) Building Gadgets (by Direwolf20) Enchantment Descriptions (by DarkhaxDev) Skin Layers 3D (Fabric/Forge) (by tr7zw) Bad Wither No Cookie - Reloaded (by Kreezxil) Placebo (by Shadows_of_Fire) FTB Teams (Forge) (by FTB) Mod Name Tooltip (by mezz) Enigmatic Graves (by Quarris) Sophisticated Backpacks (by P3pp3rF1y) GeckoLib (by Gecko) Builders Crafts & Additions (by MRHminer) Immersive Portals (for Forge) (by qouteall) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Lazy DataFixerUpper(LazyDFU) [FORGE] (by Corgi_Taco) Create Ore Excavation (by tom54541) Tinkers' Rapier (by sz0999312) Mowzie's Mobs (by bobmowzie) Better Combat [Fabric & Forge] (by daedelus_dev) Create Stuff & Additions (by Furti_Two) Cucumber Library (by BlakeBr0) FPS Reducer (by bre2el) Item Filters (by LatvianModder) FTB Quests (Forge) (by FTB) L_Ender 's Cataclysm (by mcl_ender) Starter Kit (by Serilum) Feature NBT Deadlock Be Gone (by telepathicgrunt) Materialis (by RCXcrafter) KleeSlabs (by BlayTheNinth) Pehkui (by Virtuoel) Grappling Hook Mod (by yyonne) Security Craft (by Geforce132) Ars Nouveau (by baileyholl2) Mouse Tweaks (by YaLTeR) Werewolves - Become a Beast! (by Cheaterpaul) Elytra Slot (Fabric/Forge/Quilt) (by TheIllusiveC4) Create (by simibubi) Budschie's Morph Mod (by budschie_) Ore Excavation (by Funwayguy) Create Confectionery (by Furti_Two)
    • Hello, im kind of a newbie on creating mods, and i been trying to make simples mods so far, Right now, i'm creating a mod which detect an specific type of mob and kill it if reach a certain number, by far the mod is detecting the mob and counting them but at the time it reach the limit number, it don't do anything. The Game don't tweak, don't crash, just i't don't run the method i call, which is kill().   public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) { final var TotalCows = pLevel.getNearbyEntities(Cow.class, TargetingConditions.forNonCombat(), pPlayer, pPlayer.getBoundingBox().inflate(5)); if(pLevel.isClientSide){ if(pPlayer.getItemInHand(InteractionHand.MAIN_HAND).getItem() == this.asItem()){ if(!TotalCows.isEmpty()){ if(TotalCows.get(0).isAlive()){ TotalCows.get(0).kill(); } }else{ pPlayer.sendSystemMessage(Component.literal("No hay vacas")); } } } The sendSystemMessage is get triggered, and when i change the method .kill() by any other like send a message it got called, can i get some tips, and a clue of what i'm missing
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.