Jump to content

Recommended Posts

Posted

so im following this tutorial [https://cadiboo.github.io/tutorials/1.15.2/forge/1.7-itemgroup/] and I'm completely new to all of this. I'm literally copy and pasting while adding stuff so some lines are colored and styled like the site says but noting is working. This is what the log says:  

error: invalid method declaration; return type required
        public ModItemGroup(final String name, final Supplier<ItemStack> iconSupplier) {
               ^
1 error

this is the code

package com.[REDACTED].[REDACTED].init;


import java.util.function.Supplier;

import com.[REDACTED].[REDACTED].[REDACTED];
import net.minecraft.item.ItemGroup;
import net.minecraft.item.Items;

[File: ModItemGroups.java]


public static class ModItemGroup extends ItemGroup {

	private final Supplier<ItemStack> iconSupplier;
	public ModItemGroup(final String name, final Supplier<ItemStack> iconSupplier) {
		super(name);
		this.iconSupplier = iconSupplier;
	}
	@Override
	public ItemStack createIcon() {
		return iconSupplier.get();
	}
	public static final ItemGroup MOD_ITEM_GROUP = new ModItemGroup([REDACTED].MODID, () -> new ItemStack(ModItems.EXAMPLE_ITEM));
}
[File: ModItems.java]

package com.[REDACTED].[REDACTED].init;

import com.[REDACTED].[REDACTED].[REDACTED]; //Main File for the ModName.MODID so its colored and styled
import net.minecraftforge.registries.ObjectHolder;

@ObjectHolder([REDACTED].MODID)
public class ModItems {
	public static final Item EXAMPLE_ITEM = null;
}
[FIle: MOdEventSubscriber.java]

package com.[REDACTED].[REDACTED];

import com.[REDACTED].[REDACTED].init.ModItemGroup; // for stuff to be colored and styled

import net.minecraft.item.Items;//part of this i took from another post from the same problem I had eariler since I know nothing for inports and just barley started to understand gradle errors
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.registries.IForgeRegistry;
import net.minecraftforge.registries.IForgeRegistryEntry;

@Mod.EventBusSubscriber(modid = [REDACTED].MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public final class ModEventSubscriber {

	@SubscribeEvent
	public static void onRegisterItems(RegistryEvent.Register<Item> event) {
		
		event.getRegistry().registerAll(
				setup(new Item(new Item.Properties().group(ModItemGroup.MOD_ITEM_GROUP)), "mega_cookie")
		);
	}

	public static <T extends IForgeRegistryEntry<T>> T setup(final T entry, final String name) {
        return setup(entry, new ResourceLocation([REDACTED].MODID, name));
	}
	public static <T extends IForgeRegistryEntry<T>> T setup(final T entry, final ResourceLocation registryName) {
        entry.setRegistryName(registryName);
        return entry;
    }


}

if anyone knows what the problem is or could give hints or something then please tell me

email is: [email protected]  [yea i know. made it when i was like 14 or something so about 4 years ago]

thanks

Posted

ok, i removed 'class' from "public static class ModItemGroup extends ItemGroup {" and now the "error:  invalid method declaration; return type required" doesn't show with "public static final ItemGroup MOD_ITEM_GROUP = new ModItemGroup(ExampleMod.MODID, () -> new ItemStack(Items.LIGHT_BLUE_BANNER));" being underlined but now im getting 

:\Users\dwzki\Desktop\minecraft mod making\mods\llamaMod\src\main\java\com\llama\llcstuff\init\ModItemGroups.java:10: error: class, interface, or enum expected
public static ModItemGroup extends ItemGroup {
              ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:12: error: class, interface, or enum expected
        private final Supplier<ItemStack> iconSupplier;
                      ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:13: error: class, interface, or enum expected
        public ModItemGroup(final String name, final Supplier<ItemStack> iconSupplier) {
               ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups. java:13: error: class, interface, or enum expected
        public ModItemGroup(final String name, final Supplier<ItemStack> iconSupplier) {
                                  ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:13: error: class, interface, or enum expected
        public ModItemGroup(final String name, final Supplier<ItemStack> iconSupplier) {
                                                     ^
C:\Users\dwzki\Desktop\minecraft mod making\mods\llamaMod\src\main\java\com\llama\llcstuff\init\ModItemGroups.java:15: error: class, interface, or enum expected
                return this.iconSupplier = iconSupplier;
                ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups. java:16: error: class, interface, or enum expected
        }
        ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:18: error: class, interface, or enum expected
        public ItemStack createIcon() {
               ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:20: error: class, interface, or enum expected
        }
        ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:21: error: class, interface, or enum expected
        public static final ItemGroup MOD_ITEM_GROUP = new ModItemGroup(LlamasMod.MODID, () -> new ItemStack(ModItems.EXAMPLE_ITEM));
                            ^
C:\Users\===\Desktop\minecraft mod making\mods\===\src\main\java\com\===\====\init\ModItemGroups.java:22: error: class, interface, or enum expected
}
^
11 errors

 

Posted

Why does your static class have a constructor?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)

so......i forgot the maker of the tutorial had a github so i looked through it....my problem was that "public static final ItemGroup MOD_ITEM_GROUP = new ModItemGroup([REDACTED].MODID, () -> new ItemStack(ModItems.EXAMPLE_ITEM));" needed to be at the top and not at the bottom.  i. atleast i know how to read gradle logs now. sorry for the trouble

Edited by llamacorn1921

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.