OpenGL GUI item rendering problem [Solved]

[TheNuclearDuck]

I'm working on my WallJump mod, and I've noticed that when you attempt to render a block onto a GUI using the following:

renderItemIntoGUI(FontRenderer par1FontRenderer, RenderEngine par2RenderEngine, ItemStack par3ItemStack, int par4, int par5)

that this sometimes messes up OpenGL colours and when you proceed to do the same again, the colour of the block is incorrect. For example, when you render an item then a block, the block will be slightly too dark, colours of things like grass will not show, etc.

 

Does anyone know why this happens, or how to fix it?

 

Here's an example of what I mean:

 

Any help is much appreciated.

[TheNuclearDuck]

Anyone? Surely somebody must be experiencesd with how OpenGL messes this up. I've tried backtracking and looking through the actual renderItem method, but to no avail... 

[hydroflame]

Hey there,

 

Anyone? Surely somebody must be experiencesd with how OpenGL messes this up.

 

Is it possible to see more your source code for the rendering/gui class? I do remember seeing something similar to this a while ago.

 

-hydroflame, author FRev-

[TheNuclearDuck]

Well, here's the loop I'm using to draw all the blocks:

        	RenderItem renderItem = new RenderItem();
        	String[] i = blocks.split(";");
        	for(int x = 0; x < i.length; x++)
        	{
        		if(i[x].contains("m"))
        		{
        			String[] z = i[x].split("m");
        			renderItem.renderItemAndEffectIntoGUI(this.fontRenderer, this.mc.renderEngine, new ItemStack(Integer.parseInt(z[0]), 1, Integer.parseInt(z[1])), this.width / 2 -75 + ((x %  * 19), this.height / 4 + 185 - 16 + ((x /  * 20));
        		} else
        		{
        			renderItem.renderItemIntoGUI(this.fontRenderer, this.mc.renderEngine, new ItemStack(Integer.parseInt(i[x]), 1, 0), this.width / 2 -75 + ((x %  * 19), this.height / 4 + 185 - 16 + ((x /  * 20));
        		}
        	}

Does this help at all?

[hydroflame]

Hey again,

 

like i said it's been a while since i have done this. But i found in the vanilla src somethign similar.

My hypothesis is that lighting is enabled and rendering a block versus an item affect it in different ways such that is screws up after rendering a item.

Unfortuntely I'm not near a place where i can work on this and find out whats Happening really but for now i can tell you this

 

Look at the class "GuiContainer" and look at the methods "drawScreen" and "drawItemStack"

 

specially these lines in "drawScreen":

RenderHelper.disableStandardItemLighting();
GL11.glDisable(GL11.GL_LIGHTING);
GL11.glDisable(GL11.GL_DEPTH_TEST);
super.drawScreen(par1, par2, par3);
RenderHelper.enableGUIStandardItemLighting();

and near the end :

GL11.glEnable(GL11.GL_LIGHTING);
GL11.glEnable(GL11.GL_DEPTH_TEST);
RenderHelper.enableStandardItemLighting();

 

it seems that notch disable the lighting when rendering items (dont forget to re-enable it after)

 

if that's not enough. May i suggest that I take a look at it later?