Jump to content

[SOLVED] Tile entities being made multiple times


Naftoreiclag

Recommended Posts

Thank you in advance for any help.

 

I'm not new to java (hobby programming in java for over a year and a half), but I'm still new to forge and how minecraft handles certain things.

 

I'm trying to make a simple tile entity, but have run into some trouble. Problem: Whenever I my block is placed or loaded, the createTileEntity() method is called an additional time. (I put a logger in the constructor of my tile entity class to tell me whenever it is created, and I get its message an additional time.)

 

I have already checked out both tutorials on the forge wiki, followed various video tutorials, and scanned through some of the source classes, but I can't figure out why my tile entity is being made multiple times.

 

Examples:

- When placing a block, I get the "created" message twice.

- When loading a world with the block already placed, I get the "read" message and the "created" message.

- When saving the world, I get the "write" message and the "created" message.

 

I have stripped the code down as much as possible to test if any of my other code was interfering, but I still get these tile entity oddities.

 

I am using the latest (as of posting) recommended build of forge. (Recommended-1.5.2 | 7.8.1.737)

 

Code exactly as I compiled it (minus the imports):

Mymod.java:

package mymodpackage;

@Mod(modid = "mymod", name = "My Mod", version = "1.0")
@NetworkMod(clientSideRequired = true, serverSideRequired = false)
public class Mymod {

public static Logger logger;

public static Block block_myblock;

@PreInit
public void preInit(FMLPreInitializationEvent event) {
	// Make a logger
	logger = Logger.getLogger("mymod");
	logger.setParent(FMLLog.getLogger());
}

@Init
public void load(FMLInitializationEvent event {
	// Block
	block_myblock = new BlockMyblock(2000, Material.rock).setUnlocalizedName("myblock");
	LanguageRegistry.addName(block_myblock, "Custom Block with Tile Entity");
	GameRegistry.registerBlock(block_myblock, "mymod.myblock");

	// Tile Entity
	GameRegistry.registerTileEntity(MyblockTileEntity.class, "mymod.myblockTileEntity");
}
}

 

BlockMyblock.java:

package mymodpackage;

public class BlockMyblock extends Block {

public BlockMyblock(int par1, Material par2Material) {
	super(par1, par2Material);
	this.setCreativeTab(CreativeTabs.tabFood);
}

@Override
public boolean hasTileEntity(int metadata) {
	return true;
}

@Override
public TileEntity createTileEntity(World world, int metadata) {
	return new MyblockTileEntity();
}
}

 

MyblockTileEntity.java:

package mymodpackage;

public class MyblockTileEntity extends TileEntity {

public MyblockTileEntity() {
	Mymod.logger.log(Level.INFO, "Created Tile Entity");
}

@Override
public void readFromNBT(NBTTagCompound par1NBTTagCompound) {
	Mymod.logger.log(Level.INFO, "readFromNBT is being called");
	super.readFromNBT(par1NBTTagCompound);
}

@Override
public void writeToNBT(NBTTagCompound par1NBTTagCompound) {
	Mymod.logger.log(Level.INFO, "writeToNBT is being called");
	super.writeToNBT(par1NBTTagCompound);
}
}

 

Could this be a forge bug in a recommended build!?

 

EDIT: It's solved now. See bottom post.

Link to comment
Share on other sites

when logging, check wich side it is and only log output from 1 side or the other

 

ex:

 

if(FMLCommonHandler.instance().getEffectiveSide().isServer){

//log here

}

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

when logging, check wich side it is and only log output from 1 side or the other

 

ex:

 

if(FMLCommonHandler.instance().getEffectiveSide().isServer){

//log here

}

 

Thanks! I guess I forgot that the code is run on both server and client...      how embarrassing

 

For future reference, here is the solution:

I was logging the messages from both the server and the client on the same "channel" of messages, which led to confusion. (I believed that it was the server creating two entities, when it was really once for the server and client each.) Here is my code for logging messages to tell whether it's server or client:

public static void sideLog(Level level, String msg) {
    if(FMLCommonHandler.instance().getEffectiveSide().isServer()) {
        logger.log(level, "Server-side: " + msg);
    }
    else if(FMLCommonHandler.instance().getEffectiveSide().isClient()) {
        logger.log(level, "Client-side: " + msg);
    }
    else {
        logger.log(level, "Unknown-side?: " + msg);
    }
}

 

Now to change the title from "unsolved" to "solved."

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.