[1.16.3] Received invalid biome id

[Budschie]

As the title suggests, my game lagged and outputted following message:

"[m[33m[21:07:58] [Render thread/WARN] [minecraft/BiomeContainer]: Received invalid biome id: -1"

So, here  is my github repo: https://github.com/Budschie/Deepnether-Mod/tree/1.16.3.

I hope you can help me with this issue.

 

-Budschie

Edited January 5, 2021 by Budschie

[Draco18s]

You have two biomes.

I only see one being registered:

https://github.com/Budschie/Deepnether-Mod/blob/1.16.3/src/main/java/de/budschie/deepnether/biomes/BiomeRegistry.java#L19

[Budschie]

@Draco18s You probably mean these lines:

BiomeDataHandler.addBiomeData(new ResourceLocation(References.MODID, "green_forest_biome"), new GreenForestBiomeData());
BiomeDataHandler.addBiomeData(new ResourceLocation(References.MODID, "deepnether"), new DeepnetherBiomeData());

But those aren't biome initalizations or anything like that, those are adding a key and data to a list.

This list is then being accessed by my chunk generator to read additional information about the biome. There is no need to register a biome named "deepnether:deepnether",

as this simply means that the netry in the second line is never used.

[Draco18s]

Nothing about that method registers the biome with the game.

https://github.com/Budschie/Deepnether-Mod/blob/1.16.3/src/main/java/de/budschie/deepnether/biomes/biome_data_handler/BiomeDataHandler.java#L13

[Budschie]

@Draco18s But shouldn't this be enough to register a biome:

https://github.com/Budschie/Deepnether-Mod/blob/1.16.3/src/main/java/de/budschie/deepnether/biomes/BiomeRegistry.java#L19

https://github.com/Budschie/Deepnether-Mod/blob/1.16.3/src/main/java/de/budschie/deepnether/main/DeepnetherMain.java#L72

Or do I have to do more to register a biome?

Edited January 7, 2021 by Budschie

[Draco18s]

39 minutes ago, Budschie said:

But shouldn't this be enough to register a biome:

Yes, that works to register a biome. Or it should, based on what little I know about biomes.

 

But it is only registering one biome ("green_forest_biome") but you have two biomes ("green_forest_biome" and "deepnether").

 

And as you did not include any more of your log than "there was an unregistered biome" I have to conclude that you attempted to reference your deepnether biome which wasn't registered.

[Budschie]

@Draco18s

But I only use one biome, which is the "green_forest_biome":

https://github.com/Budschie/Deepnether-Mod/blob/1.16.3/src/main/java/de/budschie/deepnether/dimension/DeepnetherBiomeProvider.java#L34

Edited January 8, 2021 by Budschie

[Draco18s]

Then I don't know.

[Budschie]

Me: Why do I hear boss music?

[Budschie]

Is there any good source I can refer to if I want to create(and register) a biome in 1.16.3?