How do you add loot to fishing? [1.16.5]

[Godis_apan]

Hello! I'm trying to add some more loot to fishing using GLM but I'm struggling to find a loot condition for when the player has fished something up. How would I check this to add my entry just to the fishing loot table and not all the other loot tables? Do I need a custom loot condition to check when the player has stopped fishing or something like that? Thanks.

[Draco18s]

I'd have to dig into this myself, but I'd start with finding the logic that gets the fishing loot table (probably in the fishing rod, but not sure) and check what parameters it passes in to the LootParameters object and how it calls the LootTable functions.

 

Basically check the logic and see what you can find and what sorts of discriminators you can extract from that info.

[Godis_apan]

Hmm it seems to be handled in FishingBobberEntity#handleHookRetraction where it build the loot conditions. These are not specified in the fishing.json only in code. It seems to be checking a lot of stuff: origin vector, tool type, which entity it is, the killer entity and adding a random chance.

 

I don't know how to check all these thing in the json conditions but what I got so far is:

 

  "conditions": 
  [    
    {
      "condition": "match_tool",
      "predicate": {
        "item": "minecraft:fishing_rod"
      }
    },
    {
      "condition": "minecraft:entity_properties",
      "predicate": {
        "type": "minecraft:fishing_bobber"
      },
      "entity": "this"
    }
  ]

 

Maybe it is enough?

[Draco18s]

54 minutes ago, Godis_apan said:

which entity it is,

54 minutes ago, Godis_apan said:

"condition": "minecraft:entity_properties", "predicate": { "type": "minecraft:fishing_bobber" },

 

This would work if the entity being passed is the bobber. If its the player, then it won't.

[Godis_apan]

It passes both I think?

 

.withParameter(LootParameters.KILLER_ENTITY, this.func_234616_v_()).withParameter(LootParameters.THIS_ENTITY, this)

 

[Draco18s]

Cool. Then yeah, the above looks like the right thing.

I haven't done a lot of entity based loot stuff, just piped the funcs around to call the GLM system.

[Godis_apan]

Yeah this is new to me too and I gotta say I find the fishing loot table case kind of confusing since it passes the conditions in code instead of handling it within the json. Anyways I think I'll keep experimenting with it and pass in a few more conditions in my GLM to make it more foolproof. Thanks for the help!

[Godis_apan]

Github repo for reference:

 

json: https://github.com/Phrille/Vanilla-Boom/blob/master/src/main/resources/data/vanillaboom/loot_modifiers/fishing.json

GLM class: https://github.com/Phrille/Vanilla-Boom/blob/master/src/main/java/phrille/vanillaboom/loot/LootTableHandler.java