[1.16.5] Make an ItemGroup icon with glint effect

[Dakuro]

Hey guys !

I created an ItemGroup for my mod, which works well, but I would like to have a glint effect (like an enchanted item) on the icon of my ItemGroup.
In fact, the item I use to make my icon doesn't have a glint effect (because I don't want it), so I'm searching a way to add the glint effect only to the icon and not directly to the item.

I tried to use the hasEffect() thing in many different ways that seemed logic to me, without sucess.
Here's my actual code :

 

package net.dakuro.arkhesys.utils;

import net.dakuro.arkhesys.init.ModItems;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;

import java.util.function.Supplier;

public class ModItemGroups extends ItemGroup{

    public Supplier<ItemStack> displayStack;

    public static final ModItemGroups ARKHESYS_TAB = new ModItemGroups("arkhesys_tab", () -> new ItemStack(ModItems.CHAOS_GEM.get()));

    public ModItemGroups(String label, Supplier<ItemStack> displayStack) {
        super(label);
        this.displayStack = displayStack;
    }

    public boolean hasEffect() {
        return true;
    }

    @Override
    public ItemStack createIcon()
    {
        return displayStack.get();
    }

}

 

Thank you in advance for any answer

Edited February 4, 2021 by Dakuro

[Draco18s]

8 minutes ago, Dakuro said:

    public boolean hasEffect() {
        return true;
    }

You didn't put @Override on this method, and I suspect the reason you did, is because it doesn't override a method in the super class.

Which means that this method is not being called, and you are expecting that it does, for Magic Reasons.

 

You need the displayStack to be enchanted.

[Dakuro]

1 hour ago, Draco18s said:

You didn't put @Override on this method, and I suspect the reason you did, is because it doesn't override a method in the super class.

Which means that this method is not being called, and you are expecting that it does, for Magic Reasons.

 

You need the displayStack to be enchanted.

Yes and I tried creating a super but I can't manage to do it without getting errors.

I also tried to enchant displayStack using this :

displayStack.get().addEnchantment(Enchantments.INFINITY,1);

but I can't figure out how to place it, because wherever I tried to place it, it resulted in not working or failing to load the game.

 

How would you properly enchant displayStack ?

[Draco18s]

1 hour ago, Dakuro said:

Yes and I tried creating a super but I can't manage to do it without getting errors.

Right, because hasEffect() is an Item method, not a ItemGroup method. @Override is not valid here. Remove the method, it is doing nothing.

 

1 hour ago, Dakuro said:

How would you properly enchant displayStack ?

How about enchanting the itemstack stored in the Supplier, rather than getting it out of the supplier and enchanting the result, and dropping it on the floor?