[SOLVED] I need help at making a tooltip for 1.16.5

[Geilomaticer]

This is my code:

package com.Geilomaticer.Geilomaticers.items;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.util.text.TranslationTextComponent;
import net.minecraft.world.World;
import java.util.List;

public class ender_staff {



    public void addInformation(ItemStack itemstack, World world, List<ITextComponent> list,
        ITooltipFlag flag) {
        super.addInformation(itemstack, world, list, flag);
        if (Screen.hasShiftDown() || Screen.hasControlDown()) {
            list.add(new StringTextComponent("Shifted and Controlled Tooltip"));
        } else {
            list.add(new TranslationTextComponent("tooltip.ender_staff.geilomaticers.staff_tooltip"));
        }
    }
}

I'm new to forge and programming so i don't know what to fix i just watched a tutorial and looked in a forum trying to match the code but still didn't help.

[Luis_ST]

  On 4/3/2021 at 11:43 AM, Geilomaticer said:

I'm new to forge and programming so i don't know what to fix i just watched a tutorial and looked in a forum trying to match the code but still didn't help.

Expand  

is this complete code of your item class?
if so, then an important part is missing

[Geilomaticer]

Yes, I removed some parts to see if it would help.

 

 

Edited April 3, 2021 by Geilomaticer

[Luis_ST]

  On 4/3/2021 at 2:31 PM, Geilomaticer said:

Yes, I removed some parts to see if it would help.

Expand  

can you post the complet class
would be helpful

[Geilomaticer]

That's the complete class, I removed code in the class to see if it would then work.

 

Edited April 3, 2021 by Geilomaticer

[Luis_ST]

  On 4/3/2021 at 2:54 PM, Geilomaticer said:

thats the complete class

Expand  

if the class posted above is your complete class, it is clear that it is not working

your class has to expand the item class
in this class is the method that you have to overwrite (Item#addInformation)

 

And Please follow Java naming conventions.

[Geilomaticer]

Can you show me how that would look i need to visualize it to know what to do. 

[Luis_ST]

  On 4/3/2021 at 3:09 PM, Geilomaticer said:

Can you show me how that would look i need to visualize it to know what to do.

Expand  

do you know java?
Expanding a class is one of the basics

look here for a example:
https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/src/main/java/net/luis/cave/common/item/FungusSoup.java

[Geilomaticer]

Like i said I'm new to the Development side of Forge and programming in general, so I don't really know Java

Edited April 3, 2021 by Geilomaticer

[Luis_ST]

  On 4/3/2021 at 3:30 PM, Geilomaticer said:

Like i said I'm new to the Development side of Forge and programming in general, so I don't really know Java

Expand  

"Help with modding goes in here, however, please keep in mind that this is not a Java school. You are expected to have basic knowledge of Java before posting here."

Edit (after reading the post of @Soft-fur dragon: if you want to start with the moding read the forge doc

Edited April 3, 2021 by Luis_ST

[Soft-fur dragon]

You have to change your class declaration to "public class ender_staff extends Item"
You also have to register your item. I'm not sure if you do it, since your class had wrong signature and you just won't be able to register item that looks like in first post
I also understand that you may want to hide you code for personal purposes (I'm not judging you), but if you want to get help then you should know that people here are not telepaths

[Soft-fur dragon]

For me your addInformation implementation works fine, which means that mistake is inside your hidden part

[Geilomaticer]

Well, if you want to see all the code main class:

package com.Geilomaticer.Geilomaticers;

import com.Geilomaticer.Geilomaticers.init.Iteminit;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

@Mod(Geilomaticer.MOD_ID)
public class Geilomaticer {
    public static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "geilomaticers";
    public static final ItemGroup M_GROUP = new MGroup("geilomaticerstab");

    public Geilomaticer() {
        final IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
        bus.addListener(this::setup);

        Iteminit.ITEMS.register(bus);

        MinecraftForge.EVENT_BUS.register(this);
    }

    private void setup(final FMLCommonSetupEvent event) {

    }

    public static class MGroup extends ItemGroup {

        public MGroup(String label) {
            super(label);
        }

        @Override
        public ItemStack makeIcon() {
            return Iteminit.TELE_STICK.get().getDefaultInstance();
        }
    }
}

register class:

package com.Geilomaticer.Geilomaticers.init;

import com.Geilomaticer.Geilomaticers.Geilomaticer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

import java.rmi.registry.Registry;

public class Iteminit {
    public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS,
            Geilomaticer.MOD_ID);

    public static final RegistryObject<Item> TELE_STICK = ITEMS.register("ender_staff",
            () -> new Item(new Item.Properties().tab(Geilomaticer.M_GROUP)));
}

and the Item one:

package com.Geilomaticer.Geilomaticers.items;

        import net.minecraft.client.Minecraft;
        import net.minecraft.client.gui.screen.Screen;
        import net.minecraft.client.util.ITooltipFlag;
        import net.minecraft.item.Item;
        import net.minecraft.item.ItemStack;
        import net.minecraft.util.text.ITextComponent;
        import net.minecraft.util.text.StringTextComponent;
        import net.minecraft.util.text.TranslationTextComponent;
        import net.minecraft.world.World;
        import java.util.List;

public class ender_staff extends item{



    public void addInformation(ItemStack itemstack, World world, List<ITextComponent> list,
                               ITooltipFlag flag) {
        super.addInformation(itemstack, world, list, flag);
        if (Screen.hasShiftDown() || Screen.hasControlDown()) {
            list.add(new StringTextComponent("Shifted and Controlled Tooltip"));
        } else {
            list.add(new TranslationTextComponent("tooltip.ender_staff.geilomaticers.staff_tooltip"));
        }
    }
}

those are all the classes I have.

[Soft-fur dragon]

ok, thx. Well, I see some things that confuses me. First of all, try to add "@Override" right above "public void addInformation..."

Next, your class should extend Item, not item. For compiler they are two different classes. Does it compile, actually?

Also I don't see the constructor for your staff. You should add

	public ender_staff(Properties properties) {
		super(properties);
	}

right between "public class ender_staff extends Item {" and added "@Override"

Edited April 3, 2021 by Soft-fur dragon

[Luis_ST]

  On 4/3/2021 at 4:41 PM, Geilomaticer said:

those are all the classes I have.

Expand  

your code looks good only that your item class does not contain a constructor,
and your item that you register creates a normal item and not your "ender_staff" item

[Soft-fur dragon]

public static final RegistryObject<Item> TELE_STICK = ITEMS.register("ender_staff",
            () -> new Item(new Item.Properties().tab(Geilomaticer.M_GROUP)));

should be replaced with

public static final RegistryObject<ender_staff> TELE_STICK = ITEMS.register("ender_staff",
            () -> new ender_staff(new Item.Properties().tab(Geilomaticer.M_GROUP)));

 

[Geilomaticer]

Still doesn't work.

[Soft-fur dragon]

Do you have compiler errors or game runs and you just don't see modified tooltip? Also question, do you see your item in game at all?

Edited April 3, 2021 by Soft-fur dragon

[Geilomaticer]

In the console it says 7 errors:

error: cannot find symbol
    public static final RegistryObject<ender_staff> TELE_STICK = ITEMS.register("ender_staff",

error: cannot find symbol
public class ender_staff extends item{

error: cannot find symbol
        Iteminit.ITEMS.register(bus);

error: cannot find symbol
    public static final RegistryObject<ender_staff> TELE_STICK = ITEMS.register("ender_staff",

error: cannot find symbol
            () -> new ender_staff(new Item.Properties().tab(Geilomaticer.M_GROUP)));
 

error: cannot find symbol
    public static final RegistryObject<Item> TELE_STICK = ITEMS.register("ender_staff",

error: cannot find symbol
        super.addInformation(itemstack, world, list, flag);
 

[Luis_ST]

  On 4/3/2021 at 5:38 PM, Geilomaticer said:

In the console it says 7 errors:

Expand  

post the log

[Soft-fur dragon]

Add " import com.Geilomaticer.Geilomaticers.items.ender_staff;" near other imports in your register class file

[Geilomaticer]

I can see the item in the game and the custom tab etc, but after that tooltip I couldn't launch it.

after the import and the @Override it got more errors.

Edited April 3, 2021 by Geilomaticer

[Soft-fur dragon]

Can we see the log?

[Geilomaticer]

How do I show it?

 

[Soft-fur dragon]

The console. The place where you found these 7 errors 🙂
Copy it's output. This is the log

P.S. of course, compile the code first 😁

Edited April 3, 2021 by Soft-fur dragon