Jump to content

Recommended Posts

Posted

So I made an extension off the default minecraft glass block and it doesnt become transparent. Im updating my mod from 1.12.2 to 1.16.5 so I'm not too sure how I can do the transparencys I have. One block I have it where the textures dont connect, and another block I have it like ice

Heres the code (1.16) that doesnt make my glass block transparent. I'm tackling the easier issue first; the glass with connecting textures

	public static final RegistryObject<Block> BERYLGLASS = BLOCKS.register("beryl_glass", () -> new ModGlassBlock(AbstractBlock.Properties.of(Material.LEAVES).strength(0.3F).sound(SoundType.GLASS).noOcclusion().harvestTool(ToolType.PICKAXE).harvestLevel(1)));

And the glass block glass

public class ModGlassBlock extends GlassBlock{

	   public ModGlassBlock(AbstractBlock.Properties p_i48392_1_) {
		      super(p_i48392_1_);
	   }
}

The transparent textures appear solid. If someone could help that'd be great!

Posted
4 hours ago, djofox said:

Heres the code (1.16) that doesnt make my glass block transparent. I'm tackling the easier issue first; the glass with connecting textures

I'm not sure what you mean by connecting the texture, but try to add notSolid to the block properties
and add a RenderTypeLookup to the block

Posted (edited)
13 minutes ago, Luis_ST said:

I'm not sure what you mean by connecting the texture, but try to add notSolid to the block properties
and add a RenderTypeLookup to the block

Still nothing

public class ModGlassBlock extends GlassBlock{

	   public ModGlassBlock(AbstractBlock.Properties p_i48392_1_) {
		      super(p_i48392_1_);
	   }
	   public boolean isOpaqueCube() {
		   return false;
	   }
	   public boolean notSolid() {
		   return true;
	   }
}

2021-04-14_22_38_58.thumb.png.c8f5ad0299aee28a3de0799ae75c0ea8.png

Edited by djofox
Posted (edited)

You will want to put this line in during the client setup event: 

RenderTypeLookup.setRenderLayer(BERYLGLASS, RenderType.getCutout());

EDIT: Actually you'll probably want to use getTranslucent instead:

RenderTypeLookup.setRenderLayer(BERYLGLASS, RenderType.getTranslucent());

That will cause a translucent effect similar to ice. The one I mentioned previously is just for non-translucents like glass.

Edited by VulpTheHorseDog
Edited because of inaccurate info.
Posted (edited)
public class ModGlassBlock extends GlassBlock{

	   public ModGlassBlock(AbstractBlock.Properties p_i48392_1_) {
		      super(p_i48392_1_);
	   }
	   public boolean isOpaqueCube() {
		   return false;
	   }
	   public boolean notSolid() {
		   return true;
	   }
}

this will not work because Block or GlassBlock does not contain any of these methods

and I said add this (notSolid) to the block properties so to the following

public static final RegistryObject<Block> BERYLGLASS = BLOCKS.register("beryl_glass", 
       () ->newModGlassBlock(AbstractBlock.Properties.of(Material.LEAVES).strength(0.3F).sound(SoundType.GLASS)
                             .noOcclusion().harvestTool(ToolType.PICKAXE).harvestLevel(1)));

 

Edit: if I see that correctly you are using the latest Forge version (the one with the Mojang mappings),
which means notSolid is now called noOcclusion (I'm not 100% sure -> it could also be called differently)

Edited by Luis_ST
Posted

Yes thank you it works now! I had noOcclusion before, but it didnt do anything. It was that I had to register the client side render.

I think forge has one of their things broken though, .cutout() doesnt work nor does .cutoutMipped, but  .translucent() does

 

Heres my code to see if I just did something wrong

	private void setup(final FMLCommonSetupEvent event) {
		RenderTypeLookup.setRenderLayer(BlockInit.BERYLGLASS.get(), RenderType.cutout());
		RenderTypeLookup.setRenderLayer(BlockInit.BERYLBLOCK.get(), RenderType.cutoutMipped());
		RenderTypeLookup.setRenderLayer(BlockInit.TREATEDCARBIDEBLOCK.get(), RenderType.translucent());
	}

and when I do this only the treated carbide block will appear translucent. When i have them all translucent and I place them beside eachother they look pretty weird, so if theres a fix for this that'd be great.

Posted
12 hours ago, djofox said:

Heres my code to see if I just did something wrong

use the FMLClientSetupEvent and not the FMLCommonSetupEvent

 

12 hours ago, djofox said:

and when I do this only the treated carbide block will appear translucent.

set all RenderLayer to translucent (not cutout or cutoutMipped)

Posted (edited)
On 4/16/2021 at 3:03 AM, djofox said:

Yes thank you it works now! I had noOcclusion before, but it didnt do anything. It was that I had to register the client side render.

I think forge has one of their things broken though, .cutout() doesnt work nor does .cutoutMipped, but  .translucent() does

 

Heres my code to see if I just did something wrong



	private void setup(final FMLCommonSetupEvent event) {
		RenderTypeLookup.setRenderLayer(BlockInit.BERYLGLASS.get(), RenderType.cutout());
		RenderTypeLookup.setRenderLayer(BlockInit.BERYLBLOCK.get(), RenderType.cutoutMipped());
		RenderTypeLookup.setRenderLayer(BlockInit.TREATEDCARBIDEBLOCK.get(), RenderType.translucent());
	}

and when I do this only the treated carbide block will appear translucent. When i have them all translucent and I place them beside eachother they look pretty weird, so if theres a fix for this that'd be great.

You seem to have skipped over the entire part where I listed that it was RenderType.getCutout(). Not cutout or cutoutMipped. Also like Luis_ST mentioned and I mentioned earlier, use the client setup event. Also there's no easy fix to them looking weird next to each other using the translucent render type. An example would be great though.

Edited by VulpTheHorseDog
  • 2 weeks later...
Posted

Hello, I'm having a similar problem to the one described in this thread, but none of the advice here is helping me. I'm using the most recent version of Forge for 1.16.5. I've scanned dozens of old threads looking for answers, but the current version of Forge is apparently very different, and the old solutions I've come across are no longer applicable.

 I have a block which I have given the translucent RenderType in the same way as the original post:

private void clientSetup(final FMLClientSetupEvent event) {
        RenderTypeLookup.setRenderLayer(BlockList.CRYSTAL.get(), RenderType.translucent());
}

The above code does give the desired effect of making the block translucent, but it comes with undesirable side-effects that I am unable to resolve, which I will try to explain.

 

In my BlockList class, I initialize my block with this line of code:

public static final RegistryObject<Block> CRYSTAL = BLOCKS.register("crystal", () -> new Crystal(Block.Properties
		.of(Material.ICE)));

which produces the in-game result:

https://i.imgur.com/wuq6wf6.png

The block allows light through, but it culls the faces of adjacent opaque blocks, which I do not want it to.

 

Modifying the previous code to add the noOcclusion() property:

public static final RegistryObject<Block> CRYSTAL = BLOCKS.register("crystal", () -> new Crystal(Block.Properties
		.of(Material.ICE)
		.noOcclusion()));

results in a different undesired outcome:

https://i.imgur.com/6qTtCBr.png

The block is still translucent, but it renders faces between like blocks. It does not, however, suffer from the same culling issue as without the property.

 

Does anyone know how I might resolve this issue? Any help would be appreciated.

Posted
1 hour ago, PopularGoat said:

The block is still translucent, but it renders faces between like blocks. It does not, however, suffer from the same culling issue as without the property.

your block needs to expand BreakableBlock

 

Posted
8 hours ago, Luis_ST said:

your block needs to expand BreakableBlock

 

Woah! That worked! Extending BreakableBlock in the block's class file and adding the noOcclusion property worked. Thank you!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.