[1.7.2] - [Solved] Lightning always spawning underneath the player

Hi, I am working on a item that when right clicking should spawn a lightning at the coordinate the crosshair is pointing at. Therefore I am using the trayrace(300, 1) method, but when I am standing on the ground and aiming at a block a few blocks away all I get is the coordinates of where I am standing. Why is that?

Here is my code:

public class ItemTalisman extends ItemPC {

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

	if (world.isRemote) {

		return itemStack;
	}

	if (ExtendedPlayer.get(player).getCulture() >= 100) {

		ExtendedPlayer.get(player).consumeCulture(100);

		// player.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 2400, 0, false));

		MovingObjectPosition objectMouseOver;

		objectMouseOver = player.rayTrace(300, 1);

		if (objectMouseOver != null && objectMouseOver.typeOfHit == MovingObjectType.BLOCK) {

			double i = objectMouseOver.blockX;
			double j = objectMouseOver.blockY;
			double k = objectMouseOver.blockZ;
			world.addWeatherEffect(new EntityLightningBolt(world, i, j, k));
			System.out.println("Spawning at: " + i + ", " + j + ", " + k);
		}

	} else {

		player.addChatComponentMessage(new ChatComponentText("You don't have enough culture."));
		ExtendedPlayer.get(player).setCulture(100);
	}

	return itemStack;
}
}

Take a look at how I do it here.  Class is kind of a mess, but you're looking for packet ID 5 (ctrl-f "case 5") there's also a comment that says "lightning"

It's not the greatest thing in the world, but it might help you.

I tried to use it, but it worked just as it did before. If you aim high enough it works, if it's too low on the terrain (and yes there are no grass in front of me) the lightning strikes at the player coords. The only way to make it work is to fly when using the item. If you do that it becomes accurate both with the way you are doing it as well as the way I did it.

Anyone that can help me with this problem? Is there a bug with forge or Minecraft or something like that?

Hi

I have a vague memory that the player position on the server is not the same as on the client - the client player position is the player's eyes, but the server player position is the player's feet.  This should be easy to check in your code - just print the

        Vec3 vec3 = player.getPosition(par3);

eg

	public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

Vec3 vec3 = player.getPosition(1);
System.out.println((world.isRemote ? "client y=" : "server y =") + vec3.yCoord);

	if (world.isRemote) {

		return itemStack;
	}

-TGG

Try:

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer Entityplayer) {

Vec3 look = Entityplayer.getLookVec();
MovingObjectPosition Coord = Entityplayer.rayTrace(300, 1);
if(Coord != null && Coord.typeOfHit == EnumMovingObjectType.TILE){
         EntityLightningBolt Lightning = new EntityLightningBolt(world, 1, 1, 1);
         Lightning.setPosition(Coord.blockX,Coord.blockY,Coord.blockZ);
         world.spawnEntityInWorld(Lightning);
  }
return itemStack;

}

It works for me...

Hi

 

I have a vague memory that the player position on the server is not the same as on the client - the client player position is the player's eyes, but the server player position is the player's feet.  This should be easy to check in your code - just print the

        Vec3 vec3 = player.getPosition(par3);

 

eg

	public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

Vec3 vec3 = player.getPosition(1);
System.out.println((world.isRemote ? "client y=" : "server y =") + vec3.yCoord);

	if (world.isRemote) {

		return itemStack;
	}

-TGG

Here is the code that worked:

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

if (!world.isRemote) {

	return itemStack;
}

if (ExtendedPlayer.get(player).getCulture() >= 100) {

	ExtendedPlayer.get(player).consumeCulture(100);

	MovingObjectPosition objectMouseOver;
	Minecraft mc = Minecraft.getMinecraft();

	objectMouseOver = mc.thePlayer.rayTrace(300, 1);

	if (objectMouseOver != null && objectMouseOver.typeOfHit == MovingObjectType.BLOCK) {

		int i = objectMouseOver.blockX;
		int j = objectMouseOver.blockY;
		int k = objectMouseOver.blockZ;
		world.spawnEntityInWorld(new EntityLightningBolt(world, i, j, k));
		player.addChatComponentMessage(new ChatComponentText("Pew! X: " + i + ", Y: " + j + ", Z: " + k));
	}

} else {

	player.addChatComponentMessage(new ChatComponentText("You don't have enough culture."));
	ExtendedPlayer.get(player).setCulture(100);
}

return itemStack;
}

Not working for me, where did ExtendedPlayer come from?

EDIT: Never mind; with a little tweaking, Millennium3's code works.

Not working for me, where did ExtendedPlayer come from?

 

EDIT: Never mind; with a little tweaking, Millennium3's code works.

Not working for me, where did ExtendedPlayer come from?

 

EDIT: Never mind; with a little tweaking, Millennium3's code works.

I'm trying to accomplish something very similar, if not the exact same thing, with spawning lightning. I've tweaked Millennium3's code, but I might have accidentally a statement  . Do you think you could show your "fixed" code, as something to reference? It would be greatly appreciated!!!

Just to point out, EntityLivingBase#rayTrace and EntityLivingBase#getPosition are both CLIENT only methods - you will crash if you run your code in multiplayer.

See this post for more information on getting the coordinates the player is looking at.