Leaderboard

You're using the spawn event improperly. Many events are "parent" events that actually fire multiple times for more specific subevents. In this case, the actual events are AllowDespawn, CheckSpawn, and CheckSpecialSpawn. So for example, the AllowDespawn is being regularly fired for all squids as they age in the world. I think you should use the CheckSpawn or perhaps the EntityJoinWorld events.

No. Because you're bypassing the block-break system in PlayerInteraction.java

Also, although it is good to think about performance the reality is that modern computers are getting faster and faster and a performance problem is only going to arise if you have a lot of something (or if you have big, recursive loops in your code, like scanning over lots of locations for something). In programming it is usually recommended to do things the "proper" way first -- meaning the typical, expected and readable way -- since that usually avoids introducing new bugs and makes it more easy to maintain. Then you should profile your code and see if there are any areas of undue performance burden and the rewrite those if needed. In other words, beds, chests, signs and other common minecraft stuff already use TESRs, so unless you expect to have a lot of your structures in the game then it shouldn't be much worse. Lastly, I hope that each version of minecraft gets performance improvements. I know sometimes they go backwards -- I remember that 1.8 had a bunch of lag issues -- but generally would expect it to get better. For example, maybe TESRs are more efficient in 1.12.1. Only way to know is to profile. Yes it is good to consider performance, but if you're going to go to coremods without even knowing how bad the performance is I suggest that you do more testing first.

I fixed my issue lol, in the assets, you need to create packages, not file

This PR would have allowed you to control the movement speed while the item was in use, but the author hasn't responded for a while. If you were to update it, it may be merged for 1.12.1 and possibly 1.11.2.