Help with standardizing recipes

[skip999]

Hello,

I am attempting to standardize some recipe types for a mod that I am working on improving. To keep a long story short, I am attempting to unify it's recipe system and ultimately integrate it into the Forge system**. However, this has lead me to an interesting predicament. Currently, I have three separate recipe classes that I am attempting to set up. They all take the same shape in their JSON file, but are for 3 separate machines. As a result, I would like to use the same Serializer for all three since they all use the same read and write methods. I attempted to use wildcards to solve the Class type specification that RecipeSerializers have, but it results in the following error when I attempt to load a world:

 

java.util.concurrent.ExecutionException: java.lang.NullPointerException: null key in entry

 

The most I am able to find online about this issue is about general HashMaps, but nothing in relation to Forge. Currently I am just trying to get the Serializer to work so I can get the others ready as well.

 

I have attached a link to the recipe JSONs as well as the location of the Recipe Classes on Github. I have also attached the full log regarding the crash. Any and all help would be appreciated

 

Recipe JSONS: https://github.com/skiprocks999/ElectrodynamcisExperimental/tree/main/src/main/resources/data/electrodynamics/recipes/o2o

Recipe Classes*: https://github.com/skiprocks999/ElectrodynamcisExperimental/tree/main/src/main/java/electrodynamics/common/recipe

 

*Please ignore the "MachineRecipes" and "RecipeManager" classes. These are part of the existing recipe system for the mod and are having no effect on the problem.

**Don't ask me why it was written the way it is to start with; I don't know either.

 

latest.log

[Draco18s]

As far as I can tell, your recipe serializer class isn't.

That is, it's called a "recipe serializer", but it doesn't actually perform the required functions. Namely having the Read and Write methods defined by IRecipeSerializer to actually serialize and deserialize to/from json.

[skip999]

I suppose I should change the name of "ElectrodynamicsRecipeSerializer" to something else; that's a bad choice on my part. Did you look at this class here:

https://github.com/skiprocks999/ElectrodynamcisExperimental/blob/main/src/main/java/electrodynamics/common/recipe/categories/o2o/O2ORecipeSerializer.java

 

[Draco18s]

Ah, there it is. I was having trouble tracing my way through your code to the right class.

 

This may be your problem:
https://github.com/skiprocks999/ElectrodynamcisExperimental/blob/3170c78e673ea81faf0e83d0d8d5b56862607965/src/main/java/electrodynamics/common/recipe/categories/o2o/O2ORecipe.java#L42-L45

[skip999]

Okay so I realized the issue there: I was trying to downcast in Java like a moron. I have solved this issue, and I am still getting the error in the log. I have confirmed that the recipes are being read properly by the serializer, and that the correct Recipe types are being created. However, the same error is still being thrown, and I don't know why. I have attached the latest log, and I have provided links to the relevant classes.

 

Recipe Serializer Init : https://github.com/skiprocks999/ElectrodynamcisExperimental/blob/main/src/main/java/electrodynamics/common/recipe/ElectrodynamicsRecipeSerializer.java

Recipe Serializer: https://github.com/skiprocks999/ElectrodynamcisExperimental/blob/main/src/main/java/electrodynamics/common/recipe/categories/o2o/O2ORecipeSerializer.java

Recipe Categories: https://github.com/skiprocks999/ElectrodynamcisExperimental/tree/main/src/main/java/electrodynamics/common/recipe/categories/o2o/specificmachines

Ignore the same two classes as before. The JSON files haven't moved, but for the sake of ease of access, can be found here:

https://github.com/skiprocks999/ElectrodynamcisExperimental/tree/main/src/main/resources/data/electrodynamics/recipes/o2o

 

latest.log

[skip999]

Okay so I did some digging and finally found this forum post here:

I have fixed the issue and now my recipes are compiling. Thanks for the help none the less!