[1.16.5] TileEntityRenderer not accessing TileEntity inventory

[bibouche_]

Hi, so the thing is that I have a TileEntity for which I added a TileEntityRenderer, I already did this with two other TileEntities but this time it was not working and I found out that the Renderer class cannot reach TileEntity inventory, since when I have an ItemStack in a slot, it outputs Air. And also, my two other TileEntities uses ISidedInventory (which I know shouldn't be used but I will change this later), and this one uses IItemHandler. I don't know if it is what causes the issue or if I am networking bad or even if I am missing something, can someone help me please ?

 

TileEntityRenderer :

public class CelestialPowerPedestalTileEntityRenderer extends TileEntityRenderer<CelestialPowerPedestalTileEntity> {

	private Minecraft mc  = Minecraft.getInstance();

	public CelestialPowerPedestalTileEntityRenderer(
		TileEntityRendererDispatcher rendererDispatcherIn) {
		super(rendererDispatcherIn);
	}

	@Override
	public void render(
		CelestialPowerPedestalTileEntity te,
		float partialTicks,
		MatrixStack matrixStackIn,
		IRenderTypeBuffer bufferIn,
		int combinedLightIn,
		int combinedOverlayIn) {

		int lightLevel = getLightLevel(te.getWorld(), te.getPos());

		if (!te.isFillable()) {

			renderItem(te.inv.getStackInSlot(0), new double[] {0.48d, 0.83d, 0.42d},
			           90, 0, 0, matrixStackIn, bufferIn, partialTicks, combinedOverlayIn, lightLevel, 1.0f);

		}
	}

	private void renderItem(
		ItemStack stack, double[] translation, int rotX, int rotY, int rotZ, MatrixStack matrixStack, IRenderTypeBuffer buffer, float partialTicks, int combinedOverlay, int lightLevel, float scale) {

		matrixStack.push();
		matrixStack.translate(translation[0], translation[1], translation[2]);
		matrixStack.rotate(Vector3f.XP.rotationDegrees((float) rotX));
		matrixStack.rotate(Vector3f.YP.rotationDegrees((float) rotY));
		matrixStack.rotate(Vector3f.ZP.rotationDegrees((float) rotZ));
		matrixStack.scale(scale, scale, scale);

		IBakedModel model = mc.getItemRenderer().getItemModelWithOverrides(stack, null, null);
		mc.getItemRenderer().renderItem(stack,
		                                ItemCameraTransforms.TransformType.GROUND, true, matrixStack, buffer, lightLevel, combinedOverlay, model);
		matrixStack.pop();

	}

	private int getLightLevel(
		World world, BlockPos pos) {
		int blockLight = world.getLightFor(LightType.BLOCK, pos);
		int skyLight = world.getLightFor(LightType.SKY, pos);
		return LightTexture.packLight(blockLight, skyLight);
	}

}

TileEntity networking and writing :

public void read(
		BlockState state,
		CompoundNBT nbt) {
		super.read(
			state,
			nbt);

		NonNullList <ItemStack> inv = NonNullList.withSize(
			this.inv.getSlots(),
			ItemStack.EMPTY);
		ItemStackHelper.loadAllItems(
			nbt,
			inv);
		setItems(inv);
	}

	@Nonnull
	@Override
	public CompoundNBT write(
		CompoundNBT compound) {
		super.write(compound);

		ItemStackHelper.saveAllItems(
			compound,
			this.getItems());

		return compound;
	}

	@Nullable
	@Override
	public SUpdateTileEntityPacket getUpdatePacket() {
		CompoundNBT nbt = new CompoundNBT();
		this.write(nbt);
		return new SUpdateTileEntityPacket(
			this.pos,
			0,
			nbt);
	}

	@Override
	public void onDataPacket(
		NetworkManager net,
		SUpdateTileEntityPacket pkt) {
		this.read(
			world.getBlockState(pkt.getPos()),
			pkt.getNbtCompound());
	}

	@Override
	public CompoundNBT getUpdateTag() {
		CompoundNBT nbt = new CompoundNBT();
		this.write(nbt);
		return nbt;
	}

	@Override
	public void handleUpdateTag(
		BlockState state,
		CompoundNBT tag) {
		this.read(state, tag);
	}

 

[bibouche_]

May someone help please ? I am still working on it, I don't know what is causing it.

[bibouche_]

https://pastebin.com/YrCCHv8N

[bibouche_]

Yeah I know I want to change my code formatter but I didn't do it yet XD

Ok so I juste have to delete my getItems and read and write ?

[Luis_ST]

why do you use IItemHandler as inventory?
Edit: use ItemStackHandler instead, reason:

you use Capability#getDefaultInstance to get an IItemHandler,
why don't you use a new ItemStackHandler that contains the methods serializeNBT and deserializeNBT
which you can execute in read and write the TE, wich is very simple

Edited July 20, 2021 by Luis_ST

[bibouche_]

55 minutes ago, diesieben07 said:

That is not at all what I said.

Yes, delete getItems, but use the proper alternative, don't just remove read and write.

Ok so I came up with this : https://pastebin.com/L01ZkFj2, however I think I did something wrong since it did not fixed it, for the Direction I put Direction#NORT but I don't know if it is ok to put a fixed direction like this.

 

49 minutes ago, Luis_ST said:

why do you use IItemHandler as inventory?
Edit: use ItemStackHandler instead, reason:

you use Capability#getDefaultInstance to get an IItemHandler,
why don't you use a new ItemStackHandler that contains the methods serializeNBT and deserializeNBT
which you can execute in read and write the TE, wich is very simple

I use the default instance since it creates a new IItemHandler with just one slot and it is to avoid creating more instances and classes

[Luis_ST]

22 minutes ago, bibouche_ said:

Ok so I came up with this : https://pastebin.com/L01ZkFj2, however I think I did something wrong since it did not fixed it, for the Direction I put Direction#NORT but I don't know if it is ok to put a fixed direction like this.

you can use null

22 minutes ago, bibouche_ said:

I use the default instance since it creates a new IItemHandler with just one slot and it is to avoid creating more instances and classes

Capability#getDefaultInstance do the same as the ItemStackHandler#new
and if you use an ItemStackHandler as I explained above, your error would simply be fixed
this is the simplest solution for your problem:
https://pastebin.com/ntZssi9b

Edit: another issue in your code, you call the write inside the getUpdatePacket method of your TE

Edited July 20, 2021 by Luis_ST

[bibouche_]

19 minutes ago, Luis_ST said:

you can use null

 

Capability#getDefaultInstance do the same as the ItemStackHandler#new
and if you use an ItemStackHandler as I explained above, your error would simply be fixed
this is the simplest solution for your problem:
https://pastebin.com/ntZssi9b

Ok but I tried it and I keep having the same issue, I really don't see what is causing this

[Luis_ST]

25 minutes ago, Luis_ST said:

Edit: another issue in your code, you call the write inside the getUpdatePacket method of your TE

also this

[bibouche_]

56 minutes ago, Luis_ST said:

Edit: another issue in your code, you call the write inside the getUpdatePacket method of your TE

Yes, because I want it to write the data in the tileEntity on block update

[Luis_ST]

10 hours ago, bibouche_ said:

Yes, because I want it to write the data in the tileEntity on block update

post your updated code
and take a look at some vanilla TEs,
how they synchronize the TE data with the client

[bibouche_]

1 hour ago, Luis_ST said:

post your updated code
and take a look at some vanilla TEs,
how they synchronize the TE data with the client

https://pastebin.com/DKKj7JNG

 

Yeah, I looked at some vanilla TEs, however they are using CompoundNBT, so I am a litte lost since IItemHandler uses INBT, and like the read and write methods are using CompoundNBT

[Luis_ST]

1 minute ago, bibouche_ said:

https://pastebin.com/DKKj7JNG

please post the full TE class

 

1 minute ago, bibouche_ said:

Yeah, I looked at some vanilla TEs, however they are using CompoundNBT, so I am a litte lost since IItemHandler uses INBT, and like the read and write methods are using CompoundNBT

that's basic java, INBT is an interfaces, and CompoundNBT is an implemention of INBT

[bibouche_]

https://pastebin.com/SjjXivkK

Yeah I know that, but I did not found a way yet, so I will look at it, maybe add a new CompoundNBT and use it in the functions

[Luis_ST]

1 minute ago, bibouche_ said:

https://pastebin.com/SjjXivkK

Yeah I know that, but I did not found a way yet, so I will look at it, maybe add a new CompoundNBT and use it in the functions

You're still doing what you shouldn't

 

13 hours ago, Luis_ST said:

Capability#getDefaultInstance do the same as the ItemStackHandler#new
and if you use an ItemStackHandler as I explained above, your error would simply be fixed
this is the simplest solution for your problem:
https://pastebin.com/ntZssi9b

this is optional

 

13 hours ago, Luis_ST said:

another issue in your code, you call the write inside the getUpdatePacket method of your TE

that is required

[bibouche_]

Ok so I made it use ItemStackHandler, and removed the write method from the getUpdatePacket. And it's strange because Vanilla TEs juste return null.

 

https://pastebin.com/3CuijXdR

[bibouche_]

6 hours ago, diesieben07 said:

getUpdatePacket should use getUpdateTag and onDataPacket should call handleUpdateTag.

Then getUpdateTag needs to call super, not write. Then you need to write only the data that is necessary on the client in getUpdateTag. In handleUpdateTag you then read that data.

Like so ? https://pastebin.com/FuUvqppK

[bibouche_]

Ok got it, but still the same

 

EDIT : reupload of the TE class https://pastebin.com/hsFJHsWE

Edited July 21, 2021 by bibouche_

[bibouche_]

41 minutes ago, diesieben07 said:

Well, you now need to tell the game to send the packet whenever the inventory changes.,

Oups, yeah of course, forgot that.

Yepp, got it to work, thank you  !!!!