get coordinates of the block the player looking at

[DoctorG_Mystery]

I wrote a code that, when you right-click, places a diamond block where you look, but I can't get the coordiats.

here my code:

        if(!world.isClientSide) {
            double x = player.getLookVec().xCoord;
            double y = player.getLookVec().yCoord;
            double z = player.getLookVec().zCoord;
            BlockPos blockPos = new BlockPos(x, y, z);
            world.setBlockAndUpdate(blockPos, Blocks.DIAMOND_BLOCK/*for example*/.defaultBlockState());
        }

(the getLookVec does not work)

Edited August 18, 2021 by DoctorG_Mystery

[diesieben07]

Show more of the code.

[DoctorG_Mystery]

here is all of the code in the script:

package drgmystery.darklight.item;

import drgmystery.darklight.init.DarklightItemGroups;
import net.minecraft.block.Blocks;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Rarity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class TestItem1 extends Item{
    
    public TestItem1() {
        super(new Properties().defaultDurability(20).tab(DarklightItemGroups.GROUP).rarity(Rarity.EPIC));
    }
    
    @Override
    public ActionResult<ItemStack> use(World world, PlayerEntity player, Hand hand) {
        
        if(!world.isClientSide) {
            double x = player.getLookVec().xCoord;
            double y = player.getLookVec().yCoord;
            double z = player.getLookVec().zCoord;
            BlockPos blockPos = new BlockPos(x, y, z);
            world.setBlockAndUpdate(blockPos, Blocks.DIAMOND_BLOCK.defaultBlockState());
        }
        return super.use(world, player, hand);
    }
    
}

 

Edited August 18, 2021 by DoctorG_Mystery

[diesieben07]

Use useOn, not use. It is only called when a block is right-clicked with the item and it receives the coordinates of the block that was clicked.

[DoctorG_Mystery]

If I do that, it tells me that at useOn (World world, PlayerEntity player, Hand hand) something is wrong and as a solution it suggests deleting the @Override 

the error with getLookVec() is also still there
here the code:

package drgmystery.darklight.item;

import drgmystery.darklight.init.DarklightItemGroups;
import net.minecraft.block.Blocks;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Rarity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class TestItem1 extends Item{
    
    public TestItem1() {
        super(new Properties().defaultDurability(20).tab(DarklightItemGroups.GROUP).rarity(Rarity.EPIC));
    }
    
    @Override
    public ActionResult<ItemStack> useOn(World world, PlayerEntity player, Hand hand) {
        
        if(!world.isClientSide) {
            double x = player.getLookVec().xCoord;
            double y = player.getLookVec().yCoord;
            double z = player.getLookVec().zCoord;
            BlockPos blockPos = new BlockPos(x, y, z);
            world.setBlockAndUpdate(blockPos, Blocks.DIAMOND_BLOCK.defaultBlockState());
        }
        return super.useOn(world, player, hand);
    }
    
}

 

Edited August 18, 2021 by DoctorG_Mystery

[diesieben07]

Use your IDE to override methods. You need to use the correct parameters.

This is basic Java.

[DoctorG_Mystery]

So what I have to do now?

[diesieben07]

Override useOn.

[DoctorG_Mystery]

I have use -> useOn and deleted the @Override

and whats with the getLookVec?

[diesieben07]

Just now, DoctorG_Mystery said:

I have use -> useOn and deleted the @Override

No. Override the method. Learn basic Java if you do not know what this means.

[DoctorG_Mystery]

Describe to me how i can do it, i understand the principle, but not yet how i can use it here.

[diesieben07]

Overriding a method is the same always. What exactly do you not understand?

[DoctorG_Mystery]

Overriting means somthing like transmission so you declares a methode in a class an give out if needed but how can I Overrite/declares useOn? First you mean I shoud use useOn not use so I have remove use and write useOn so there's an error and as solution I shoud remove the @Override than you said I shoud overrite the methode.

 

[diesieben07]

4 minutes ago, DoctorG_Mystery said:

Overriting means somthing like transmission so you declares a methode in a class an give out if needed but how can I Overrite/declares useOn?

What? This is not at all accurate.

https://docs.oracle.com/javase/tutorial/java/IandI/override.html

[DoctorG_Mystery]

So the key word ist extends?

[Luis_ST]

no, learn basic java, and then come back to minecraft modding

[DoctorG_Mystery]

wow I learned java and beguin moding, I hadn't any Problems, than I don't now or understand one thing I quest in a Forum so the final awnser is: "lern java" thanks

[Luis_ST]

if you don't know how to override the correct method you don't know basic java

Edited August 19, 2021 by Luis_ST

[diesieben07]

5 minutes ago, Luis_ST said:

overwrite

Override.

"Overwriting methods" is not a thing in Java.

[DoctorG_Mystery]

I see now a Video specific for overriting I think I understand now: 

I have a basic method:

public void breathe () {
           System.out.println ("puuuuuh");
            }

then I have three (or more / less) objects on which it should be executed:

animal x = new bird ();
x. breathe ();
x = new cat ();
x. breathe ();
x = new animal ();
x. breathe ();
//so the result is:
puuuuuh
puuuuuh
puuuuuh

But if you change the ...prnitln("puuuuuh"); zu ...println("pip pip"); directly in the class of bird then the master method that is in animal was overwritten.

//so here is the result:
pip pip
puuuuuh
puuuuuh

what you say to that?

Edited August 19, 2021 by DoctorG_Mystery

[diesieben07]

Well, now you should know what you need to do to override useOn.

[DoctorG_Mystery]

and what is the basic / master method for my code?

 

[diesieben07]

What?

[DoctorG_Mystery]

foget it

[DoctorG_Mystery]

I have no made a base methode and an overrited methode in 2 Scripts:

Base methode:

package drgmystery.darklight.init;

import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ActionResult;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class DarklightOverrite {
    
    public ActionResult<ItemStack> use(PlayerEntity player, World world, Hand hand, BlockPos Pos) {
        // TODO Auto-generated method stub
        return null;
    }
}

Overrited methode:

package drgmystery.darklight.events;

import drgmystery.darklight.init.DarklightOverrite;
import net.minecraft.block.Blocks;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ActionResult;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@Mod.EventBusSubscriber(modid = "darklight", bus = Bus.FORGE, value = Dist.CLIENT)
public class DarklightPlaceTest extends DarklightOverrite{
    
    @Override
    @SubscribeEvent
        public ActionResult<ItemStack> useOn(PlayerEntity player, World world, Hand hand, BlockPos Pos){
            if(!world.isClientSide){
                double x = player.position().x();
                double y = player.position().y();
                double z = player.position().z(); 
                BlockPos blockPos = new BlockPos(x, y, z);
                world.setBlockAndUpdate(new BlockPos(blockPos), Blocks.DIAMOND_BLOCK.defaultBlockState());
            }
            return ActionResult.pass(null);
        }

}

and here is the item script:

package drgmystery.darklight.item;

import drgmystery.darklight.init.DarklightItemGroups;
import net.minecraft.item.Item;
import net.minecraft.item.Rarity;

public class TestItem1 extends Item{
    
    public TestItem1() {
        super(new Properties().defaultDurability(20).tab(DarklightItemGroups.GROUP).rarity(Rarity.EPIC));
    }
    
}

so what next? The problem with the getLookVec is still there(I first changed getLookVec to position), I think that there is a new keyword in 1.16.5 ...

Edited August 20, 2021 by DoctorG_Mystery