Jump to content

New tags failing to register before appending existing tags


Sonnebahn

Recommended Posts

Minecraft Version: 1.16.5

Forge Version: 36.2.0

Description of issue:

A loaded mod containing data pack tag registries, which creates new tags and references the new tags to further register the items in existing tags fails to register anything in the existing tags.

Example: Tinkers Construct v3.1.2.265 contains Json files to register:

  1. forge:ingots/cobalt as a new tag containing cobalt_ingot and
  2. add to previously registered tag forge:ingots.

In the file for forge:ingots, values of "tconstruct:seared_brick", "tconstruct:scorched_brick", "#forge:ingots/copper", "#forge:ingots/cobalt", etc. are indicated. In-game, none of the items listed as values are tagged under forge:ingots, however the new tags including forge:ingots/cobalt include the items tagged in those files. Further, copying the json file for forge:ingots and placing in a later applied datapack, such as Kubejs, and reloading, properly registers the forge:ingots tags.

This would appear to be an issue with timing of registering the new tags. Before copying the json file to a datapack, the existing tag (forge:ingots) appears to be handled first, which containing references to new tags that are not yet processed (forge:ingots/cobalt) fails and does not register any of the appended values. But in the second instance because the copied json file is processed after the mod jar file as a whole, the new tags exist and the appending of the new values succeeds.

While I have given Tinkers construct as an example I have viewed the same issue with multiple mods, each of which uses references to new tags in an appending of an existing tag. Likewise, mods that do not exhibit this behavior use explicit item listings rather than referencing a new tag.

I looked through the log files and did not identify any error or other message relating to the registration of tags in general or specifically these exemplar tags.

Link to comment
Share on other sites

Your report is very hard to actually understand.
Your best bet is to stop trying to 'describe' the issue and provide the actual tag files and  what you are expecting to happen.
Because all of our tests in tags work just fine.
Also, there is no 'registering' of tag in the sense you're talking about. All tags are 'registered' when they are read from disc in one pass.

So ya, provide us a test case of your tags and we'll see if it's a real issue or not.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

I will attempt to clarify.

In the mod Tinker's Construct (TConstruct-1.16.5-3.1.2.265.jar), a new tag forge:ingots/cobalt (cobalt.json) is added, placing tconstruct:cobalt_ingot as a value of the tag. Likewise, a tag not originating with tconstruct is added to forge:ingots (ingots.json). As can be seen in ingots.json, a value of #forge:ingots/cobalt is used to reference the items tagged under forge:ingots/cobalt (i.e. tconstruct:cobalt_ingot).

The expected behavior is that tconstruct:cobalt_ingot will have 2 tags - forge:ingots and forge:ingots/cobalt. The actual behavior, viewable in JEI, is only the forge:ingots/cobalt without the forge:ingots tag.

With Kubejs installed, when ingots.json is copied to [profile]\kubejs\data\forge\tags\items\ the behavior changes to the expected behavior.

This behavior extends to all listed values in the ingots.json file, whether is is explicit (i.e. tconstruct:seared_brick) or tag referenced (i.e. #forge:ingots/cobalt). such behavior points to the ingots.json file within the mod jar being ignored in tag processing, perhaps being flagged as invalid, and being accepted in the datapack directory applied by the Kubejs mod.

And while I understand that the tags are collected and processed together, nothing in programming is truly simultaneous, so the ingots.json file inside the mod is somehow being processed before the cobalt.json file and the copied ingots.json is being processed after the cobalt.json file. One order of processing failing to register the items listed and the other order of processing succeeding in processing the items listed.

Further, I have observed the same behavior in other mods: create, atum 2, etc.

Tinker's Construct came to my attention because the recipe for an ingot cast calls on the tag forge:ingots in the ingredients but fails to show most of the ingots and bricks that can ordinarily be used.

Link to comment
Share on other sites

Installed TCon, Mantle, and Tag Tooltips. 
tWtMH2s.png
Looks like it loads the data just fine. I would blame some  other  mod you have installed interfering with the tag system.
Most likely, you have another mod that is loaading after TCon that is overwriting the ingots tag. Which is why adding the json as a datapack after the fact makes it 'work'

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

Tracked it down. 

Taiga 2 v 0.0.1.1 for MC1.16.5

All of the tag json files have the replace field set to true. 

I suspect this is accidental, but it means I will have to pull it from my pack till its fixed. I will be notifying them so it can hit their fix list.

Thanks again for the assist in getting to the bottom of this issue.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried to resolve the errors but I can't do it on my own, if anyone knows please help me Heres the log: https://paste.ee/p/JL1AA.  
    • Run jarfix https://johann.loefflmann.net/en/software/jarfix/index.html
    • Ich entschuldige mich schonmal im Voraus, falls es zu Kommunikationsproblemen  kommen sollte. Ich bin deutscher, etwas gestresst und habe gerade nicht wirklich die Nerven dafür, das alles ins englische zu übersetzen.   Ich habe mir in der Curseforge App 2 Mod-Profile für die Java Minecraft-Version 1.20.1 erstellt. eines für Forge-Mods und eines Für Fabric-Mods. Allerdings bekomme ich bei beiden eine Fehlermeldung, wenn ich Minecraft spielen will. Was kann ich tun? (Wenn es gebraucht wird, werde ich mir die Zeit nehmen und die Versionen und Ersteller der Mods und Recources raussuchen.)   Alle Mods, Resources und Modloader-packs sind auf der neusten Version Standpunkt 29.02.2024   - Forge: Meine Zusammenstellung besteht aus 121 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher und der Ladebildschirm taucht auf, bricht allerdings ab und bekomme eine Fehlermeldung. Fehlermeldung: The game crashed whilst initializing game Error: net.minecraftforge.fml.loading.EarlyLoadingException: Could not execute entrypoint stage 'main' due to errors, provided by 'eldritch_end'! Exitcode: -1 Wenn ich allerdings Eldrich End aus schalte, kommt ebenfalls eine. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoClassDefFoundError: Could not initialize class net.minecraft.client.renderer.RenderType Exitcode: -1 Liste der Mods: A.V.A-Alliance of  Valiant Arms Guns Ad Astra Additional Lanterns Additional Structures Alex's Mobs Aquacolture 2 Aquamirae (Forge) Architectury API (Fabric/Forge/NeoForge) Armore Statues [Forge & Fabric] Armored Redstone AzurLib Balm (Forge Editon) Better Villages - Fabric BetterF3 Biomes O' Plenty Blue Skies Botarium CalamityMusicDisc Camera Mod Charm of Undying (Fabric/Forge/Quilt) Citadel Clasic musical discs Cloth Config API (Fabric/Forge/NeoForge) Config API [Fabric/Forge/NeoForge/Quilt] Connected Glass Connector Extras Cristel Lib Curios API (Forge/NeoForge) Curious Armor Stands Denki's Music Disc DivineRPG (Official) Dragon Mounts: Legacy Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fish Tanks Forgified Fabric API Fussion (Connected Textures) Gamma Creatures GeckoLib Handcrafted HorkLord's Musik Discs Ice and Fire: Dragons Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Infinit Abyss Just Enough Items (JEI) Kotlin for Forge L_Enders Catalysm Library Ferret - Forge Macaw's Bridges Macaw's Doors Many More Music Discs [FORGE] MCEF (Minecraft Chromium Embedded  Framework) Mobs Head Modonomicon Monster Plus More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) Morer Music Discs (Records) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators MrCrayfish's Furniture Mod Multipart Machines: Mining Music Discs Galore Musical Instrument Minecraft Interface (MIMI) Musical Lib Mythic Mounts (Forge) Necronomicon API Nether Exorcism Netherrite Horse Armor CJ [Fabric/Forge/Quilt] Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Obscure Tooltips Occultism Ore Tree:Reeborn Patchouli Puzzles Lib [Forge & Fabric] Redstone engineering Redstone Lamp Plus Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Scuffy Music Disc Pack Securety Craft Shadowlands Sinytra Connector SmartBrainLib (Forge/Fabric/Quilt) Spawn Structory Structory: Towers Structure Gel API  SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Forge) The Ather The Graveyard (FORGE/NEOFORGE) The Twilight Forrest Towns and Towers Trash Cans Traveler' Backpack Valhelsia Core Valhelsia Structures Valkyrien Skies (Forge/Fabric) Waddles Waystones DebDisplays Wireles_Redstone Wither's Wepons YUNG'S API (Forge) YUNG'S Better Desert Temples (Forge) YUNG'S Better Dungeons (Forge) YUNG'S Better End Island (Forge) YUNG'S Better Jungle Temples (Forge) YUNG'S Better Mineshafts (Forge) YUNG'S Better Nether Fortresses (Forge) YUNG'S Better Ocean Monuments (Forge) YUNG'S Better Sreongholds (Forge) YUNG'S Better Witch Huts (Forge)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons     - Fabric: Meine Zusammenstellung besteht aus 61 Mods und 6 Resources. Was passiert: Wenn ich Spielen will, komm ich zwar in den Launcher, aber ich komme noch nicht einmal in den Ladebildschirm und drückt mir direkt eine Fehlermeldung rein. Fehlermeldung: The game crashed whilst initializing game Error: java.lang.NoSuchMethodError: 'java.lang.Object[] org.apache.commons.lang3.ArrayUtils.addFirst(java.lang.Object[], java.lang.Object)' Exitcode: -1 Liste der Mods: Ad Astra Additional Lanterns Aquamirae (Fabric) Architectury API (Fabric/Forge/NeoForge) AzurLib Better Villages - Fabric BetterF3 Bosses Of Mass Destruction Botarium Cardinal Components API Cloth Config API (Fabric/Forge/NeoForge) Clutter Config API [Fabric/Forge/NeoForge/Quilt] Cristel Lib Eldrich End Energized Power Eureka! Ships! for Valkyrien Skies (Forge/Fabric) Fabric API Fabric Language Kotlin GeckoLib Handcrafted Immersiv Armors (Fabric/Forge) Immersiv Melodies (Fabric/Forge) Immersiv Paintings (Fabric/Forge) Immersiv Structures Library Ferret - Fabric Macaw's Bridges Macaw's Doors More Bows CJ (Fabric/Forge/Quilt) More Crossbows CJ (Fabric/Forge/Quilt) More Music Discs (Fabric/Forge/NeoForge) Moving Elevators Mythic Mounts Necronomicon API Nullscape Nyctophobia (FABRIC) Obscure API (Fabric) Patchouli (Fabric) Regions Unexplored (forge/fabric) Resourceful Config Resourceful Lib Spawn Structory Structory: Towers SuperMartijn642's Config Lib SuperMartijn642's Core Lib TerraBlender (Fabric) The Graveyard (FABRIC) Towns and Towers Trash Cans Valkyrien Skies (Forge/Fabric) YUNG'S API (Fabric) YUNG'S Better Desert Temples (Fabric) YUNG'S Better Dungeons (Fabric) YUNG'S Better End Island (Fabric) YUNG'S Better Jungle Temples (Fabric) YUNG'S Better Mineshafts (Fabric) YUNG'S Better Nether Fortresses (Fabric) YUNG'S Better Ocean Monuments (Fabric) YUNG'S Better Sreongholds (Fabric) YUNG'S Better Witch Huts (Fabric)   Liste der Resources: Better Cats Better Dogs Boss Refreshed Enhanced Boss Bars Visible Ores Zerotekz's Mythic Weapons
    • When i click a jar file there's a black window popping out for a second then closing i don't know what to do, it's been happening for 2 days already
    • Hello, I don't have much experience with forge but I have some java knowledge, I want to add a button that says "Explore New Packs" to the Pause Screen that opens when we enter a world in the game and press the "esc" button, but I couldn't understand it (or I don't know how to use it), although I did research from artificial intelligence or different places. I was told that I can do it using mixins but I have no idea how to do it, can you explain step by step
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.