Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Server Config loaded AFTER BiomeLoadingEvent is fired

DuckyCrayfish

By DuckyCrayfish
in Modder Support

 Share

Recommended Posts

DuckyCrayfish Tree Puncher

DuckyCrayfish

Posted
Posted (edited)

If the following is true:

  • Using a "SERVER" config is the official way to build configuration files that only affect the logical server (like world generation).
  • Using the BiomeLoadingEvent is the official way to add features and modify biome generation.

Then you would expect SERVER config files to be loaded prior to the BiomeLoadingEvent event firing. However, it seems that the opposite is true, and SERVER configurations are not accessible during the BiomeLoadingEvent. Because of this, it seems that most people are reverting to using the COMMON configuration for their mod's generation settings. Towers of the Wild and OreTweaker are two examples of this.

However, this route does not allow users to tweak these generation settings on a world-by-world basis. World generation is, in my opinion, one of the most important things to be able to configure. Since it's such a pain to remove things after they have already been generated, it is important to be able to turn on and off certain features or structures.

 

Let me know if anything I have said is incorrect, or if a known workaround exists. If not, I'd like to post this suggestion through the correct communication channels. Could someone point me in the right direction?

Thanks!

Edited by DuckyCrayfish
Adding information
DuckyCrayfish Tree Puncher

DuckyCrayfish

Posted
  • Author
Posted (edited)

Luis_ST gave me a summary of my own post with less punctuation.

I did not receive an answer, as the common config is not a suitable solution. As I mentioned, using common config does not allow world-gen configuration on a per-world/per-save basis. If, however, it is the only solution, then I asked in my OP if there is a proper line of communication I may use to suggest a change in the Forge event execution order.

Sorry if I sounded curt

Edited by DuckyCrayfish
Luis_ST Reality Controller

Luis_ST

Posted
Posted
6 minutes ago, DuckyCrayfish said:

I did not receive an answer, as the common config is not a suitable solution.

a common config is the only config that you can use for that

6 minutes ago, DuckyCrayfish said:

As I mentioned, using common config does not allow worldgen configuration on a per-world/per-save basis.

not sure what you mean by "per-world"

7 minutes ago, DuckyCrayfish said:

If, however, it is the only solution, then I asked in my OP if there is a proper line of communication I may use to suggest a change in the Forge event execution order.

that's not possible since the Events are fired in the vanilla code and the vanilla code is fix you can't change the execution order

DuckyCrayfish Tree Puncher

DuckyCrayfish

Posted
  • Author
Posted (edited)
45 minutes ago, Luis_ST said:

a common config is the only config that you can use for that

That's quite a shame considering world-gen is purely server-side.

45 minutes ago, Luis_ST said:

not sure what you mean by "per-world"

A client distribution may have many saves, and each save has its own server config file that contains logical-server related settings. This allows different saves to have different settings. This is, as I understand it, one of the main reasons that they switched to the current server/common/client config system. Of all of the configuration settings to be able to change on a per-world basis, I would expect world-gen to be one of them, considering all of the various world-gen options vanilla Minecraft allows you to change on a per-world basis.

45 minutes ago, Luis_ST said:

that's not possible since the Events are fired in the vanilla code and the vanilla code is fix you can't change the execution order

The entire configuration subsystem was added by Forge. I don't think that simply making a suggestion on the config load order of a modding platform is unreasonable.  Humor me and point me in the right direction?

Edited by DuckyCrayfish
DuckyCrayfish Tree Puncher

DuckyCrayfish

Posted
  • Author
Posted (edited)

Thank you! That makes sense.

You don't think there's any way that the server directory can be deduced at that point, allowing a potential future version of Forge to pre-load the configs before the server is loaded? I'm aware of how ignorant that question probably sounds, we are steering away from my area of understanding.

Edited by DuckyCrayfish
DuckyCrayfish Tree Puncher

DuckyCrayfish

Posted
  • Author
Posted (edited)
Quote

 This event fires when a Biome is created from json or when a registered biome is re-created for worldgen.

It fires a couple times, including when you load an existing save, which is when I make all of my modifications. But I understand what you mean now, and I can see why that would make a modification such as the one I suggested difficult. Oh well...

Hey thanks @diesieben07 for the technical replies. I appreciate the consideration!

Edited by DuckyCrayfish

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • flightcrew5252
      server crash

      By flightcrew5252 · Posted

      hello i am wanting to know if anyone can help me with this crash happened when i tried to go to bed on server https://pastebin.com/CezfAbAh
    • Affe
      mods.toml missing metadata for modid create

      By Affe · Posted

      I accidentally posted this in the ForgeGradle subforum, super sorry. I meant to post it in the regular modders forum. Hopefully it can still reach the right people!
    • Affe
      mods.toml missing metadata for modid create

      By Affe · Posted

      I've been trying to make an addon mod for create, but setting up dependencies and trying to add the mod into my mod environment has proven a little difficult for me. Ive been searching this forum and I've seen problems that were close to mine but not exactly mine, searching the error output just yields  people having trouble with their own modid, not an addons. The error while loading Minecraft,  "mods.toml missing metadata of modid create" and  "The Mod File C:Users\user1\data\<mod>\build\resources\main has mods that were not found" My build.gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'org.parchmentmc.librarian.forgegradle' version '1.+' } version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: 'parchment', version: '2023.09.03-1.20.1' copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' property 'mixin.env.remapRefMap', 'true' property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg" mods { "${mod_id}" { source sourceSets.main } } } client { // ... mods { other_mod { // ... } // Configures the 'example' mod create { // Add a source set to a mod's sources source sourceSets.main // Merges this configuration and specifies whether to overwrite existing properties merge mods.other_mod, true } } } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } // This run config launches GameTestServer and runs all registered gametests, then exits. // By default, the server will crash when no gametests are provided. // The gametest system is also enabled by default for other run configs under the /test command. gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { // example of overriding the workingDirectory set in configureEach above workingDirectory project.file('run-data') // Specify the modid for data generation, where to output the resulting resource, and where to look for existing resources. args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } // Include resources generated by data generators. sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { maven { url = 'https://maven.tterrag.com/' } } dependencies { // Specify the version of Minecraft to use. // Any artifact can be supplied so long as it has a "userdev" classifier artifact and is a compatible patcher artifact. // The "userdev" classifier will be requested and setup by ForgeGradle. // If the group id is "net.minecraft" and the artifact id is one of ["client", "server", "joined"], // then special handling is done to allow a setup of a vanilla dependency without the use of an external repository. minecraft "net.minecraftforge:forge:1.20.1-47.3.22" implementation fg.deobf("com.simibubi.create:create-${create_minecraft_version}:${create_version}:slim") { transitive = false } implementation fg.deobf("com.jozufozu.flywheel:flywheel-forge-${flywheel_minecraft_version}:${flywheel_version}") implementation fg.deobf("com.tterrag.registrate:Registrate:${registrate_version}") // Example mod dependency with JEI - using fg.deobf() ensures the dependency is remapped to your development mappings // The JEI API is declared for compile time use, while the full JEI artifact is used at runtime // compileOnly fg.deobf("mezz.jei:jei-${mc_version}-common-api:${jei_version}") // compileOnly fg.deobf("mezz.jei:jei-${mc_version}-forge-api:${jei_version}") // runtimeOnly fg.deobf("mezz.jei:jei-${mc_version}-forge:${jei_version}") // Example mod dependency using a mod jar from ./libs with a flat dir repository // This maps to ./libs/coolmod-${mc_version}-${coolmod_version}.jar // The group id is ignored when searching -- in this case, it is "blank" // implementation fg.deobf("blank:coolmod-${mc_version}:${coolmod_version}") // For more info: // http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html // http://www.gradle.org/docs/current/userguide/dependency_management.html } // This block of code expands all declared replace properties in the specified resource targets. // A missing property will result in an error. Properties are expanded using ${} Groovy notation. // When "copyIdeResources" is enabled, this will also run before the game launches in IDE environments. // See https://docs.gradle.org/current/dsl/org.gradle.language.jvm.tasks.ProcessResources.html tasks.named('processResources', ProcessResources).configure { var replaceProperties = [ minecraft_version: minecraft_version, minecraft_version_range: minecraft_version_range, forge_version: forge_version, forge_version_range: forge_version_range, loader_version_range: loader_version_range, mod_id: mod_id, mod_name: mod_name, mod_license: mod_license, mod_version: mod_version, mod_authors: mod_authors, mod_description: mod_description, ] inputs.properties replaceProperties filesMatching(['META-INF/mods.toml', 'pack.mcmeta']) { expand replaceProperties + [project: project] } } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ") ]) } // This is the preferred method to reobfuscate your jar file finalizedBy 'reobfJar' } // However if you are in a multi-project build, dev time needs unobfed jar files, so you can delay the obfuscation until publishing by doing: // tasks.named('publish').configure { // dependsOn 'reobfJar' // } // Example configuration to allow publishing using the maven-publish plugin publishing { publications { register('mavenJava', MavenPublication) { artifact jar } } } tasks.withType(JavaCompile).configureEach { options.encoding = 'UTF-8' // Use the UTF-8 charset for Java compilation } -And my mods.toml file  modLoader="javafml" #mandatory loaderVersion="[47,)" license="MIT" [[mods]] modId="mechmod" version="0.0.1" displayName="Create: Mechs" authors="Affe" [[dependencies.mechmod]] modId="create" mandatory=true versionRange="[0,)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="forge" mandatory=true versionRange="[47.1.3,)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="minecraft" mandatory=true versionRange="[1.20,1.21)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="flywheel" mandatory=true versionRange="[0.6.11,0.6.12)" ordering="AFTER" side="CLIENT" I thought I had implemented the code from the "depending on create" section from their github correctly. But I assume I haven't implemented something that is needed. But I don't know what or where. I can also provide any file you think will help with your diagnosis. Any help would be appreciated, cheers!   
    • CheIlia
      [1.18.2] Is it possible to get all items that have a certain tag?

      By CheIlia · Posted

      Yo i might be a lil bit late but on 1.20.6 you can call BuiltInRegistries.ITEMS.getTagOrEmpty(*required tag*) to get an iterable of item holders, this might be possible on 1.18.2 as well. Then you get the items using for(Holder<Item> holder: iterable) or the .forEach(Consumer<Holder<Item>>) method, or convert the iterable to array/list/collection. When you get the holders, use the .get() method to get the items
    • LemonTheCichlid
      Library Configs Giving Exit Code -1

      By LemonTheCichlid · Posted

      I'm troubleshooting some mods that I want for a single player world in 1.21.4 and I was having trouble with a resource library config crashing my game so I tried another mod and the library config for that was causing crashes as well. I've updated java and forge recently. Both of these dependency mods have caused Exit Code: -1 but I'm using the crash report for the mod that I was originally wanting to use. https://pastebin.com/82FZPwS2

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept