[1.16.5] Config file on client side not synced with server config file

[MR_Classy]

Im trying to make a config file that can only be edited server side.

However, no matter what i change on the server, the config file on the client side doesnt get updated.

 

[Luis_ST]

that's not how configs work,
there is the client config which is for client things like rendering,
there is the common config which is for everything else like Level generation,
and the server config is for server stuff

the name (type) of the config indicates on which side you can use the config,
so the server config doesn't know about the client config

[MR_Classy]

Ok, i mightve explained it wrong.
Im trying to create a config for a potions mod, specifically to enable or disable crafting of those potions, so i dont want players changing those values.

However, when i try to remove a recipe server side, the recipe still shows up ingame (the actual potion cant be crafted, but if i use something like JEI to check out how to craft it, the recipe is loaded in).

My understanding was that if something like a recipe gets turned off on the server side, the players shouldnt be able to still see it ingame.

 

[Luis_ST]

okay how did you update the client?

[MR_Classy]

Sorry, im kinda new to this and not 100% sure which part does that.

This is the code i use to initiate the config 
 

       ModLoadingContext.get().registerConfig(Type.SERVER, PnsConfig.SPEC);
        PnsConfig.loadConfig(PnsConfig.SPEC, FMLPaths.CONFIGDIR.get().resolve("potsnstuff-server.toml").toString());

And the actual config class 
https://pastebin.com/BNaTVsjT

[Luis_ST]

why on earth did you load the config twice?
where did you call this code?

[MR_Classy]

cuz i was trying to find a way to stop the config file from generating in a random order and that was the only way i found how to do it, seemed a bit weird but didnt know how else.
And calling them in the main class

    public PotsNStuff() {
    	IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
        bus.addListener(this::setup);
        ConteinerTypeInit.CONTAINER_TYPES.register(bus);
        ItemInit.ITEMS.register(bus);
        EffectInit.EFFECTS.register(bus);
        RecepiesInit.RECIPE_SERIALIZERS.register(bus);
        PotionInit.POTIONS.register(bus);
        ModLoadingContext.get().registerConfig(Type.SERVER, PnsConfig.SPEC);
        PnsConfig.loadConfig(PnsConfig.SPEC, FMLPaths.CONFIGDIR.get().resolve("potsnstuff-server.toml").toString());
		MinecraftForge.EVENT_BUS.register(this);
    }

 

[Luis_ST]

6 minutes ago, MR_Classy said:

generating in a random order

they are normally generate always in the same folder,
client config in: .minecraft/config
common config in: .minecraft/config
server config in: .minecraft/saves/world_name/serverconfig

[MR_Classy]

 

2 minutes ago, Luis_ST said:

they are normally generate always in the same folder,
client config in: .minecraft/config
common config in: .minecraft/config
server config in: .minecraft/saves/world_name/serverconfig

i ment the variables in the .toml file not being in the order i added them via code

[Luis_ST]

you need to run the game a few times and delete the config file are the run and the error will fixed by himself

[MR_Classy]

Nope, the issue is still there.

 

[Luis_ST]

i will test that. but back to your question,
you need to send a custom packet to the client, which updates the value there

[MR_Classy]

ok, ill look into that, hopefully it helps
and yea, testing might be a good idea, i wouldnt be surprised if i messed something up

[MR_Classy]

Sorry, I'm not sure I understood that. Which custom code are you referring to, the config class?

 

[MR_Classy]

The recipes in question are for potions with custom effects so I need to initialise them and add them to the recipe registry myself, I'm not turning off base game recipes

[MR_Classy]

And I'm aware the server should be the only one aware of what recipes exist, issue is the client also generates its own config instead of getting the info from the server.

On that note, I looked around a bit more and apparently the issue might be that I'm running logical server code on a logical client.

 

[MR_Classy]

16 minutes ago, diesieben07 said:

This makes no sense. Recipes must be made using JSON files.

You can use a custom IRecipeSerializer if you need specialized recipes.

Potion recipes, as in brewing stand recipe, not crafting table recipe

And for those (as far as I know) you use BrewingRecipeRegistry.addRecipe(base potion, ingredient, resulting potion), No JSON files needed

Edited October 7, 2021 by MR_Classy
Clarity

[MR_Classy]

12 minutes ago, diesieben07 said:

In that case you need to always register your recipe (on server and client!) and change its behavior dynamically based on the config file. Use a SERVER type config, which Forge automatically syncs to clients that join the server.

I'm already doing that, both the register part and server config part, it's not syncing.

[MR_Classy]

6 hours ago, diesieben07 said:

Show your code.

I already posted the code for just the config class, this is the entire mod
https://github.com/MRClassyy/pots_n_stuff

[MR_Classy]

i already do that, one line before i call the loadConfig method
And i think i already said this, but that was the only way i knew how to make the config files contents match the coded input.
Without it, the .toml files contents are added in a random order

[MR_Classy]

48 minutes ago, diesieben07 said:

Do not load config files manually.

I deleted that command.
The only change is that the text in my config file isnt ordered properly.
The client server sync issue is still there.

[MR_Classy]

5 minutes ago, diesieben07 said:

Update your Git repo.

Done.

[MR_Classy]

Changed that too now.

[MR_Classy]

yea, the client still keeps generating a config file thats different from the one on server

[MR_Classy]

you can, go into that file, change for example "frailness potion" = true to false and try to craft that potion ingame, recipe is awkward pot and rotten flesh, or better yet, add JEI so u can see that the recipe is still added even tho its turned off