Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Alright I am having a major issue with my custom dimension. Whenever I allow my mod's worldgen features to generate in my dimension (this doesn't happen when I disable them), Minecraft either has a memory leak or the server thread hangs, causing Minecraft to be unresponsive.

Biome Provider: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/java/net/paradisemod/world/dimension/biomeprovider/OWCBiomeProvider.java

Chunk Generator: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/java/net/paradisemod/world/dimension/chunkgen/OWCChunkGenerator.java

Dimension JSON: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/resources/data/paradisemod/dimension/overworld_core.json

Dimension Type JSON: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/resources/data/paradisemod/dimension_type/overworld_core.json

I am at the end of my wits on solving this issue.

Edited by NetherNoah777
My issue is fixed

can you post a git repo, since i need the Features you want to add and it's easier to look at many classes

  • Author

I'm not currently at my computer right now. When I have access to it, I'll post my log and a screenshot of the heap memory monitor from VisualVM. 

  • Author

Alright Luis_ST, here is my debug information:

Debug log and thread dump

Debug screen at time of server thread hang

ZZKT18q.png

VisualVM heap monitor at time of server thread hang:

i1D5y2h.png

Also, I noticed when the server thread hangs, it always hangs at some method in net.minecraft.village.PointOfInterestManager

  • Author

Alright, when I get a chance, I'll convert all my Feature objects to RegistryObject<Feature> and all of my ConfiguredFeature<?, ?> objects to Supplier<ConfiguredFeature<?, ?>> objects. Do you think that could be a contributor to my issue?

  • Author

And I think my thread hanging issue may have had to do with the fact that villages were trying generate in my dimension (I need to investigate this more). In my BiomeProvider, I removed all the biomes associated with villages and Minecraft seemed to stopped hanging, however I still need to investigate the memory leak that causes my system's OOM killer to kick in and kill Minecraft.

Edited by NetherNoah777

19 minutes ago, NetherNoah777 said:

Do you think that could be a contributor to my issue?

it can but i think not

  • Author

Alright, I believe I may have discovered what my issue was. It seems that when overworld biomes are generated in underground dimensions (the dimension in question is underground), their feature generation doesn't seem to play very nice with the chunk structure (it is 256 blocks high). As of right now, I have my dimension generating the Nether Wastes biome right now and I have been exploring it for over an hour now without any issue. To anyone who happens to have this issue when creating an underground dimension in the future, don't use overworld biomes in it (especially if the chunk is 256 blocks tall). Thank for your help Luis_ST.

Edited by NetherNoah777

  • NetherNoah777 changed the title to Issue with custom Dimension (Minecraft 1.16.5) [solved]

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.