Issue with custom Dimension (Minecraft 1.16.5) [solved]

[NetherNoah777]

Alright I am having a major issue with my custom dimension. Whenever I allow my mod's worldgen features to generate in my dimension (this doesn't happen when I disable them), Minecraft either has a memory leak or the server thread hangs, causing Minecraft to be unresponsive.

Biome Provider: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/java/net/paradisemod/world/dimension/biomeprovider/OWCBiomeProvider.java

Chunk Generator: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/java/net/paradisemod/world/dimension/chunkgen/OWCChunkGenerator.java

Dimension JSON: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/resources/data/paradisemod/dimension/overworld_core.json

Dimension Type JSON: https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/resources/data/paradisemod/dimension_type/overworld_core.json

I am at the end of my wits on solving this issue.

Edited October 15, 2021 by NetherNoah777
My issue is fixed

[Luis_ST]

can you post a git repo, since i need the Features you want to add and it's easier to look at many classes

[NetherNoah777]

https://gitlab.com/NoahJelen/paradisemod

Here is my mod's git repository

[Luis_ST]

 in which class can I found your Features (package and class would be helpful)

[NetherNoah777]

Features package: https://gitlab.com/NoahJelen/paradisemod/-/tree/1.16.5/src/main/java/net/paradisemod/world/gen/features

[Luis_ST]

your code looks fine, can you post the full debug log

[NetherNoah777]

I'm not currently at my computer right now. When I have access to it, I'll post my log and a screenshot of the heap memory monitor from VisualVM. 

[NetherNoah777]

Alright Luis_ST, here is my debug information:

Debug log and thread dump

Debug screen at time of server thread hang

VisualVM heap monitor at time of server thread hang:

Also, I noticed when the server thread hangs, it always hangs at some method in net.minecraft.village.PointOfInterestManager

[Luis_ST]

you can't use static initializer for Registry
https://gitlab.com/NoahJelen/paradisemod/-/blob/1.16.5/src/main/java/net/paradisemod/world/gen/features/PMFeatures.java#L29-49
use RegistryObjects refer to this doc

[NetherNoah777]

Alright, when I get a chance, I'll convert all my Feature objects to RegistryObject<Feature> and all of my ConfiguredFeature<?, ?> objects to Supplier<ConfiguredFeature<?, ?>> objects. Do you think that could be a contributor to my issue?

[NetherNoah777]

And I think my thread hanging issue may have had to do with the fact that villages were trying generate in my dimension (I need to investigate this more). In my BiomeProvider, I removed all the biomes associated with villages and Minecraft seemed to stopped hanging, however I still need to investigate the memory leak that causes my system's OOM killer to kick in and kill Minecraft.

Edited October 14, 2021 by NetherNoah777

[Luis_ST]

  On 10/14/2021 at 6:11 PM, NetherNoah777 said:

Do you think that could be a contributor to my issue?

Expand  

it can but i think not

[NetherNoah777]

Alright, I believe I may have discovered what my issue was. It seems that when overworld biomes are generated in underground dimensions (the dimension in question is underground), their feature generation doesn't seem to play very nice with the chunk structure (it is 256 blocks high). As of right now, I have my dimension generating the Nether Wastes biome right now and I have been exploring it for over an hour now without any issue. To anyone who happens to have this issue when creating an underground dimension in the future, don't use overworld biomes in it (especially if the chunk is 256 blocks tall). Thank for your help Luis_ST.

Edited October 15, 2021 by NetherNoah777