[1.16.5] Replacement Spawner Block that has Health

[izofar]

I've created my own spawner block, called LimitedSpawnerBlock (extending SpawnerBlock), which returns a LimitedMobSpawnerTileEntity (extending MobSpawnerTileEntity) upon calling the overriden LimitedSpawnerBlock#createTileEntity, which owns a LimitedAbstractSpawner (extending AbstractSpawner)--- set up just like the Vanilla code...

My goal is for the spawner block to break after so many spawns (like how RLCraft spawners have health). The LimitedMobSpawnerTileEntity stores health, which decrements on spawn, and calls for the LimitedSpawnerBlock to be deleted from the world when health reaches zero.

I've registered the LimitedSpawnerBlock as "minecraft:spawner" and the TileEntityType<LimitedMobSpawnerTileEntity> as "minecraft:mob_spawner". 

I've read the docs on tile entities and yet get this error, crashing my game when I place a spawner, and not loading chunks that should have a spawner:

Spoiler

[15:15:58] [Render thread/WARN] [minecraft/ClientPlayNetHandler]: Received passengers for unknown entity
[15:16:08] [Server thread/ERROR] [minecraft/Chunk]: A TileEntity type com.izofar.izomod.tileentity.LimitedMobSpawnerTileEntity has thrown an exception trying to write state. It will not persist, Report this to the mod author
java.lang.RuntimeException: class com.izofar.izomod.tileentity.LimitedMobSpawnerTileEntity is missing a mapping! This is a bug!
        at net.minecraft.tileentity.TileEntity.saveMetadata(TileEntity.java:64) ~[forge:?] {re:classloading}
        at net.minecraft.tileentity.TileEntity.save(TileEntity.java:58) ~[forge:?] {re:classloading}
        at net.minecraft.tileentity.MobSpawnerTileEntity.save(MobSpawnerTileEntity.java:47) ~[forge:?] {re:classloading}
        at com.izofar.izomod.tileentity.LimitedMobSpawnerTileEntity.save(LimitedMobSpawnerTileEntity.java:52) ~[?:?] {re:classloading}
        at net.minecraft.world.chunk.Chunk.getBlockEntityNbtForSaving(Chunk.java:427) ~[forge:?] {re:classloading}
        at net.minecraft.world.chunk.storage.ChunkSerializer.write(ChunkSerializer.java:287) ~[forge:?] {re:classloading}
        at net.minecraft.world.server.ChunkManager.save(ChunkManager.java:682) ~[forge:?] {re:classloading}
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) ~[?:1.8.0_291] {}
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[?:1.8.0_291] {}
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) ~[?:1.8.0_291] {}
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384) ~[?:1.8.0_291] {}
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) ~[?:1.8.0_291] {}
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) ~[?:1.8.0_291] {}
        at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[?:1.8.0_291] {}
        at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) ~[?:1.8.0_291] {}
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_291] {}
        at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) ~[?:1.8.0_291] {}
        at net.minecraft.world.server.ChunkManager.saveAllChunks(ChunkManager.java:337) ~[forge:?] {re:classloading}
        at net.minecraft.world.server.ServerChunkProvider.save(ServerChunkProvider.java:307) ~[forge:?] {re:classloading,pl:accesstransformer:B}
        at net.minecraft.world.server.ServerWorld.save(ServerWorld.java:698) ~[forge:?] {re:classloading}
        at net.minecraft.server.MinecraftServer.saveAllChunks(MinecraftServer.java:532) ~[forge:?] {re:classloading,pl:accesstransformer:B}
        at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:568) ~[forge:?] {re:classloading,pl:accesstransformer:B}
        at net.minecraft.server.integrated.IntegratedServer.stopServer(IntegratedServer.java:167) ~[forge:?] {re:classloading,pl:runtimedistcleaner:A}
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:679) ~[forge:?] {re:classloading,pl:accesstransformer:B}
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:232) ~[forge:?] {re:classloading,pl:accesstransformer:B}
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_291] {}

This is my LimitedMobSpawnerTileEntity class:

Spoiler

public class LimitedMobSpawnerTileEntity extends MobSpawnerTileEntity {

	private AbstractSpawner spawner;
	
	public LimitedMobSpawnerTileEntity() {
		super();
		this.spawner = new LimitedAbstractSpawner(this) {
			public void broadcastEvent(int p_98267_1_) {
				LimitedMobSpawnerTileEntity.this.level.blockEvent(LimitedMobSpawnerTileEntity.this.worldPosition, ModBlocks.LIMITED_SPAWNER, p_98267_1_, 0);		
			}

			public World getLevel() {
				return LimitedMobSpawnerTileEntity.this.level;
			}

			public BlockPos getPos() {
				return LimitedMobSpawnerTileEntity.this.worldPosition;
			}
			
			public void setNextSpawnData(WeightedSpawnerEntity p_184993_1_) {
		        super.setNextSpawnData(p_184993_1_);
		        if (this.getLevel() != null) {
		           BlockState blockstate = this.getLevel().getBlockState(this.getPos());
		           this.getLevel().sendBlockUpdated(LimitedMobSpawnerTileEntity.this.worldPosition, blockstate, blockstate, 4);
		        }
		     }
		};
	}
	
	public void destroy(World world) {
		world.removeBlockEntity(this.getBlockPos());
	}
	
	@Override
	public CompoundNBT save(CompoundNBT nbt) {
		return super.save(nbt);
	}

	@Override
	public void load(BlockState state, CompoundNBT nbt) {
		super.load(state, nbt);
	}
}

I'm not sure what is wrong with the mapping?

Edited October 18, 2021 by izofar

[izofar]

Update: I resolved the mapping issue by registering with .setRegistryName("mob_spawner") instead of  .setRegistryName("minecraft", "mob_spawner"). I still get the following errors, and the spawner blocks that spawn are empty:

[15:26:03] [Render thread/WARN] [minecraft/ClientPlayNetHandler]: Received passengers for unknown entity
[15:26:03] [Server thread/WARN] [minecraft/TileEntity]: Block entity invalid: minecraft:mob_spawner @ BlockPos{x=651, y=69, z=-10735}

I've tracked down that the TileEntity messages comes from isValid(), which checks if it is in the Set of valid blocks, determined by:

public TileEntityType(Supplier<? extends T> p_i51497_1_, Set<Block> p_i51497_2_, Type<?> p_i51497_3_) {
      this.factory = p_i51497_1_;
      this.validBlocks = p_i51497_2_;
      this.dataType = p_i51497_3_;
   }

But, shouldn't this be handled by the TileEntityType registry?

Edited October 18, 2021 by izofar

[Luis_ST]

show where you register your TE

[izofar]

14 hours ago, Luis_ST said:

show where you register your TE

I plan to move to deferred registries when I port to 1.17, but I am currently working with the registry events approach. My declaration is:

public static TileEntityType<LimitedMobSpawnerTileEntity> LIMITED_MOB_SPAWNER = (TileEntityType<LimitedMobSpawnerTileEntity>)TileEntityType.Builder.of(LimitedMobSpawnerTileEntity::new, ModBlocks.LIMITED_SPAWNER).build(null).setRegistryName("mob_spawner");

In which I register it here:

@SubscribeEvent
    public static void onTileEntitiesRegistry(final RegistryEvent.Register<TileEntityType<?>> tileEntityRegistryEvent) {
        tileEntityRegistryEvent.getRegistry().registerAll(
        		
        		ModTileEntityTypes.LIMITED_MOB_SPAWNER
        		
        );
    }

EDIT:

Using the above code, I just get a bunch of empty spawners. When I change the TE registration to "minecraft:mob_spawner" then I get the mapping error again. I think this is closer to what I want, but I may be missing a step. Looking at the mapping error I get, I traced it to my TileEntity#save override, in which the error comes from the check:

private CompoundNBT saveMetadata(CompoundNBT p_189516_1_) {
      ResourceLocation resourcelocation = TileEntityType.getKey(this.getType());
      if (resourcelocation == null) {
         throw new RuntimeException(this.getClass() + " is missing a mapping! This is a bug!");
      } else {
         ...
         return p_189516_1_;
      }
   }

The TileEntityType.getKey method uses depreciated methods, so I'm not sure how to bug fix that, but I believe it is just looking for the name to which I registered the TE.  

EDIT:

I figured out that because my LimitedSpawnerTileEntity was extending SpawnerTileEntity, that the constructor was passing TileEntityType.MOB_SPAWNER to TileEntity through super, even thought I should have passed ModTileEntityType.LIMITED_MOB_SPAWNER. Once I did that, and removed the SpawnerTileEntity extension and extended TileEntity directly, the mapping was resolved. I still have an issue with modifying the existing spawner behavior, because now when dungeons feature checks if the spawner is an instance of SpawnerTileEntity, it returns false. I know that Java inheritence doesn't allow for a way to access the super of the super (intending to pass the modded TE type instead), how else should I best do this?

Edited October 19, 2021 by izofar

[izofar]

12 minutes ago, diesieben07 said:

That means you need to create your registry objects in the registry events and you need to use @ObjectHolder to inject them into fields. Your current code is not correct.

Currently, I have a init package with my ModBlocks, ModItems, ModEntityTypes, etc. abstract classes that initialize the registry objects as class fields. Does it suffice to use @ObjectHolder("modid") above the class name in each class? My runClient has worked so far without these annotations... are these necessary for build, then? All of my registry objects are currently public static. Should I use final on all objects?

Also, regarding the original topic, I updated my last post with the inheritance issue I am running into.

[Luis_ST]

18 minutes ago, izofar said:

Should I use final on all objects?

when a Field can be final it should be

Edit: forgot to say i would recommend you to use DeferredRegister

Edited October 19, 2021 by Luis_ST

[izofar]

Thank you both... as for overriding spawners, if I want each spawner to have its own health, how can I make my modded spawner TE a subclass of the vanilla spawner TE, but maintain the mappings by passing the modded TE type through to the TileEntity super-superclass?

[Draco18s]

7 minutes ago, izofar said:

how can I make my modded spawner TE a subclass of the vanilla spawner TE, but maintain the mappings by passing the modded TE type through to the TileEntity super-superclass?

Basically you can't.

[izofar]

5 minutes ago, Draco18s said:

Basically you can't.

Since all I'm basically doing with the subclass is storing a "health" field, is storing this as an NBT in the spawner TE that already exists feasible (using special spawn events and getting the spawner TE that way)?