Small issue with onArmorTick [1.16.5]

[Feroov]

Hello everyone, so currently my onArmorTick as of now works but not the way I want, basically it is on a constant, for example if I have absorption, lets say it is on always 0:10 seconds and when I do take damage, instantly the absorption regens (basically invincible). Here is my code:
 

      @Override
      public void onArmorTick(ItemStack stack, World world, PlayerEntity player)
      {
          if(!world.isClientSide)
          {
              boolean hasPlayerAbsorptionEffect = !Objects.equals(player.getEffect(Effects.ABSORPTION), null);
                  if(player.getItemBySlot(EquipmentSlotType.HEAD).getItem() == ModItems.OCLUTRIUM_HELMET.get()
                                         && player.getItemBySlot(EquipmentSlotType.CHEST).getItem() == ModItems.OCLUTRIUM_CHESTPLATE.get() &&
                          player.getItemBySlot(EquipmentSlotType.LEGS).getItem() == ModItems.OCLUTRIUM_LEGGINGS.get() &&
                          player.getItemBySlot(EquipmentSlotType.FEET).getItem() == ModItems.OCLUTRIUM_BOOTS.get()
                                 )
                      player.addEffect(new EffectInstance(Effects.ABSORPTION, 200, 2));
                  super.onArmorTick(stack, world, player);
          }
      }

Cheers!

Edited October 30, 2021 by Feroov

[Luis_ST]

your code works how it should, since ArmorItem#onArmorTick is called every tick (20 times in a second)
what did you try to achieve?

[Feroov]

7 minutes ago, Luis_ST said:

your code works how it should, since ArmorItem#onArmorTick is called every tick (20 times in a second)
what did you try to achieve?

Yes everything works it's just that if i have absorption, it will insta heal the player back, which is game breaking you become lets say invincible, I wanted to make it in a way when you take damage, you still have the absorption effect but empty hearts if that makes sense, lets say you ate a golden apple and took damage, you know how the hearts still stay but blacked out, same logic here how I want hope that makes sense

[Luis_ST]

again it works how it should, the absorption hearts are temporary, if the heart is "empty" it will be removed instantly

[Feroov]

1 minute ago, Luis_ST said:

again it works how it should, the absorption hearts are temporary, if the heart is "empty" it will be removed instantly

Ok then fair enough, but still thank you so much

[Draco18s]

23 hours ago, Feroov said:

Objects.equals(

The fuck? Why not just compare the return value to something useful? Like, I don't know, getEffect() == null?

23 hours ago, Feroov said:

boolean hasPlayerAbsorptionEffect

Cool you stored whether or not the player has the absorption effect in a local variable.

Which you then never use.