[SOLVED] GUI opens but won't allow item pickup

[nerdboy64]

I'm working on a mod that opens a GUI with a keypress and allows you to edit item names, enchantments, lore, etc. At the moment, I have created the basic GUI and added the player's inventory to it as well as the slot for the item you want to edit. It will open and display just fine, but when I try to pick up an item, it reverts back to its original slot after a fraction of a second. I've hunted around, but all the tutorials I find are outdated. I've found one other help thread on the topic, but the OP never released the code that fixed it so it wasn't any help.

 

Anyone know how to fix this problem? Relevant code is below. I found the problem. See the edit below.

 

My container:

package mapassist;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.InventoryBasic;
import net.minecraft.inventory.Slot;
import net.minecraft.world.World;

public class ContainerItemEdit extends Container {

public InventoryPlayer inventory;
public IInventory item = new InventoryBasic("Item", false, 1);
World world;
int x, y, z;

public ContainerItemEdit(InventoryPlayer inventory, World world, int x, int y, int z){
	this.inventory = inventory;
	this.world = world;
	this.x = x;
	this.y = y;
	this.z = z;
	addSlotToContainer(new Slot(inventory, 36, 8, 20));
	bindPlayerInventory(inventory);
}

@Override
public boolean canInteractWith(EntityPlayer entityplayer) {
	return true;
}

protected void bindPlayerInventory(InventoryPlayer inventoryPlayer) {
     for (int i = 0; i < 3; i++) {
       for (int j = 0; j < 9; j++) {
         addSlotToContainer(new Slot(inventoryPlayer, j + (i * 9) + 9, 
           8 + j * 18, 84 + i * 18));
       }
     }

     for (int i = 0; i < 9; i++)
       addSlotToContainer(new Slot(inventoryPlayer, i, 8 + i * 18, 142));
   }

}

 

Key handler class (opens the container):

package mapassist;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import java.util.EnumSet;

import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.TickType;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;

public class KeyHandler extends KeyBindingRegistry.KeyHandler{

private static KeyBinding[] keys = {
	new KeyBinding("Open Mapmaker's Assistant", 19)
};

public KeyHandler() {
	super(keys, new boolean[keys.length]);
}

@Override
public String getLabel() {
	return "Key bindings for Mapmaker's Assistant";
}

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd, boolean isRepeat) {
	EntityPlayer player = Minecraft.getMinecraft().thePlayer;
	if(tickEnd && kb.keyCode == keys[0].keyCode && Minecraft.getMinecraft().currentScreen == null && player.capabilities.isCreativeMode){
		//player.addChatMessage("Congratulations! You pressed the R key!");
		player.openGui(MapAssist.instance, 0, player.worldObj, (int)player.posX, (int)player.posY, (int)player.posZ);
	}
}

@Override
public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd) {

}

@Override
public EnumSet<TickType> ticks() {
	EnumSet<TickType> ticks = EnumSet.of(TickType.CLIENT);
	return ticks;
}

}

 

Base mod class:

package mapassist;

import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.network.NetworkRegistry;

@Mod(modid="mapassist", name="Mapmaker's Assistant", version="0.1.0")
@NetworkMod(clientSideRequired=true, serverSideRequired=true, channels={"mapassist"}, packetHandler=PacketHandler.class)
public class MapAssist {

@SidedProxy(clientSide="mapassist.ProxyClient", serverSide="mapassist.ProxyCommon")
public static ProxyCommon proxy;
@Mod.Instance(value="mapassist")
public static MapAssist instance;

public static final short ITEMEDIT = 1;

@EventHandler
public void load(FMLInitializationEvent event){
	NetworkRegistry.instance().registerGuiHandler(this, new GuiHandler());
}

}

 

EDIT: Shortly after posting this, I figured out what the problem was. Keypresses are only registered client-side, so I just had to set up a packet handler to open the container on the server. For anyone else who wants to do the same thing, the new code is below:

 

New key handler:

package mapassist;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import java.util.EnumSet;

import net.minecraft.client.Minecraft;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.TickType;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;

public class KeyHandler extends KeyBindingRegistry.KeyHandler{

private static KeyBinding[] keys = {
	new KeyBinding("Open Mapmaker's Assistant", 19)
};

public KeyHandler() {
	super(keys, new boolean[keys.length]);
}

@Override
public String getLabel() {
	return "Key bindings for Mapmaker's Assistant";
}

@Override
public void keyDown(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd, boolean isRepeat) {
	EntityPlayer player = Minecraft.getMinecraft().thePlayer;
	if(tickEnd && kb.keyCode == keys[0].keyCode && Minecraft.getMinecraft().currentScreen == null && player.capabilities.isCreativeMode){
		//player.addChatMessage("Congratulations! You pressed the R key!");
		player.openGui(MapAssist.instance, 0, player.worldObj, (int)player.posX, (int)player.posY, (int)player.posZ);

		Packet250CustomPayload pkt = new Packet250CustomPayload();
	    ByteArrayOutputStream bytes = new ByteArrayOutputStream();
	    DataOutputStream data = new DataOutputStream(bytes);
	    try {
	    	data.writeByte(1);
	    } catch (IOException e) {
	    	e.printStackTrace();
	    }
	    pkt.channel = "mapassist";
	    pkt.data = bytes.toByteArray();
	    pkt.length = pkt.data.length;
	    PacketDispatcher.sendPacketToServer(pkt);
	}
}

@Override
public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd) {

}

@Override
public EnumSet<TickType> ticks() {
	EnumSet<TickType> ticks = EnumSet.of(TickType.CLIENT);
	return ticks;
}

}

 

Packet handler:

package mapassist;

import java.io.ByteArrayInputStream;
import java.io.DataInputStream;
import java.io.IOException;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet250CustomPayload;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.Player;

public class PacketHandler implements IPacketHandler {

@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player) {
	ByteArrayInputStream bytes = new ByteArrayInputStream(packet.data);
    DataInputStream data = new DataInputStream(bytes);

    try{
    	if(data.readByte() == 1){
    		EntityPlayer entityplayer = ((EntityPlayer)player);
    		entityplayer.openGui(MapAssist.instance, 0, entityplayer.worldObj, (int)entityplayer.posX, (int)entityplayer.posY, (int)entityplayer.posZ);
    	}
    } catch(IOException e){
		e.printStackTrace();
	}
}

}

[hydroflame]

can you also put the Gui you're using AND the GuiHandler instantiated in your main mod file ?