Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

OOB Exception when adding entity to world.

AkitaAttribute

By AkitaAttribute
in Modder Support

 Share

Recommended Posts

AkitaAttribute Tree Puncher

AkitaAttribute

Posted
Posted

[Exception ticking world] - [Caused by: java.lang.ArrayIndexOutOfBoundsException: -1]

 

Really hoping someone has seen this before.  I'm probably doing something dumb (doing a lot dumb) that I just don't know is wrong when it comes to "world" stuff.

 

My code: Main SRC Dir

 

Subscribe Event where I'm replacing entities with custom ones: Line 247

 

Where I'm actually adding the entity to the world: Line 52

 

I know this is working because I've seen it in my world.  After one working instance, the world hangs, and eventually crashes with the below log dump.

 

Please don't harp on poor coding style (the threading for the world I would like to know if that's the issue), as this is a work in progress.

 

  Reveal hidden contents

 

Draco18s Reality Controller

Draco18s

Posted
Posted

https://github.com/AkitaAttribute/rpg-elements/blob/working_but_crashing/src/main/java/magicsixteen/rpgelements/RpgElements.java#L252
item.isEmpty()

https://github.com/AkitaAttribute/rpg-elements/blob/working_but_crashing/src/main/java/magicsixteen/rpgelements/events/item/GlowingItemEntity.java#L15
Why are you storing an item entity inside your custom item entity? Just use the details of that entity to create yours using an existing constructor. You're trying to replace the entity, not wrap it.

https://github.com/AkitaAttribute/rpg-elements/blob/working_but_crashing/src/main/java/magicsixteen/rpgelements/RpgElements.java#L255
Not sure this check is needed.

https://github.com/AkitaAttribute/rpg-elements/blob/working_but_crashing/src/main/java/magicsixteen/rpgelements/events/item/GlowingItemEntity.java#L62-L108
This is a disgusting hack. One that I'm not even sure works.

https://github.com/AkitaAttribute/rpg-elements/blob/working_but_crashing/src/main/java/magicsixteen/rpgelements/util/GlowHelper.java#L61
This check almost certainly won't pass. Existing item entities will never appear in the glowing list.
Actually wait a minute. This entire class is useless.

Jesus fucking christ.

Just use the GlowingItemEntity to store a number of ticks and then in its on-tick, subtract one, and if it's less than 0, set glowing to false. You don't need a globally accessible list of all glowing item entities and when they should stop glowing. Nothing cares except the entity itself, so just store that data in the entity.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

AkitaAttribute Tree Puncher

AkitaAttribute

Posted
  • Author
Posted

https://gist.github.com/AkitaAttribute/52e1a06ee0c54256f50d615884aadf6f

 

New issues.

 

So @Draco18s, LivingDropsEvent happens first.  Which means that I can't run a check on the source of the dropped item to determine duration of the glow, and add that duration to the custom entity.

 

The updated branch takes most of your comments into consideration.  I tried to do a tracker for the brief moment I assume exists between LivingDrops and JoinedWorld events to pass the duration between them.  This doesn't work, and I'm getting a crash that I thought I had resolved by putting the world.addEntity onto another thread.

 

I'd love to hear input on what you think is the best solution for dealing with the duration between these two events.  And more importantly, why I'm getting the ConcurrentModificationException

Draco18s Reality Controller

Draco18s

Posted
Posted

I think you can modify the drops array during the LivingDropsEvent, though (well, collection, but it's not read-only so I don't see why you couldn't remove the originals and add yours).

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

AkitaAttribute Tree Puncher

AkitaAttribute

Posted
  • Author
Posted

That worked.  Had to modify the whole collection at once.  Save it temporarily, then remove the original, modify, then add the modified all at once.  I was getting the concurrent exception otherwise, and multi-drop mobs wouldn't drop anything.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept