Jump to content

How do I edit a class without being able to edit it?


Forjkraft

Recommended Posts

I made a mod, without forge, that involves editing an existing file (BehaviorDefaultDispenseItem). It works fine by itself, but I want to be able to use the mod with forge mods. Since forge doesn't allow editing of existing classes, how exactly would I do this?

 

The only way I can think of doing this is making a new class that is a subclass of behaviordefaultdispenseitem but includes the changes I've made, and a new block that's a subclass of dispenser but uses the new class instead and has the same block id as dispensers (so dispensers in existing maps would have my modifications). However I'm not sure if this would work or if there's a better way of doing something like this (or is what I want to do even possible?).

 

 

Link to comment
Share on other sites

that would work technicly but forge provides a library called ASM (they didnt make it btw, they're just distributing it with forge)

 

and this library allows you to change the code at runtime (after you launch the game but before its loaded)

 

theres a post about this like 15 minute ago

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Thanks! I managed to get my mod working using ASM but it works only in the IDE.

 

When I try to use my mod in the actual client, it finds the mod and recognizes it (it is in the mod list) but the mod doesn't work when I test it... is my jar set up incorrectly or something? did I forget to include a file?

 

right now my jar is located in the "mods" folder in .minecraft

 

and contains two folders, META-INF and mod (my package, which contains my 3 class files). all 3 class files are there, and the meta-inf has the manifest.mf file.

 

Link to comment
Share on other sites

yeah thats the other shitty part about ASMing with minecraft,

 

when recompiling minecraft you will re'obfuscate your code, meaning names like Minecraft.java will become atd.jva (thats notch way of protecting his code) so your coremod (ASM module/code that will change the code ) has to also take this in consideration

the conf folder contains a file called joined.srg, open this file with a text editor (notepad, notepad++, less, more, vi, EDIT etc) and you will see the de-obfuscated name (the one you're used to work with) and the obfuscated name (something like  "ats" "jd", a lot of combination of 2-3 letters, yes its shitty to read)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

then the problem is NOT mcmod.info, it doesnt make the mod not-functionning

i would say double check that you have effectively replaced obfuscated code correctly because other then that i dont see where it can be

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

The obfuscated name can't be the problem

From the log: 2013-07-25 10:11:20 [iNFO] [sTDOUT] ** INSIDE OBFUSCATED DISPENSE BEHAVIOR TRANSFORMER ABOUT TO PATCH: bg

 

In my class transformer, I have this:

 

if (arg0.equals("bg")) {
		System.out.println("** INSIDE OBFUSCATED DISPENSE BEHAVIOR TRANSFORMER ABOUT TO PATCH: " + arg0);

 

so it's getting the obfuscated name

Link to comment
Share on other sites

but why would the deobfuscated work but not the obfuscated one?

 

obfuscated:

if (arg0.equals("bg")) {
		System.out.println("** INSIDE OBFUSCATED DISPENSE BEHAVIOR TRANSFORMER ABOUT TO PATCH: " + arg0);
		return patchClassASM(arg0, arg2, true); 
	}

 

deobfuscated (this works):

if (arg0.equals("net.minecraft.dispenser.BehaviorDefaultDispenseItem")) {
		System.out.println("***** INSIDE DISPENSE BEHAVIOR TRANSFORMER ABOUT TO PATCH:" + arg0);
		return patchClassASM(arg0, arg2, false); 
	}

 

 

in patchClassASM I have this:

		if (obfuscated == true)
		targetMethodName = "a"; 
	else 
		targetMethodName = "dispense"; 

maybe "a" is incorrect?

in methods.csv, the method dispense says the "searge" is "func_82482_a"

Link to comment
Share on other sites

if you're calling method inside the method you're changing and youdidnt change those method also it could cause bugs

 

also, saying that if deob work mean that obf work is same as saying that

 

this code:

if (obfuscated == true)

targetMethodName = "penis";

else

targetMethodName = "dispense";

 

is right because the deobf version is right. its obviously false, the deobf version and obf version are COMPLETELLY different, so if one works that doesnt mean the other will

 

maybe "a" is incorrect?

in methods.csv, the method dispense says the "searge" is "func_82482_a"

 

String m1 = "a";

String m2 = "func_82482_a";

m1.equals(m2) ??? since when ?

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

I tried replacing it with "func_82482_a" and it didn't work either...

 

I know it is reaching the if statement (I put a println right before I set the method name to func_82482_a to make sure it's getting at least that far).

Is it not the obfuscated name then?

Link to comment
Share on other sites

usually the obfuscated names have MAX 3 letter (2 to 3 letters)

 

so no func_etc is not the method name, but you can find it in the joined.srg file in conf

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

if the code you are replacing is calling something that can be obfuscated/deobfus  and that part isnt change it will also fuck.

 

 

example (pseudo code, not real)

 

blah

blah

blah

 

InsnList n = new wtv

n.insert(new method call instruction to call method "Minecraft.getMinecraft()")

 

Minecraft.getMinecraft() is also obfuscated, so basicly inserting thsi in obfuscated code will refer to a function that doesnt exists, in a obf envir

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

package dissapear when you obfuscate

 

net.minecraft.client.Minecraft become just "at" (or wtv, 2-3 letter name)

 

if you open minecraft.jar you will see that there is no folder but like 1000 file just laying at the root of the jar, that cuz theres no pkg

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.