Jump to content

[Solved]How to change damage on right click?


Taji34

Recommended Posts

So I'm trying to create an item that deals damage on left click, like a sword, however I can't seem to get the item to do a custom damage amount. For debuging purposes I set the damage value to 100000, however, it still acts as if the item doesn't have a damage value set. Here is my code:

(Code removed)

There don't seem to be any tutorials out there that detail how to make a custom weapon in forge, so I might be missing a method, but I did my best to look through the Sword.java  and pick out the relevant methods.

 

Okay, my problem now is that I want to change the damage dealt to NPCs on a right click, however, when I change the weaponDamage variable, minecraft does not register the change.

Link to comment
Share on other sites

On 1.6.2, getDamageVsEntity(entity) do not exist anymore.

This is replaced with Attribute, modifiers and such.

Could you give me an example? I must be missing something somewhere, since it isn't dealing the damage I want it to.

Link to comment
Share on other sites

Yeah thats true that there is something with atributes.

Search for the function which outputs a MultiMap.

 

By the way i have a question too.

I did make a special sword (only 10 uses) and it does work on 1.5

It give 3 damage on on every entity. But not on pigs. Pigs get only 1 damage.

Now is the problem on 1.6 you can not look at the entities.

I have kind of an idea but that require alot of testing and i do not want that because then the multimap is useless.

And i want to stay compatible with other swords^^"

So how is that fixable?

Link to comment
Share on other sites

Okay, so I got it to deal damage, but now I'm trying to get the amount of damage dealt to change on right click, but even though I change the value of weaponDamage, the damage output doesn't change. Is there something else I have to call for it the register the change?

Link to comment
Share on other sites

would you mind posting code?

Here's my current code for the item:

package taji34.troncraft;
import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;

import com.google.common.collect.Multimap;

import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.entity.EntityClientPlayerMP;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.ai.attributes.AttributeModifier;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagByte;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.network.packet.Packet250CustomPayload;
import net.minecraft.world.World;
public class Baton extends Item {
    private float weaponDamage;
    private boolean active = false;
public Baton(int par1) {
	super(par1);
	setMaxStackSize(1);
	setCreativeTab(CreativeTabs.tabMisc);
	setUnlocalizedName("Baton");
	this.weaponDamage = 0.0F;
}
    @Override
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister iconRegister) {
        this.itemIcon = iconRegister.registerIcon("Troncraft:Baton");
    }
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
    	if(!par2World.isRemote)
    	{
    	NBTTagCompound tag = par1ItemStack.getTagCompound();
    	if (tag == null) {
    		tag = new NBTTagCompound();
    		par1ItemStack.setTagCompound(tag);
    	}
    	if (tag.getName().equals("tag")) {
    		tag.setName("Normal");
    	}
    	if (!this.active)
    	{
    			this.active = true;
    			PacketDispatcher.sendPacketToServer(new BatonModePacket("activate").makePacket());
    	//		if(tag.getName().equals("Sword"))
    	//		{
    	//			this.weaponDamage = 10000.0F;
    	//			this.func_111205_h();
    	//		}
    	//		else if(tag.getName().equals("Staff"))
    	//		{
    	//			this.weaponDamage = 2.0F;
    	//		}
    	//		else if(tag.getName().equals("Normal"))
    	//		{
    	//			this.weaponDamage = 0.0F;
    	//		}
    	}
    	else
    	{
    		this.active = false;
    	//	this.weaponDamage = 0.0F;
    	}
    	System.out.println(tag.getName() + " " + active + " " + this.weaponDamage);
    	}
    	return par1ItemStack;
    }
    public Multimap func_111205_h()
    {
        Multimap multimap = super.func_111205_h();
        multimap.put(SharedMonsterAttributes.field_111264_e.func_111108_a(), new AttributeModifier(field_111210_e, "Weapon modifier", (double)this.weaponDamage, 0));
        return multimap;
    }
public void setWeaponDamage(float damage) {
	this.weaponDamage = damage;

}
    
}

 

I got it to deal damage, which is just by adding the following code to the item:

    public Multimap func_111205_h()
    {
        Multimap multimap = super.func_111205_h();
        multimap.put(SharedMonsterAttributes.field_111264_e.func_111108_a(), new AttributeModifier(field_111210_e, "Weapon modifier", (double)this.weaponDamage, 0));
        return multimap;
    }

 

But I can't seem to get it to deal different amounts of damage after a right click, currently I'm trying to send a packet to the server.

Link to comment
Share on other sites

I had the same issue as you and for me the function with the MultiMap didn't work.

What I did is that I looked at the source for ModularPowersuits(you can find it on GitHub) and I made this function(probably not the best, but I think it works)

 

@Override
    public boolean hitEntity(ItemStack par1ItemStack, EntityLivingBase par2EntityLivingBase, EntityLivingBase par3EntityLivingBase)
    {
    	float damage = 0.0F;
    	if(par1ItemStack.hasTagCompound())
		if(par1ItemStack.getTagCompound().getBoolean("speed"))
			damage+=2.0F;
    	DamageSource damagesource = DamageSource.causePlayerDamage((EntityPlayer)par3EntityLivingBase);
    	par2EntityLivingBase.attackEntityFrom(damagesource, damage);
    	par1ItemStack.damageItem(1, par3EntityLivingBase);
    return true;
    }

 

It damages the entity being hit with an additional amount of damage.I could not find a way to decrease the damage however...

Link to comment
Share on other sites

i dont know if its the right way to do this but its deffinitelly going to work

so your custom sword need to make special implementation of:

onItemRightClick(ItemStack, World, EntityPlayer)

you will also need a "LivingAttackHandler"

to know about NBT and events

basicly what you do is when the player right clicks, in the Item method you override you change the nbt of the itemstack (cycle through numbers from 0 to max)

 

in the LivingAttackHandler you check if the attacking entity is a player, who is holding your custom sword

if both thos condition are true then you check the nbt of the item and change the damage of the damageSource appropriately

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

i dont know if its the right way to do this but its deffinitelly going to work

so your custom sword need to make special implementation of:

onItemRightClick(ItemStack, World, EntityPlayer)

you will also need a "LivingAttackHandler"

to know about NBT and events

basicly what you do is when the player right clicks, in the Item method you override you change the nbt of the itemstack (cycle through numbers from 0 to max)

 

in the LivingAttackHandler you check if the attacking entity is a player, who is holding your custom sword

if both thos condition are true then you check the nbt of the item and change the damage of the damageSource appropriately

 

Hmm, okay, I'm still a little bit confused about the LivingAttackHandler. Is it a packet handler or something different? Is there a tutorial somewhere you could point me to? I tried googling it but nothing came up.

Link to comment
Share on other sites

if you look at the wiki you can find tutorials for even handlers, LivingAttackEvent is a kind of event handler

Okay, so I registered a LivingAttackEvent, but I must have done something wrong because now my weapon doesn't do damage at all, I left click with it, and nothing happens. Here's what I got for code, tell me if I'm missing something:

 

Troncraft.java:

package taji34.troncraft;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.entity.RenderSnowball;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.projectile.EntitySnowball;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import net.minecraftforge.common.MinecraftForge;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.Mod.PostInit;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
@Mod(modid="Troncraft", name="Troncraft", version="0.0.1")
@NetworkMod(clientSideRequired=true, serverSideRequired=false, channels={"troncraft"}, packetHandler = TajiPacketHandler.class)
public class Troncraft {
        // The instance of your mod that Forge uses.
        @Instance("Troncraft")
        public static Troncraft instance;
        public final static Item identityDisk = new IdentityDisk(5001);
        int diskItemID = identityDisk.itemID;
    	private final static Item baton = new Baton(5002);
    	int batonItemID = baton.itemID;
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="taji34.troncraft.client.ClientProxy", serverSide="taji34.troncraft.CommonProxy")
        public static CommonProxy proxy;
        @EventHandler
        public void preInit(FMLPreInitializationEvent event) {
                // Stub Method
        }
        @EventHandler
        public void load(FMLInitializationEvent event) {
            LanguageRegistry.addName(identityDisk, "Identity Disk");
            LanguageRegistry.addName(baton, "Baton");
            EntityRegistry.registerModEntity(EntityIdentityDisk.class, "IdentityDisk", 5001, this, 40, 3, true);
            RenderingRegistry.registerEntityRenderingHandler(EntityIdentityDisk.class, new RenderSnowball(identityDisk));
        	KeyBindingRegistry.registerKeyBinding(new TajiKeyHandler());
        	MinecraftForge.EVENT_BUS.register(new TajiEvents());
        }
        @EventHandler
        public void postInit(FMLPostInitializationEvent event) {
                // Stub Method
        }
}

 

Baton.java (the weapon):

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;

import com.google.common.collect.Multimap;

import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.client.entity.EntityClientPlayerMP;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.ai.attributes.AttributeModifier;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagByte;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.network.packet.Packet250CustomPayload;
import net.minecraft.world.World;
public class Baton extends Item {
    private float weaponDamage;
    private boolean active = false;
public Baton(int par1) {
	super(par1);
	setMaxStackSize(1);
	setCreativeTab(CreativeTabs.tabMisc);
	setUnlocalizedName("Baton");
	this.weaponDamage = 0.0F;
}
    @Override
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister iconRegister) {
        this.itemIcon = iconRegister.registerIcon("Troncraft:Baton");
    }
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
    	if(!par2World.isRemote)
    	{
    	NBTTagCompound tag = par1ItemStack.getTagCompound();
    	if (tag == null) {
    		tag = new NBTTagCompound();
    		par1ItemStack.setTagCompound(tag);
    	}
    	if (tag.getName().equals("tag")) {
    		tag.setName("Normal");
    	}
	System.out.println(tag.getInteger("Damage"));
    	if (!this.active)
    	{
    			this.active = true;
    			PacketDispatcher.sendPacketToServer(new BatonModePacket("activate").makePacket());
    	//		if(tag.getName().equals("Sword"))
    	//		{
    	//			this.weaponDamage = 10000.0F;
    	//			this.func_111205_h();
    	//		}
    	//		else if(tag.getName().equals("Staff"))
    	//		{
    	//			this.weaponDamage = 2.0F;
    	//		}
    	//		else if(tag.getName().equals("Normal"))
    	//		{
    	//			this.weaponDamage = 0.0F;
    	//		}
    	}
    	else
    	{
    		this.active = false;
    		PacketDispatcher.sendPacketToServer(new BatonModePacket("deactivate").makePacket());
    	}
    	}
    	return par1ItemStack;
    }
    public Multimap func_111205_h()
    {
        Multimap multimap = super.func_111205_h();
        multimap.put(SharedMonsterAttributes.field_111264_e.func_111108_a(), new AttributeModifier(field_111210_e, "Weapon modifier", (double)this.weaponDamage, 0));
        return multimap;
    }
public void setWeaponDamage(float damage) {
	this.weaponDamage = damage;

}
    
}

 

TajiEvents.java:

package taji34.troncraft;

import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.DamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingAttackEvent;

public class TajiEvents {
@ForgeSubscribe
public void entityAttacked(LivingAttackEvent event)
{
	EntityLiving attackedEnt = (EntityLiving) event.entityLiving;
	DamageSource attackSource = event.source;
	float damage = event.ammount;

	EntityPlayer player = (EntityPlayer) attackSource.getSourceOfDamage();
    	ItemStack itemstack = player.getHeldItem();
    	if (itemstack.getDisplayName().equals("Baton"))
	{
    		NBTTagCompound tag = itemstack.getTagCompound();
    		int damageAmmount = tag.getInteger("Damage");
    		damage = damageAmmount;
	}

	if (event.isCancelable())
	{
		event.setCanceled(true);
	}
}
}

 

I've got the NBT data working, where it switches and integer tag between values on right click.

Link to comment
Share on other sites

You are cancelling the event, no wonder nothing happens.

if (event.isCancelable())
	{
		event.setCanceled(true);
	}

I thought that, but when I tried deleting it, it crashes on start-up.

 

@gotolink is right

and event.ammount is never changed

 

How would I go about doing that? Putting event.ammount = damageAmmount instead of damage = damageAmmount?

Link to comment
Share on other sites

well first you got to stop canceling it becasue tahts obvious no dmg will be outputed

 

How would I go about doing that? Putting event.ammount = damageAmmount instead of damage = damageAmmount?

yes .. and this is actually somewhat basic java so maybe you should just look into it a little :)

 

UNLESS you have already worked with other language before (such as C++) and you are thinking that float are used like pointers, well then you should know that in java theres no pointer, every primitive type is direct and every object is a reference :)

 

happy modding

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

well first you got to stop canceling it becasue tahts obvious no dmg will be outputed

 

How would I go about doing that? Putting event.ammount = damageAmmount instead of damage = damageAmmount?

yes .. and this is actually somewhat basic java so maybe you should just look into it a little :)

 

UNLESS you have already worked with other language before (such as C++) and you are thinking that float are used like pointers, well then you should know that in java theres no pointer, every primitive type is direct and every object is a reference :)

 

happy modding

 

Yeah, I've been on about a 5 or 6 month hiatus from coding in java, so I'm a little rusty! Plus even during then, I didn't use float variables at all.

Link to comment
Share on other sites

<TheMoreYouKnow>

technicly double are the standard floating point variable (if you declare a float you have to use 3.2F  <- to tell the compiler to cast into float)

 

but i prefer usign float as not everyone today has a 64 bit architecture. causing them to do twice as much instruction for a double since their cpu can only handle 32 bit at once (requiring the cpu to do 2 operation per read/write of a double

 

</TheMoreYouKnow>

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

hen??? oh, well do the same with livingHurtEvent because this one isnt final :P  its th same thing but dmg received

Yeah, it's probably an "Anti-hack" thing, since once the event is sent, they don't want anyone to change the value of the damage.

Link to comment
Share on other sites

It's finally working the way I want it! In case anyone is interested here is the code I used. It's not commented, but if you want me to explain any of it, just send me a PM.

 

Troncraft.java:

package taji34.troncraft;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.entity.RenderSnowball;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.entity.projectile.EntitySnowball;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.src.ModLoader;
import net.minecraftforge.common.MinecraftForge;
import cpw.mods.fml.client.registry.KeyBindingRegistry;
import cpw.mods.fml.client.registry.KeyBindingRegistry.KeyHandler;
import cpw.mods.fml.client.registry.RenderingRegistry;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.Init;
import cpw.mods.fml.common.Mod.Instance;
import cpw.mods.fml.common.Mod.PostInit;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.SidedProxy;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.EntityRegistry;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
@Mod(modid="Troncraft", name="Troncraft", version="0.0.1")
@NetworkMod(clientSideRequired=true, serverSideRequired=false, channels={"troncraft"}, packetHandler = TajiPacketHandler.class)
public class Troncraft {
        // The instance of your mod that Forge uses.
        @Instance("Troncraft")
        public static Troncraft instance;
        public final static Item identityDisk = new IdentityDisk(5001);
        int diskItemID = identityDisk.itemID;
    	private final static Item baton = new Baton(5002);
    	int batonItemID = baton.itemID;
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="taji34.troncraft.client.ClientProxy", serverSide="taji34.troncraft.CommonProxy")
        public static CommonProxy proxy;
        @EventHandler
        public void preInit(FMLPreInitializationEvent event) {
                // Stub Method
        }
        @EventHandler
        public void load(FMLInitializationEvent event) {
            LanguageRegistry.addName(identityDisk, "Identity Disk");
            LanguageRegistry.addName(baton, "Baton");
            EntityRegistry.registerModEntity(EntityIdentityDisk.class, "IdentityDisk", 5001, this, 40, 3, true);
            RenderingRegistry.registerEntityRenderingHandler(EntityIdentityDisk.class, new RenderSnowball(identityDisk));
        	KeyBindingRegistry.registerKeyBinding(new TajiKeyHandler());
        	MinecraftForge.EVENT_BUS.register(new TajiEvents());
        }
        @EventHandler
        public void postInit(FMLPostInitializationEvent event) {
                // Stub Method
        }
}

 

Baton.java:

package taji34.troncraft;

import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;

public class Baton extends Item {
    private boolean active = false;
public Baton(int par1) {
	super(par1);
	setMaxStackSize(1);
	setCreativeTab(CreativeTabs.tabMisc);
	setUnlocalizedName("Baton");
}
    @Override
    @SideOnly(Side.CLIENT)
    public void registerIcons(IconRegister iconRegister) {
        this.itemIcon = iconRegister.registerIcon("Troncraft:Baton");
    }
    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
    	if(!par2World.isRemote)
    	{
    	NBTTagCompound tag = par1ItemStack.getTagCompound();
    	if (tag == null) {
    		tag = new NBTTagCompound();
    		par1ItemStack.setTagCompound(tag);
    	}
    	if (tag.getName().equals("tag")) {
    		tag.setName("Normal");
    	}
	System.out.println(tag.getInteger("Damage"));
    	if (!this.active)
    	{
    			this.active = true;
    			PacketDispatcher.sendPacketToServer(new BatonModePacket("activate").makePacket());
    	}
    	else
    	{
    		this.active = false;
    		PacketDispatcher.sendPacketToServer(new BatonModePacket("deactivate").makePacket());
    	}
    	}
    	return par1ItemStack;
    }    
}

 

BatonModePacket.java:

package taji34.troncraft;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;

import com.google.common.io.ByteArrayDataInput;
import com.google.common.io.ByteArrayDataOutput;

import cpw.mods.fml.relauncher.Side;

public class BatonModePacket extends TajiPacket {

    private String text;
   
    public BatonModePacket(String text) {
            this.text = text;
    }

    public BatonModePacket() { } 

    @Override
protected void write(ByteArrayDataOutput out) {
            out.writeUTF(text);
    }

    @Override
    protected void read(ByteArrayDataInput in) throws ProtocolException {
            text = in.readUTF();
    }

    @Override
    protected void execute(EntityPlayer player, Side side) throws ProtocolException {
    	ItemStack itemstack = player.getHeldItem();
    	Baton baton = (Baton) itemstack.getItem();
    		if (itemstack.getDisplayName().equals("Baton"))
    		{
    			NBTTagCompound tag = itemstack.getTagCompound();
    			if (text.equals("Sword"))
    			{
    				tag.setName("Sword");
    			}
    			else if (text.equals("Staff"))
    			{
    				tag.setName("Staff");
    			}
    			else if (text.equals("Normal"))
    			{
    				tag.setName("Normal");
    			}
    			if (text.equals("activate"))
    			{
    				tag.setInteger("Damage", 1000);
    			}
    			if (text.equals("deactivate"))
    			{
    				tag.setInteger("Damage", 0);
    			}
    			System.out.println(tag.getInteger("Damage"));
    		}
    }
}

 

TajiEvents.java:

package taji34.troncraft;

import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.DamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingHurtEvent;

public class TajiEvents {
@ForgeSubscribe
public void entityAttacked(LivingHurtEvent event)
{
	EntityLiving attackedEnt = (EntityLiving) event.entityLiving;
	DamageSource attackSource = event.source;
	if (attackSource.getSourceOfDamage() != null)
	{
		EntityPlayer player = (EntityPlayer) attackSource.getSourceOfDamage();
		if(player.getHeldItem() != null)
		{
			ItemStack itemstack = player.getHeldItem();
			if (itemstack.getDisplayName().equals("Baton"))
			{
				NBTTagCompound tag = itemstack.getTagCompound();
				int damageAmmount = tag.getInteger("Damage");
				event.ammount = damageAmmount;
			}
		}
	}
}
}

 

Finished product changes it's damage output when it is held in the player's hand and right clicked.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.