Jump to content

Saving data to players on lan


CaptainMiner

Recommended Posts

Hi, im making a gold coin manager for minecraft 1.6.2 you can add and remove gold. It saves fine for singleplayer and for the player hosting the world over lan, but it doesnt save gold for other players over lan and they have to start again!

 

My question:

How can i save the int gold for a player over lan?

 

Details:

Im using NBTTagCompound to save and load.

 

My GoldHandler class:

 

package ate.handlers;

 

import ate.gui.GuiGold;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.nbt.NBTBase;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.nbt.NBTTagInt;

import cpw.mods.fml.common.network.Player;

 

public class GoldHandler {

 

private static int currGold;

 

public GoldHandler(EntityPlayer player) {

NBTTagCompound tag = player.getEntityData();

NBTBase gold = tag.getTag("player" + player.username + "Gold");

if(gold != null) {

currGold = ((NBTTagInt)gold).data;

} else {

currGold = 0;

tag.setInteger("player" + player.username + "Gold", 0);

}

}

 

public static void addGold(EntityPlayer player, int gold) {

int index;

GoldHandler instance;

for(int i=0; i<PlayerHandler.names.size(); i++) {

if(PlayerHandler.names.get(i).equalsIgnoreCase(player.username)) {

index = i;

instance = PlayerHandler.gh.get(i);

break;

}

}

currGold += gold;

NBTTagCompound tag = player.getEntityData();

tag.setInteger("player" + player.username + "Gold", currGold);

}

 

public static void removeGold(EntityPlayer player, int gold) {

int index;

GoldHandler instance;

for(int i=0; i<PlayerHandler.names.size(); i++) {

if(PlayerHandler.names.get(i).equalsIgnoreCase(player.username)) {

index = i;

instance = PlayerHandler.gh.get(i);

break;

}

}

currGold -= gold;

NBTTagCompound tag = player.getEntityData();

tag.setInteger("player" + player.username + "Gold", currGold);

}

 

public static int getCurrentGold(EntityPlayer player) {

NBTTagCompound tag = player.getEntityData();

NBTBase gold = tag.getTag("player" + player.username + "Gold");

if(gold != null) {

return ((NBTTagInt)gold).data;

} else {

return 0;

}

}

 

public static String getCurrentGoldAsString(EntityPlayer player) {

NBTTagCompound tag = player.getEntityData();

NBTBase gold = tag.getTag("player" + player.username + "Gold");

if(gold != null) {

return "" + ((NBTTagInt)gold).data;

} else {

return "0";

}

}

}

 

 

My PlayerHandler class:

 

package ate.handlers;

 

import java.util.ArrayList;

 

import net.minecraft.entity.player.EntityPlayer;

import cpw.mods.fml.common.IPlayerTracker;

 

public class PlayerHandler implements IPlayerTracker {

 

public static ArrayList<GoldHandler> gh = new ArrayList<GoldHandler>();

public static ArrayList<String> names = new ArrayList<String>();

 

@Override

public void onPlayerLogin(EntityPlayer player) {

GoldHandler h = new GoldHandler(player);

gh.add(h);

names.add(player.username);

System.out.println("Player " + player.username + " Joined; GOLD: " + h.getCurrentGoldAsString(player));

}

 

public void onPlayerLogout(EntityPlayer player) {

 

}

 

public void onPlayerChangedDimension(EntityPlayer player) {

 

}

 

public void onPlayerRespawn(EntityPlayer player) {

 

}

}

 

 

Please HELP!!!!    Thanks in advance!

Link to comment
Share on other sites

1: i would use IExtendedProperty for that (and EntityConstructingEvent)

2:

 

private static int currGold;

do you know what static means ??? because that would mean that its the SAME amount of gold for everyone

 

and btw theres no difference between LAN and a real server

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

i can 100% guarantee you that it doesnt work like you want it to

but since you're confident i wont talk about it

 

 

for IExtendedProperty, make a class that implements it and attach it to an entity. this way you will be noticed when an entity is saved to the NBT and you can add your gold there

 

 

ps: [lmgtfy]how to use hashmap in java[/lmgtfy], trust me it will help

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Like this?:      Its not printing the "Testing 123..."    I tried @ForgeSubscribe, that didnt work either!  :(

 

 

package ate.handlers;

 

import com.google.common.eventbus.Subscribe;

 

import net.minecraft.entity.Entity;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.world.World;

import net.minecraftforge.common.IExtendedEntityProperties;

import net.minecraftforge.event.ForgeSubscribe;

import net.minecraftforge.event.entity.EntityEvent;

 

public class Test implements IExtendedEntityProperties {

 

@Subscribe

public void onEntityConstructed(EntityEvent.EntityConstructing event) {

System.out.println("Testing 123...");

}

 

@Override

public void saveNBTData(NBTTagCompound compound) {

 

}

 

@Override

public void loadNBTData(NBTTagCompound compound) {

 

}

 

@Override

public void init(Entity entity, World world) {

 

}

}

 

 

Link to comment
Share on other sites

am i the only one who actually traced the code and foudn out that the currGold should NOT be static

 

 

1 everythign in thsi class is static except the constructor (but it cant sooo ... )

 

2:

public static void addGold(EntityPlayer player, int gold) {
      int index;
      GoldHandler instance;
      for(int i=0; i<PlayerHandler.names.size(); i++) {
         if(PlayerHandler.names.get(i).equalsIgnoreCase(player.username)) {
            index = i;
            instance = PlayerHandler.gh.get(i);
            break;
         }
      }
      currGold += gold;
      NBTTagCompound tag = player.getEntityData();
      tag.setInteger("player" + player.username + "Gold", currGold);
   }

what exactly is the variable "instance" suppose to do ? same for "index"

this code is the same as:

public static void addGold(EntityPlayer player, int gold) {
      currGold += gold;
      NBTTagCompound tag = player.getEntityData();
      tag.setInteger("player" + player.username + "Gold", currGold);
   }

 

 

same here ? instance and index are never used (actually most IDE would be whining about this)

public static void removeGold(EntityPlayer player, int gold) {
      int index;
      GoldHandler instance;
      for(int i=0; i<PlayerHandler.names.size(); i++) {
         if(PlayerHandler.names.get(i).equalsIgnoreCase(player.username)) {
            index = i;
            instance = PlayerHandler.gh.get(i);
            break;
         }
      }
      currGold -= gold;
      NBTTagCompound tag = player.getEntityData();
      tag.setInteger("player" + player.username + "Gold", currGold);
   }

is the same as:

public static void removeGold(EntityPlayer player, int gold) {
      currGold -= gold;
      NBTTagCompound tag = player.getEntityData();
      tag.setInteger("player" + player.username + "Gold", currGold);
   }

 

if you want to see how it doesnt work

 

do this:

take 2 player, set their gold to 50 each

add 25 gold to one player

remove 10 gold to the OTHER player

 

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
    • I have no idea - switch to a pre-configured modpack and use it as working base    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.